AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
992a37234c
qt5base-lts/tests/auto/corelib/tools
History
Bradley T. Hughes 992a37234c Don't crash by modifying read-only shared_null 
Functions that modify the d-pointer must detach or otherwise take
measures to not modify the const, read-only shared_null.

The setSharable(bool) function takes care to detach when setting
sharable to false, but should avoid setting the sharable data member
unless d is not the shared null.

Similarly, QMap<Key, T>::setInsertInOrder() needs to detach if it is
shared with the shared_null (the logic has been updated to be the same
as setSharable()).

Change-Id: Ida5cb9818b86695f1b9f0264418b955c56424898
Reviewed-on: http://codereview.qt-project.org/5929
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
2011-10-04 11:21:25 +02:00
..
qalgorithms Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qbitarray Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qbytearray Remove Symbian-specific code from tests. 2011-09-29 06:41:42 +02:00
qbytearraymatcher Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qcache Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qchar Remove Symbian-specific code from tests. 2011-09-29 06:41:42 +02:00
qcontiguouscache Make all uses of QBasicAtomicInt and Pointer use load() and store() 2011-10-03 07:57:41 +02:00
qcryptographichash Remove Symbian-specific code from tests. 2011-09-29 06:41:42 +02:00
qdate Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qdatetime Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qeasingcurve Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qelapsedtimer Remove Symbian-specific code from tests. 2011-09-29 06:41:42 +02:00
qexplicitlyshareddatapointer Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qfreelist Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qhash Don't crash by modifying read-only shared_null 2011-10-04 11:21:25 +02:00
qline Remove Symbian-specific code from tests. 2011-09-29 06:41:42 +02:00
qlist Don't crash by modifying read-only shared_null 2011-10-04 11:21:25 +02:00
qlocale Remove Symbian-specific code from tests. 2011-09-29 06:41:42 +02:00
qmap Don't crash by modifying read-only shared_null 2011-10-04 11:21:25 +02:00
qmargins Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qpoint Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qqueue Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qrect Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qregexp Remove Symbian-specific code from tests. 2011-09-29 06:41:42 +02:00
qringbuffer Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qscopedpointer Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qscopedvaluerollback Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qset Remove Symbian-specific code from tests. 2011-09-29 06:41:42 +02:00
qsharedpointer Make all uses of QBasicAtomicInt and Pointer use load() and store() 2011-10-03 07:57:41 +02:00
qsize Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qsizef Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qstl Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qstring Tests: Fix compilation on Windows. 2011-10-03 07:57:41 +02:00
qstringbuilder Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qstringlist Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qstringmatcher Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qstringref Tests: Fix compilation on Windows. 2011-10-03 07:57:41 +02:00
qtextboundaryfinder Remove Symbian-specific code from tests. 2011-09-29 06:41:42 +02:00
qtime Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qtimeline Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qvarlengtharray Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00
qvector Don't crash by modifying read-only shared_null 2011-10-04 11:21:25 +02:00
tools.pro Moving relevant tests to corelib/tools 2011-09-01 13:07:23 +02:00