24e504d9df
The message processing may finish before watcherHelper is setup. Use locking and an additional check for message processing completion to avoid the race condition. Move the code to new function inside QDBusPendingCallPrivate, close to where the waiting without GUI is done. Add assertions that check that watcherHelper is not overwritten. Change-Id: I24e54598135edf293c41b3a80369b0a3b46f775c Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
527 lines
16 KiB
C++
527 lines
16 KiB
C++
// Copyright (C) 2016 The Qt Company Ltd.
|
|
// Copyright (C) 2016 Intel Corporation.
|
|
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
|
|
|
|
#include "qdbuspendingcall.h"
|
|
#include "qdbuspendingcall_p.h"
|
|
|
|
#include "qdbusconnection_p.h"
|
|
#include "qdbusmetatype_p.h"
|
|
#include "qdbusutil_p.h"
|
|
#include "qcoreapplication.h"
|
|
#include "qcoreevent.h"
|
|
#include <private/qobject_p.h>
|
|
#include <private/qlocking_p.h>
|
|
|
|
#ifndef QT_NO_DBUS
|
|
|
|
QT_BEGIN_NAMESPACE
|
|
|
|
using namespace Qt::StringLiterals;
|
|
|
|
/*!
|
|
\class QDBusPendingCall
|
|
\inmodule QtDBus
|
|
\ingroup shared
|
|
\since 4.5
|
|
|
|
\brief The QDBusPendingCall class refers to one pending asynchronous call.
|
|
|
|
A QDBusPendingCall object is a reference to a method call that was
|
|
sent over D-Bus without waiting for a reply. QDBusPendingCall is an
|
|
opaque type, meant to be used as a handle for a pending reply.
|
|
|
|
In most programs, the QDBusPendingCall class will not be used
|
|
directly. It can be safely replaced with the template-based
|
|
QDBusPendingReply, in order to access the contents of the reply or
|
|
wait for it to be complete.
|
|
|
|
The QDBusPendingCallWatcher class allows one to connect to a signal
|
|
that will indicate when the reply has arrived or if the call has
|
|
timed out. It also provides the
|
|
QDBusPendingCallWatcher::waitForFinished() method which will suspend
|
|
the execution of the program until the reply has arrived.
|
|
|
|
\note If you create a copy of a QDBusPendingCall object, all
|
|
information will be shared among the many copies. Therefore,
|
|
QDBusPendingCall is an explicitly-shared object and does not
|
|
provide a method of detaching the copies (since they refer
|
|
to the same pending call)
|
|
|
|
\sa QDBusPendingReply, QDBusPendingCallWatcher
|
|
*/
|
|
|
|
/*!
|
|
\class QDBusPendingCallWatcher
|
|
\inmodule QtDBus
|
|
\since 4.5
|
|
|
|
\brief The QDBusPendingCallWatcher class provides a convenient way for
|
|
waiting for asynchronous replies.
|
|
|
|
The QDBusPendingCallWatcher provides the finished() signal that will be
|
|
emitted when a reply arrives.
|
|
|
|
It is usually used like the following example:
|
|
|
|
\snippet code/src_qdbus_qdbuspendingcall.cpp 0
|
|
|
|
Note that it is not necessary to keep the original QDBusPendingCall
|
|
object around since QDBusPendingCallWatcher inherits from that class
|
|
too.
|
|
|
|
The slot connected to by the above code could be something similar
|
|
to the following:
|
|
|
|
\snippet code/src_qdbus_qdbuspendingcall.cpp 1
|
|
|
|
Note the use of QDBusPendingReply to validate the argument types in
|
|
the reply. If the reply did not contain exactly two arguments
|
|
(one string and one QByteArray), QDBusPendingReply::isError() will
|
|
return true.
|
|
|
|
\sa QDBusPendingReply
|
|
*/
|
|
|
|
/*!
|
|
\fn void QDBusPendingCallWatcher::finished(QDBusPendingCallWatcher *self)
|
|
|
|
This signal is emitted when the pending call has finished and its
|
|
reply is available. The \a self parameter is a pointer to the
|
|
object itself, passed for convenience so that the slot can access
|
|
the properties and determine the contents of the reply.
|
|
*/
|
|
|
|
void QDBusPendingCallWatcherHelper::add(QDBusPendingCallWatcher *watcher)
|
|
{
|
|
connect(this, &QDBusPendingCallWatcherHelper::finished, watcher,
|
|
[watcher] { Q_EMIT watcher->finished(watcher); }, Qt::QueuedConnection);
|
|
}
|
|
|
|
QDBusPendingCallPrivate::~QDBusPendingCallPrivate()
|
|
{
|
|
if (pending) {
|
|
q_dbus_pending_call_cancel(pending);
|
|
q_dbus_pending_call_unref(pending);
|
|
}
|
|
delete watcherHelper;
|
|
}
|
|
|
|
bool QDBusPendingCallPrivate::setReplyCallback(QObject *target, const char *member)
|
|
{
|
|
receiver = target;
|
|
metaTypes.clear();
|
|
methodIdx = -1;
|
|
if (!target)
|
|
return true;; // unsetting
|
|
|
|
if (!member || !*member) {
|
|
// would not be able to deliver a reply
|
|
qWarning("QDBusPendingCall::setReplyCallback: error: cannot deliver a reply to %s::%s (%s)",
|
|
target ? target->metaObject()->className() : "(null)",
|
|
member ? member + 1 : "(null)",
|
|
target ? qPrintable(target->objectName()) : "no name");
|
|
return false;
|
|
}
|
|
|
|
QString errorMsg;
|
|
methodIdx = QDBusConnectionPrivate::findSlot(target, member + 1, metaTypes, errorMsg);
|
|
if (methodIdx == -1) {
|
|
QByteArray normalizedName = QMetaObject::normalizedSignature(member + 1);
|
|
methodIdx = QDBusConnectionPrivate::findSlot(target, normalizedName, metaTypes, errorMsg);
|
|
}
|
|
if (methodIdx == -1) {
|
|
// would not be able to deliver a reply
|
|
qWarning("QDBusPendingCall::setReplyCallback: error: cannot deliver a reply to %s::%s (%s) "
|
|
"because %s",
|
|
target->metaObject()->className(), member + 1, qPrintable(target->objectName()),
|
|
qPrintable(errorMsg));
|
|
return false;
|
|
}
|
|
|
|
// success
|
|
// construct the expected signature
|
|
int count = metaTypes.size() - 1;
|
|
if (count == 1 && metaTypes.at(1) == QDBusMetaTypeId::message()) {
|
|
// wildcard slot, can receive anything, so don't set the signature
|
|
return true;
|
|
}
|
|
|
|
if (metaTypes.at(count) == QDBusMetaTypeId::message())
|
|
--count;
|
|
|
|
setMetaTypes(count, count ? metaTypes.constData() + 1 : nullptr);
|
|
return true;
|
|
}
|
|
|
|
void QDBusPendingCallPrivate::setMetaTypes(int count, const QMetaType *types)
|
|
{
|
|
if (count == 0) {
|
|
expectedReplySignature = ""_L1; // not null
|
|
return;
|
|
}
|
|
|
|
QByteArray sig;
|
|
sig.reserve(count + count / 2);
|
|
for (int i = 0; i < count; ++i) {
|
|
const char *typeSig = QDBusMetaType::typeToSignature(types[i]);
|
|
if (Q_UNLIKELY(!typeSig))
|
|
qFatal("QDBusPendingReply: type %s is not registered with QtDBus", types[i].name());
|
|
sig += typeSig;
|
|
}
|
|
|
|
expectedReplySignature = QString::fromLatin1(sig);
|
|
}
|
|
|
|
void QDBusPendingCallPrivate::checkReceivedSignature()
|
|
{
|
|
// MUST BE CALLED WITH A LOCKED MUTEX!
|
|
|
|
if (replyMessage.type() == QDBusMessage::InvalidMessage)
|
|
return; // not yet finished - no message to
|
|
// validate against
|
|
if (replyMessage.type() == QDBusMessage::ErrorMessage)
|
|
return; // we don't have to check the signature of an error reply
|
|
|
|
if (expectedReplySignature.isNull())
|
|
return; // no signature to validate against
|
|
|
|
// can't use startsWith here because a null string doesn't start or end with an empty string
|
|
if (replyMessage.signature().indexOf(expectedReplySignature) != 0) {
|
|
const auto errorMsg = "Unexpected reply signature: got \"%1\", expected \"%2\""_L1;
|
|
replyMessage = QDBusMessage::createError(
|
|
QDBusError::InvalidSignature,
|
|
errorMsg.arg(replyMessage.signature(), expectedReplySignature));
|
|
|
|
}
|
|
}
|
|
|
|
void QDBusPendingCallPrivate::waitForFinished()
|
|
{
|
|
const auto locker = qt_scoped_lock(mutex);
|
|
|
|
if (replyMessage.type() != QDBusMessage::InvalidMessage)
|
|
return; // already finished
|
|
|
|
waitForFinishedCondition.wait(&mutex);
|
|
}
|
|
|
|
void QDBusPendingCallPrivate::waitForFinishedWithGui()
|
|
{
|
|
QEventLoop loop;
|
|
|
|
{
|
|
const auto locker = qt_scoped_lock(mutex);
|
|
if (replyMessage.type() != QDBusMessage::InvalidMessage)
|
|
return; // already finished
|
|
|
|
Q_ASSERT(!watcherHelper);
|
|
watcherHelper = new QDBusPendingCallWatcherHelper;
|
|
loop.connect(watcherHelper, &QDBusPendingCallWatcherHelper::reply, &loop,
|
|
&QEventLoop::quit);
|
|
loop.connect(watcherHelper, &QDBusPendingCallWatcherHelper::error, &loop,
|
|
&QEventLoop::quit);
|
|
}
|
|
|
|
loop.exec(QEventLoop::ExcludeUserInputEvents | QEventLoop::WaitForMoreEvents);
|
|
}
|
|
|
|
/*!
|
|
Creates a copy of the \a other pending asynchronous call. Note
|
|
that both objects will refer to the same pending call.
|
|
*/
|
|
QDBusPendingCall::QDBusPendingCall(const QDBusPendingCall &other)
|
|
: d(other.d)
|
|
{
|
|
}
|
|
|
|
/*!
|
|
\internal
|
|
*/
|
|
QDBusPendingCall::QDBusPendingCall(QDBusPendingCallPrivate *dd)
|
|
: d(dd)
|
|
{
|
|
if (dd) {
|
|
bool r = dd->ref.deref();
|
|
Q_ASSERT(r);
|
|
}
|
|
}
|
|
|
|
/*!
|
|
Destroys this copy of the QDBusPendingCall object. If this copy is
|
|
also the last copy of a pending asynchronous call, the call will
|
|
be canceled and no further notifications will be received. There
|
|
will be no way of accessing the reply's contents when it arrives.
|
|
*/
|
|
QDBusPendingCall::~QDBusPendingCall()
|
|
{
|
|
// d deleted by QExplicitlySharedDataPointer
|
|
}
|
|
|
|
|
|
/*!
|
|
Creates a copy of the \a other pending asynchronous call and drops
|
|
the reference to the previously-referenced call. Note that both
|
|
objects will refer to the same pending call after this function.
|
|
|
|
If this object contained the last reference of a pending
|
|
asynchronous call, the call will be canceled and no further
|
|
notifications will be received. There will be no way of accessing
|
|
the reply's contents when it arrives.
|
|
*/
|
|
QDBusPendingCall &QDBusPendingCall::operator=(const QDBusPendingCall &other)
|
|
{
|
|
d = other.d;
|
|
return *this;
|
|
}
|
|
|
|
/*!
|
|
\fn void QDBusPendingCall::swap(QDBusPendingCall &other)
|
|
\since 5.0
|
|
|
|
Swaps this pending call instance with \a other. This function is
|
|
very fast and never fails.
|
|
*/
|
|
|
|
/*!
|
|
\fn bool QDBusPendingCallWatcher::isFinished() const
|
|
|
|
Returns \c true if the pending call has finished processing and the
|
|
reply has been received.
|
|
|
|
Note that this function only changes state if you call
|
|
waitForFinished() or if an external D-Bus event happens, which in
|
|
general only happens if you return to the event loop execution.
|
|
|
|
\sa QDBusPendingReply::isFinished()
|
|
*/
|
|
|
|
/*!
|
|
\fn template <typename... Types> bool QDBusPendingReply<Types...>::isFinished() const
|
|
|
|
Returns \c true if the pending call has finished processing and the
|
|
reply has been received. If this function returns \c true, the
|
|
isError(), error() and reply() methods should return valid
|
|
information.
|
|
|
|
Note that this function only changes state if you call
|
|
waitForFinished() or if an external D-Bus event happens, which in
|
|
general only happens if you return to the event loop execution.
|
|
|
|
\sa QDBusPendingCallWatcher::isFinished()
|
|
*/
|
|
|
|
bool QDBusPendingCall::isFinished() const
|
|
{
|
|
if (!d)
|
|
return true; // considered finished
|
|
|
|
const auto locker = qt_scoped_lock(d->mutex);
|
|
return d->replyMessage.type() != QDBusMessage::InvalidMessage;
|
|
}
|
|
|
|
void QDBusPendingCall::waitForFinished()
|
|
{
|
|
if (d) d->waitForFinished();
|
|
}
|
|
|
|
/*!
|
|
\fn template <typename... Types> bool QDBusPendingReply<Types...>::isValid() const
|
|
|
|
Returns \c true if the reply contains a normal reply message, false
|
|
if it contains anything else.
|
|
|
|
If the pending call has not finished processing, this function
|
|
return false.
|
|
*/
|
|
bool QDBusPendingCall::isValid() const
|
|
{
|
|
if (!d)
|
|
return false;
|
|
const auto locker = qt_scoped_lock(d->mutex);
|
|
return d->replyMessage.type() == QDBusMessage::ReplyMessage;
|
|
}
|
|
|
|
/*!
|
|
\fn template <typename... Types> bool QDBusPendingReply<Types...>::isError() const
|
|
|
|
Returns \c true if the reply contains an error message, false if it
|
|
contains a normal method reply.
|
|
|
|
If the pending call has not finished processing, this function
|
|
also returns \c true.
|
|
*/
|
|
bool QDBusPendingCall::isError() const
|
|
{
|
|
if (!d)
|
|
return true; // considered finished and an error
|
|
const auto locker = qt_scoped_lock(d->mutex);
|
|
return d->replyMessage.type() == QDBusMessage::ErrorMessage;
|
|
}
|
|
|
|
/*!
|
|
\fn template <typename... Types> QDBusError QDBusPendingReply<Types...>::error() const
|
|
|
|
Retrieves the error content of the reply message, if it has
|
|
finished processing. If the reply message has not finished
|
|
processing or if it contains a normal reply message (non-error),
|
|
this function returns an invalid QDBusError.
|
|
*/
|
|
QDBusError QDBusPendingCall::error() const
|
|
{
|
|
if (d) {
|
|
const auto locker = qt_scoped_lock(d->mutex);
|
|
return QDBusError(d->replyMessage);
|
|
}
|
|
|
|
// not connected, return an error
|
|
QDBusError err = QDBusError(QDBusError::Disconnected,
|
|
QDBusUtil::disconnectedErrorMessage());
|
|
return err;
|
|
}
|
|
|
|
/*!
|
|
\fn template <typename... Types> QDBusMessage QDBusPendingReply<Types...>::reply() const
|
|
|
|
Retrieves the reply message received for the asynchronous call
|
|
that was sent, if it has finished processing. If the pending call
|
|
is not finished, this function returns a QDBusMessage of type
|
|
QDBusMessage::InvalidMessage.
|
|
|
|
After it has finished processing, the message type will either be
|
|
an error message or a normal method reply message.
|
|
*/
|
|
QDBusMessage QDBusPendingCall::reply() const
|
|
{
|
|
if (!d)
|
|
return QDBusMessage::createError(error());
|
|
const auto locker = qt_scoped_lock(d->mutex);
|
|
return d->replyMessage;
|
|
}
|
|
|
|
#if 0
|
|
/*
|
|
Sets the slot \a member in object \a target to be called when the
|
|
reply arrives. The slot's parameter list must match the reply
|
|
message's arguments for it to be called.
|
|
|
|
It may, optionally, contain a QDBusMessage final parameter. If it
|
|
is present, the parameter will contain the reply message object.
|
|
|
|
The callback will not be called if the reply is an error message.
|
|
|
|
This function returns \c true if it could set the callback, false
|
|
otherwise. It is not a guarantee that the callback will be
|
|
called.
|
|
|
|
\warning QDBusPendingCall only supports one callback per pending
|
|
asynchronous call, even if multiple QDBusPendingCall
|
|
objects are referencing the same pending call.
|
|
*/
|
|
bool QDBusPendingCall::setReplyCallback(QObject *target, const char *member)
|
|
{
|
|
if (!d)
|
|
return false;
|
|
|
|
return d->setReplyCallback(target, member);
|
|
}
|
|
#endif
|
|
|
|
/*!
|
|
\since 4.6
|
|
Creates a QDBusPendingCall object based on the error condition
|
|
\a error. The resulting pending call object will be in the
|
|
"finished" state and QDBusPendingReply<Types...>::isError() will return true.
|
|
|
|
\sa fromCompletedCall()
|
|
*/
|
|
QDBusPendingCall QDBusPendingCall::fromError(const QDBusError &error)
|
|
{
|
|
return fromCompletedCall(QDBusMessage::createError(error));
|
|
}
|
|
|
|
/*!
|
|
\since 4.6
|
|
Creates a QDBusPendingCall object based on the message \a msg.
|
|
The message must be of type QDBusMessage::ErrorMessage or
|
|
QDBusMessage::ReplyMessage (that is, a message that is typical
|
|
of a completed call).
|
|
|
|
This function is useful for code that requires simulating a pending
|
|
call, but that has already finished.
|
|
|
|
\sa fromError()
|
|
*/
|
|
QDBusPendingCall QDBusPendingCall::fromCompletedCall(const QDBusMessage &msg)
|
|
{
|
|
QDBusPendingCallPrivate *d = nullptr;
|
|
if (msg.type() == QDBusMessage::ErrorMessage ||
|
|
msg.type() == QDBusMessage::ReplyMessage) {
|
|
d = new QDBusPendingCallPrivate(QDBusMessage(), nullptr);
|
|
d->replyMessage = msg;
|
|
d->ref.storeRelaxed(1);
|
|
}
|
|
|
|
return QDBusPendingCall(d);
|
|
}
|
|
|
|
/*!
|
|
Creates a QDBusPendingCallWatcher object to watch for replies on the
|
|
asynchronous pending call \a call and sets this object's parent
|
|
to \a parent.
|
|
*/
|
|
QDBusPendingCallWatcher::QDBusPendingCallWatcher(const QDBusPendingCall &call, QObject *parent)
|
|
: QObject(parent), QDBusPendingCall(call)
|
|
{
|
|
if (d) { // QDBusPendingCall::d
|
|
const auto locker = qt_scoped_lock(d->mutex);
|
|
if (!d->watcherHelper) {
|
|
d->watcherHelper = new QDBusPendingCallWatcherHelper;
|
|
if (d->replyMessage.type() != QDBusMessage::InvalidMessage) {
|
|
// cause a signal emission anyways
|
|
QMetaObject::invokeMethod(d->watcherHelper,
|
|
&QDBusPendingCallWatcherHelper::finished,
|
|
Qt::QueuedConnection);
|
|
}
|
|
}
|
|
d->watcherHelper->add(this);
|
|
}
|
|
}
|
|
|
|
/*!
|
|
Destroys this object. If this QDBusPendingCallWatcher object was the
|
|
last reference to the unfinished pending call, the call will be
|
|
canceled.
|
|
*/
|
|
QDBusPendingCallWatcher::~QDBusPendingCallWatcher()
|
|
{
|
|
}
|
|
|
|
/*!
|
|
\fn void QDBusPendingCallWatcher::waitForFinished()
|
|
|
|
Suspends the execution of the calling thread until the reply is
|
|
received and processed. After this function returns, isFinished()
|
|
should return true, indicating the reply's contents are ready to
|
|
be processed.
|
|
|
|
\sa QDBusPendingReply::waitForFinished()
|
|
*/
|
|
void QDBusPendingCallWatcher::waitForFinished()
|
|
{
|
|
if (d) {
|
|
d->waitForFinished();
|
|
|
|
// our signals were queued, so deliver them
|
|
QCoreApplication::sendPostedEvents(d->watcherHelper, QEvent::MetaCall);
|
|
QCoreApplication::sendPostedEvents(this, QEvent::MetaCall);
|
|
}
|
|
}
|
|
QT_END_NAMESPACE
|
|
|
|
#include "moc_qdbuspendingcall_p.cpp"
|
|
|
|
#endif // QT_NO_DBUS
|
|
|
|
#include "moc_qdbuspendingcall.cpp"
|