bcaff2b06f
Duplicating the number of classes is a high price to pay to be able to have some QAction functionality behave differently, or be only available in widgets applications. Instead, declare the entire API in QtGui in QAction* classes, and delegate the implementation of QtWidgets specific functionality to the private. The creation of the private is then delegated to the Q(Gui)ApplicationPrivate instance through a virtual factory function. Change some public APIs that are primarily useful for specialized tools such as Designer to operate on QObject* rather than QWidget*. APIs that depend on QtWidgets types have been turned into inline template functions, so that they are instantiated only at the caller side, where we can expect the respective types to be fully defined. This way, we only need to forward declare a few classes in the header, and don't need to generate any additional code for e.g. language bindings. Change-Id: Id0b27f9187652ec531a2e8b1b9837e82dc81625c Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
276 lines
8.0 KiB
C++
276 lines
8.0 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2019 The Qt Company Ltd.
|
|
** Contact: https://www.qt.io/licensing/
|
|
**
|
|
** This file is part of the test suite of the Qt Toolkit.
|
|
**
|
|
** $QT_BEGIN_LICENSE:GPL-EXCEPT$
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and The Qt Company. For licensing terms
|
|
** and conditions see https://www.qt.io/terms-conditions. For further
|
|
** information use the contact form at https://www.qt.io/contact-us.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3 as published by the Free Software
|
|
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
|
|
** included in the packaging of this file. Please review the following
|
|
** information to ensure the GNU General Public License requirements will
|
|
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
|
|
**
|
|
** $QT_END_LICENSE$
|
|
**
|
|
****************************************************************************/
|
|
|
|
#include <QtTest/QtTest>
|
|
|
|
#include <qguiapplication.h>
|
|
#include <qevent.h>
|
|
#include <qaction.h>
|
|
#include <qactiongroup.h>
|
|
#include <qpa/qplatformtheme.h>
|
|
|
|
#include <private/qguiapplication_p.h>
|
|
|
|
class tst_QAction : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
tst_QAction();
|
|
|
|
private slots:
|
|
void cleanup();
|
|
void getSetCheck();
|
|
void setText_data();
|
|
void setText();
|
|
void setIconText_data() { setText_data(); }
|
|
void setIconText();
|
|
#if QT_CONFIG(shortcut)
|
|
void setStandardKeys();
|
|
void task200823_tooltip();
|
|
#endif
|
|
void task229128TriggeredSignalWithoutActiongroup();
|
|
void setData();
|
|
void setEnabledSetVisible();
|
|
void setCheckabledSetChecked();
|
|
|
|
private:
|
|
const int m_keyboardScheme;
|
|
};
|
|
|
|
tst_QAction::tst_QAction()
|
|
: m_keyboardScheme(QGuiApplicationPrivate::platformTheme()->themeHint(QPlatformTheme::KeyboardScheme).toInt())
|
|
{
|
|
}
|
|
|
|
void tst_QAction::cleanup()
|
|
{
|
|
QVERIFY(QGuiApplication::topLevelWindows().isEmpty());
|
|
}
|
|
|
|
// Testing get/set functions
|
|
void tst_QAction::getSetCheck()
|
|
{
|
|
QAction obj1(nullptr);
|
|
auto var1 = new QActionGroup(nullptr);
|
|
obj1.setActionGroup(var1);
|
|
QCOMPARE(var1, obj1.actionGroup());
|
|
obj1.setActionGroup(nullptr);
|
|
QCOMPARE(obj1.actionGroup(), nullptr);
|
|
delete var1;
|
|
|
|
QCOMPARE(obj1.priority(), QAction::NormalPriority);
|
|
obj1.setPriority(QAction::LowPriority);
|
|
QCOMPARE(obj1.priority(), QAction::LowPriority);
|
|
}
|
|
|
|
void tst_QAction::setText_data()
|
|
{
|
|
QTest::addColumn<QString>("text");
|
|
QTest::addColumn<QString>("iconText");
|
|
QTest::addColumn<QString>("textFromIconText");
|
|
|
|
//next we fill it with data
|
|
QTest::newRow("Normal") << "Action" << "Action" << "Action";
|
|
QTest::newRow("Ampersand") << "Search && Destroy" << "Search & Destroy" << "Search && Destroy";
|
|
QTest::newRow("Mnemonic and ellipsis") << "O&pen File ..." << "Open File" << "Open File";
|
|
}
|
|
|
|
void tst_QAction::setText()
|
|
{
|
|
QFETCH(QString, text);
|
|
|
|
QAction action(nullptr);
|
|
action.setText(text);
|
|
|
|
QCOMPARE(action.text(), text);
|
|
|
|
QFETCH(QString, iconText);
|
|
QCOMPARE(action.iconText(), iconText);
|
|
}
|
|
|
|
void tst_QAction::setIconText()
|
|
{
|
|
QFETCH(QString, iconText);
|
|
|
|
QAction action(nullptr);
|
|
action.setIconText(iconText);
|
|
QCOMPARE(action.iconText(), iconText);
|
|
|
|
QFETCH(QString, textFromIconText);
|
|
QCOMPARE(action.text(), textFromIconText);
|
|
}
|
|
|
|
#if QT_CONFIG(shortcut)
|
|
|
|
//basic testing of standard keys
|
|
void tst_QAction::setStandardKeys()
|
|
{
|
|
QAction act(nullptr);
|
|
act.setShortcut(QKeySequence("CTRL+L"));
|
|
QList<QKeySequence> list;
|
|
act.setShortcuts(list);
|
|
act.setShortcuts(QKeySequence::Copy);
|
|
QCOMPARE(act.shortcut(), act.shortcuts().constFirst());
|
|
|
|
QList<QKeySequence> expected;
|
|
const QKeySequence ctrlC = QKeySequence(QStringLiteral("CTRL+C"));
|
|
const QKeySequence ctrlInsert = QKeySequence(QStringLiteral("CTRL+INSERT"));
|
|
switch (m_keyboardScheme) {
|
|
case QPlatformTheme::MacKeyboardScheme:
|
|
expected << ctrlC;
|
|
break;
|
|
case QPlatformTheme::WindowsKeyboardScheme:
|
|
expected << ctrlC << ctrlInsert;
|
|
break;
|
|
default: // X11
|
|
expected << ctrlC << ctrlInsert << QKeySequence(QStringLiteral("F16"));
|
|
break;
|
|
}
|
|
|
|
QCOMPARE(act.shortcuts(), expected);
|
|
}
|
|
|
|
void tst_QAction::task200823_tooltip()
|
|
{
|
|
const QScopedPointer<QAction> action(new QAction("foo", nullptr));
|
|
QString shortcut("ctrl+o");
|
|
action->setShortcut(shortcut);
|
|
|
|
// we want a non-standard tooltip that shows the shortcut
|
|
action->setToolTip(action->text() + QLatin1String(" (") + action->shortcut().toString() + QLatin1Char(')'));
|
|
|
|
QString ref = QLatin1String("foo (") + QKeySequence(shortcut).toString() + QLatin1Char(')');
|
|
QCOMPARE(action->toolTip(), ref);
|
|
}
|
|
|
|
#endif // QT_CONFIG(shortcut)
|
|
|
|
void tst_QAction::task229128TriggeredSignalWithoutActiongroup()
|
|
{
|
|
// test without a group
|
|
const QScopedPointer<QAction> actionWithoutGroup(new QAction("Test", nullptr));
|
|
QSignalSpy spyWithoutGroup(actionWithoutGroup.data(), QOverload<bool>::of(&QAction::triggered));
|
|
QCOMPARE(spyWithoutGroup.count(), 0);
|
|
actionWithoutGroup->trigger();
|
|
// signal should be emitted
|
|
QCOMPARE(spyWithoutGroup.count(), 1);
|
|
|
|
// it is now a checkable checked action
|
|
actionWithoutGroup->setCheckable(true);
|
|
actionWithoutGroup->setChecked(true);
|
|
spyWithoutGroup.clear();
|
|
QCOMPARE(spyWithoutGroup.count(), 0);
|
|
actionWithoutGroup->trigger();
|
|
// signal should be emitted
|
|
QCOMPARE(spyWithoutGroup.count(), 1);
|
|
}
|
|
|
|
void tst_QAction::setData() // QTBUG-62006
|
|
{
|
|
QAction act(nullptr);
|
|
QSignalSpy spy(&act, &QAction::changed);
|
|
QCOMPARE(act.data(), QVariant());
|
|
QCOMPARE(spy.count(), 0);
|
|
act.setData(QVariant());
|
|
QCOMPARE(spy.count(), 0);
|
|
|
|
act.setData(-1);
|
|
QCOMPARE(spy.count(), 1);
|
|
act.setData(-1);
|
|
QCOMPARE(spy.count(), 1);
|
|
}
|
|
|
|
void tst_QAction::setEnabledSetVisible()
|
|
{
|
|
QAction action(nullptr);
|
|
QSignalSpy spy(&action, &QAction::enabledChanged);
|
|
QVERIFY(action.isEnabled());
|
|
QVERIFY(action.isVisible());
|
|
QCOMPARE(spy.count(), 0);
|
|
action.setVisible(false);
|
|
QVERIFY(!action.isEnabled());
|
|
QVERIFY(!action.isVisible());
|
|
QCOMPARE(spy.count(), 1);
|
|
action.setEnabled(false);
|
|
QVERIFY(!action.isEnabled());
|
|
QVERIFY(!action.isVisible());
|
|
QCOMPARE(spy.count(), 1);
|
|
action.setVisible(true);
|
|
QVERIFY(!action.isEnabled());
|
|
QVERIFY(action.isVisible());
|
|
QCOMPARE(spy.count(), 1);
|
|
action.resetEnabled();
|
|
QVERIFY(action.isEnabled());
|
|
QCOMPARE(spy.count(), 2);
|
|
}
|
|
|
|
void tst_QAction::setCheckabledSetChecked()
|
|
{
|
|
QAction action(nullptr);
|
|
QSignalSpy changedSpy(&action, &QAction::changed);
|
|
QSignalSpy checkedSpy(&action, &QAction::toggled);
|
|
QSignalSpy checkableSpy(&action, &QAction::checkableChanged);
|
|
QVERIFY(!action.isCheckable());
|
|
QVERIFY(!action.isChecked());
|
|
QCOMPARE(changedSpy.count(), 0);
|
|
QCOMPARE(checkedSpy.count(), 0);
|
|
QCOMPARE(checkableSpy.count(), 0);
|
|
|
|
action.setCheckable(true);
|
|
QVERIFY(action.isCheckable());
|
|
QVERIFY(!action.isChecked());
|
|
QCOMPARE(changedSpy.count(), 1);
|
|
QCOMPARE(checkedSpy.count(), 0);
|
|
QCOMPARE(checkableSpy.count(), 1);
|
|
|
|
action.setChecked(true);
|
|
QVERIFY(action.isCheckable());
|
|
QVERIFY(action.isChecked());
|
|
QCOMPARE(changedSpy.count(), 2);
|
|
QCOMPARE(checkedSpy.count(), 1);
|
|
QCOMPARE(checkableSpy.count(), 1);
|
|
|
|
action.setCheckable(false);
|
|
QVERIFY(!action.isCheckable());
|
|
QVERIFY(!action.isChecked());
|
|
QCOMPARE(changedSpy.count(), 3);
|
|
QCOMPARE(checkedSpy.count(), 2);
|
|
QCOMPARE(checkableSpy.count(), 2);
|
|
|
|
action.setCheckable(true);
|
|
QVERIFY(action.isCheckable());
|
|
QVERIFY(action.isChecked());
|
|
QCOMPARE(changedSpy.count(), 4);
|
|
QCOMPARE(checkedSpy.count(), 3);
|
|
QCOMPARE(checkableSpy.count(), 3);
|
|
}
|
|
|
|
QTEST_MAIN(tst_QAction)
|
|
#include "tst_qaction.moc"
|