qt5base-lts

History

Volker Hilsheimer c95de359b4 QComboBox: Don't dereference potential nullptr, simplify Amends `a874087504`, which tested whether d->container is nullptr to decide whether to hide the popup, and then dereferences d->container later without checking again. This raised a correct static analyzer warning. Simplify that logic. hidePopup() does nothing if there is no visible container, and we don't want to accept() the cancel key if there isn't. So the closeOnCancel logic isn't actually needed, we only need to accept the ShortcutOverride to make sure that QComboBox sees the Cancel key even if there is a shortcut registered, and then we can handle and accept the cancel key to call hidePopup() only if the popup is visible. Add test to verify that this interaction works as expected. Pick-to: 6.4 Task-number: QTBUG-108908 Change-Id: I60d92b068f0f5139d629cf4a58e225512170df77 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>		2022-12-08 15:14:17 +01:00
..
auto	QComboBox: Don't dereference potential nullptr, simplify	2022-12-08 15:14:17 +01:00
baseline	Port from container::count() and length() to size() - V5	2022-11-03 14:59:24 +01:00
benchmarks	Add In-place utf-8 case-insensitive comparisons	2022-12-02 11:35:49 +01:00
global
libfuzzer	Change the license of all CMakeLists.txt and *.cmake files to BSD	2022-08-23 23:58:42 +02:00
manual	Fix the qwasmcompositor_main test	2022-12-07 14:03:03 +01:00
shared	Tests: fix namespaced build on Windows	2022-10-25 18:33:14 -07:00
testserver	Use SPDX license identifiers	2022-05-16 16:37:38 +02:00
CMakeLists.txt	Change the license of all CMakeLists.txt and *.cmake files to BSD	2022-08-23 23:58:42 +02:00
README

README

This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.

Linux X11:

   * The user must be logged in to an active desktop; you can't run the
     autotests without a valid DISPLAY that allows X11 connections.

   * The tests are run against a KDE3 or KDE4 desktop.

   * Window manager uses "click to focus", and not "focus follows mouse". Many
     tests move the mouse cursor around and expect this to not affect focus
     and activation.

   * Disable "click to activate", i.e., when a window is opened, the window
     manager should automatically activate it (give it input focus) and not
     wait for the user to click the window.