1c6bf3e09e
This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8, but extended to handle typedefs and accesses through pointers, too: const std::string o = "object"; auto hasTypeIgnoringPointer = [](auto type) { return anyOf(hasType(type), hasType(pointsTo(type))); }; auto derivedFromAnyOfClasses = [&](ArrayRef<StringRef> classes) { auto exprOfDeclaredType = [&](auto decl) { return expr(hasTypeIgnoringPointer(hasUnqualifiedDesugaredType(recordType(hasDeclaration(decl))))).bind(o); }; return exprOfDeclaredType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes)))); }; auto renameMethod = [&] (ArrayRef<StringRef> classes, StringRef from, StringRef to) { return makeRule(cxxMemberCallExpr(on(derivedFromAnyOfClasses(classes)), callee(cxxMethodDecl(hasName(from), parameterCountIs(0)))), changeTo(cat(access(o, cat(to)), "()")), cat("use '", to, "' instead of '", from, "'")); }; renameMethod(<classes>, "count", "size"); renameMethod(<classes>, "length", "size"); except that the on() matcher has been replaced by one that doesn't ignoreParens(). a.k.a qt-port-to-std-compatible-api V5 with config Scope: 'Container'. Added two NOLINTNEXTLINEs in tst_qbitarray and tst_qcontiguouscache, to avoid porting calls that explicitly test count(). Change-Id: Icfb8808c2ff4a30187e9935a51cad26987451c22 Reviewed-by: Ivan Solovev <ivan.solovev@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
232 lines
6.0 KiB
C++
232 lines
6.0 KiB
C++
// Copyright (C) 2016 The Qt Company Ltd.
|
|
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
|
|
|
|
|
|
#include <QTest>
|
|
#include <QSignalSpy>
|
|
|
|
#include <qgraphicsitem.h>
|
|
#include <qgraphicsscene.h>
|
|
#include <qgraphicssceneevent.h>
|
|
#include <qgraphicsview.h>
|
|
#include <qstyleoption.h>
|
|
#include <private/qobject_p.h>
|
|
|
|
class tst_QGraphicsObject : public QObject {
|
|
Q_OBJECT
|
|
|
|
private slots:
|
|
void pos();
|
|
void x();
|
|
void y();
|
|
void z();
|
|
void opacity();
|
|
void enabled();
|
|
void visible();
|
|
void deleted();
|
|
};
|
|
|
|
class MyGraphicsObject : public QGraphicsObject
|
|
{
|
|
public:
|
|
MyGraphicsObject() : QGraphicsObject() {}
|
|
virtual QRectF boundingRect() const override { return QRectF(); }
|
|
virtual void paint(QPainter *, const QStyleOptionGraphicsItem *, QWidget *) override {}
|
|
};
|
|
|
|
void tst_QGraphicsObject::pos()
|
|
{
|
|
MyGraphicsObject object;
|
|
QSignalSpy xSpy(&object, SIGNAL(xChanged()));
|
|
QSignalSpy ySpy(&object, SIGNAL(yChanged()));
|
|
QVERIFY(object.pos() == QPointF(0, 0));
|
|
object.setPos(10, 10);
|
|
QCOMPARE(xSpy.size(), 1);
|
|
QCOMPARE(ySpy.size(), 1);
|
|
|
|
QCOMPARE(object.pos(), QPointF(10,10));
|
|
|
|
object.setPos(10, 10);
|
|
QCOMPARE(xSpy.size(), 1);
|
|
QCOMPARE(ySpy.size(), 1);
|
|
|
|
object.setProperty("pos", QPointF(0, 0));
|
|
QCOMPARE(xSpy.size(), 2);
|
|
QCOMPARE(ySpy.size(), 2);
|
|
QCOMPARE(object.property("pos").toPointF(), QPointF(0,0));
|
|
|
|
object.setProperty("pos", QPointF(10, 0));
|
|
QCOMPARE(xSpy.size(), 3);
|
|
QCOMPARE(ySpy.size(), 2);
|
|
QCOMPARE(object.property("pos").toPointF(), QPointF(10,0));
|
|
|
|
object.setProperty("pos", QPointF(10, 10));
|
|
QCOMPARE(xSpy.size(), 3);
|
|
QCOMPARE(ySpy.size(), 3);
|
|
QVERIFY(object.property("pos") == QPointF(10, 10));
|
|
}
|
|
|
|
void tst_QGraphicsObject::x()
|
|
{
|
|
MyGraphicsObject object;
|
|
QSignalSpy xSpy(&object, SIGNAL(xChanged()));
|
|
QSignalSpy ySpy(&object, SIGNAL(yChanged()));
|
|
QVERIFY(object.pos() == QPointF(0, 0));
|
|
object.setX(10);
|
|
QCOMPARE(xSpy.size(), 1);
|
|
QCOMPARE(ySpy.size(), 0);
|
|
|
|
QVERIFY(object.pos() == QPointF(10, 0));
|
|
QCOMPARE(object.x(), qreal(10));
|
|
|
|
object.setX(10);
|
|
QCOMPARE(xSpy.size(), 1);
|
|
QCOMPARE(ySpy.size(), 0);
|
|
|
|
object.setProperty("x", 0);
|
|
QCOMPARE(xSpy.size(), 2);
|
|
QCOMPARE(ySpy.size(), 0);
|
|
QCOMPARE(object.property("x").toDouble(), double(0));
|
|
}
|
|
|
|
void tst_QGraphicsObject::y()
|
|
{
|
|
MyGraphicsObject object;
|
|
QSignalSpy xSpy(&object, SIGNAL(xChanged()));
|
|
QSignalSpy ySpy(&object, SIGNAL(yChanged()));
|
|
QVERIFY(object.pos() == QPointF(0, 0));
|
|
object.setY(10);
|
|
QCOMPARE(xSpy.size(), 0);
|
|
QCOMPARE(ySpy.size(), 1);
|
|
|
|
QVERIFY(object.pos() == QPointF(0, 10));
|
|
QCOMPARE(object.y(), qreal(10));
|
|
|
|
object.setY(10);
|
|
QCOMPARE(xSpy.size(), 0);
|
|
QCOMPARE(ySpy.size(), 1);
|
|
|
|
object.setProperty("y", 0);
|
|
QCOMPARE(xSpy.size(), 0);
|
|
QCOMPARE(ySpy.size(), 2);
|
|
QCOMPARE(object.property("y").toDouble(), qreal(0));
|
|
}
|
|
|
|
void tst_QGraphicsObject::z()
|
|
{
|
|
MyGraphicsObject object;
|
|
QSignalSpy zSpy(&object, SIGNAL(zChanged()));
|
|
QCOMPARE(object.zValue(), qreal(0));
|
|
object.setZValue(10);
|
|
QCOMPARE(zSpy.size(), 1);
|
|
|
|
QCOMPARE(object.zValue(), qreal(10));
|
|
|
|
object.setZValue(10);
|
|
QCOMPARE(zSpy.size(), 1);
|
|
|
|
object.setProperty("z", 0);
|
|
QCOMPARE(zSpy.size(), 2);
|
|
QCOMPARE(object.property("z").toDouble(), double(0));
|
|
}
|
|
|
|
void tst_QGraphicsObject::opacity()
|
|
{
|
|
MyGraphicsObject object;
|
|
QSignalSpy spy(&object, SIGNAL(opacityChanged()));
|
|
QCOMPARE(object.opacity(), 1.);
|
|
object.setOpacity(0);
|
|
QCOMPARE(spy.size(), 1);
|
|
|
|
QCOMPARE(object.opacity(), 0.);
|
|
|
|
object.setOpacity(0);
|
|
QCOMPARE(spy.size(), 1);
|
|
|
|
object.setProperty("opacity", .5);
|
|
QCOMPARE(spy.size(), 2);
|
|
QCOMPARE(object.property("opacity").toDouble(), .5);
|
|
}
|
|
|
|
void tst_QGraphicsObject::enabled()
|
|
{
|
|
MyGraphicsObject object;
|
|
QSignalSpy spy(&object, SIGNAL(enabledChanged()));
|
|
QVERIFY(object.isEnabled());
|
|
object.setEnabled(false);
|
|
QCOMPARE(spy.size(), 1);
|
|
|
|
QVERIFY(!object.isEnabled());
|
|
|
|
object.setEnabled(false);
|
|
QCOMPARE(spy.size(), 1);
|
|
|
|
object.setProperty("enabled", true);
|
|
QCOMPARE(spy.size(), 2);
|
|
QVERIFY(object.property("enabled").toBool());
|
|
}
|
|
|
|
void tst_QGraphicsObject::visible()
|
|
{
|
|
MyGraphicsObject object;
|
|
QSignalSpy spy(&object, SIGNAL(visibleChanged()));
|
|
QVERIFY(object.isVisible());
|
|
object.setVisible(false);
|
|
QCOMPARE(spy.size(), 1);
|
|
|
|
QVERIFY(!object.isVisible());
|
|
|
|
object.setVisible(false);
|
|
QCOMPARE(spy.size(), 1);
|
|
|
|
object.setProperty("visible", true);
|
|
QCOMPARE(spy.size(), 2);
|
|
QVERIFY(object.property("visible").toBool());
|
|
}
|
|
|
|
class DeleteTester : public QGraphicsObject
|
|
{
|
|
public:
|
|
DeleteTester(bool *w, bool *pw, QGraphicsItem *parent = nullptr)
|
|
: QGraphicsObject(parent), wasDeleted(w), parentWasDeleted(pw)
|
|
{ }
|
|
|
|
~DeleteTester()
|
|
{
|
|
*wasDeleted = QObjectPrivate::get(this)->wasDeleted;
|
|
if (QGraphicsItem *p = parentItem()) {
|
|
if (QGraphicsObject *o = p->toGraphicsObject())
|
|
*parentWasDeleted = QObjectPrivate::get(o)->wasDeleted;
|
|
}
|
|
}
|
|
|
|
void paint(QPainter *, const QStyleOptionGraphicsItem *, QWidget * = nullptr) override
|
|
{ }
|
|
QRectF boundingRect() const override
|
|
{ return QRectF(); }
|
|
|
|
bool *wasDeleted;
|
|
bool *parentWasDeleted;
|
|
};
|
|
|
|
void tst_QGraphicsObject::deleted()
|
|
{
|
|
bool item1_parentWasDeleted = false;
|
|
bool item1_wasDeleted = false;
|
|
bool item2_parentWasDeleted = false;
|
|
bool item2_wasDeleted = false;
|
|
DeleteTester *item1 = new DeleteTester(&item1_wasDeleted, &item1_parentWasDeleted);
|
|
DeleteTester *item2 = new DeleteTester(&item2_wasDeleted, &item2_parentWasDeleted, item1);
|
|
Q_UNUSED(item2);
|
|
delete item1;
|
|
|
|
QVERIFY(!item1_wasDeleted); // destructor not called yet
|
|
QVERIFY(!item1_parentWasDeleted); // no parent
|
|
QVERIFY(!item2_wasDeleted); // destructor not called yet
|
|
QVERIFY(item2_parentWasDeleted);
|
|
}
|
|
|
|
QTEST_MAIN(tst_QGraphicsObject)
|
|
#include "tst_qgraphicsobject.moc"
|
|
|