qt5base-lts/tests/auto/widgets/kernel/qtooltip/tst_qtooltip.cpp
Johan Klokkhammer Helsing 02a2144427 QToolTip: Don't crash if a tool tip is shown outside screen geometry
In some cases, a tool tip may be shown outside screen geometry, i.e. if:

- QToolTip::showText is invoked manually with a position outside.
- In tst_QToolTip::setPalette if there is no screen at (0, 0). This might
  happen in a multi-monitor setups where one screen is taller than the other.
- On Wayland windows are (by design) not allowed to know their position on
  the screen. This means that global positions can't be trusted.

This started crashing when QDesktopWidget::screenGeometry(pos) was replaced
with QGuiApplication::screenAt(pos)->geometry() because screenAt will return
null if no screen is found, while screenGeometry defaulted to the primary
screen.

This reverts to the old behavior of falling back to the primary screen.

This won't solve the issue completely for the Wayland case, but at least we
will stop crashing.

Change-Id: I42dd07cc21c2f9f0ea0d69f0c25bd46d8a2615a0
Reviewed-by: Filipe Azevedo <filipe.azevedo@kdab.com>
Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
2018-10-15 07:44:04 +00:00

230 lines
7.2 KiB
C++

/****************************************************************************
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of the test suite of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:GPL-EXCEPT$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
** $QT_END_LICENSE$
**
****************************************************************************/
#include <QtTest/QtTest>
#include <qfont.h>
#include <qfontmetrics.h>
#include <qtooltip.h>
#include <qwhatsthis.h>
#include <qscreen.h>
class tst_QToolTip : public QObject
{
Q_OBJECT
private slots:
void init();
void cleanup();
void task183679_data();
void task183679();
void whatsThis();
void setPalette();
void qtbug64550_stylesheet();
void dontCrashOutsideScreenGeometry();
};
void tst_QToolTip::init()
{
QVERIFY(!QToolTip::isVisible());
}
void tst_QToolTip::cleanup()
{
QTRY_VERIFY(QApplication::topLevelWidgets().isEmpty());
qApp->setStyleSheet(QString());
}
class Widget_task183679 : public QWidget
{
Q_OBJECT
public:
Widget_task183679(QWidget *parent = 0) : QWidget(parent) {}
void showDelayedToolTip(int msecs)
{
QTimer::singleShot(msecs, this, SLOT(showToolTip()));
}
static inline QString toolTipText() { return QStringLiteral("tool tip text"); }
private slots:
void showToolTip()
{
QToolTip::showText(mapToGlobal(QPoint(0, 0)), Widget_task183679::toolTipText(), this);
}
};
Q_DECLARE_METATYPE(Qt::Key)
void tst_QToolTip::task183679_data()
{
QTest::addColumn<Qt::Key>("key");
QTest::addColumn<bool>("visible");
QTest::newRow("non-modifier") << Qt::Key_A << true;
QTest::newRow("Shift") << Qt::Key_Shift << true;
QTest::newRow("Control") << Qt::Key_Control << true;
QTest::newRow("Alt") << Qt::Key_Alt << true;
QTest::newRow("Meta") << Qt::Key_Meta << true;
}
void tst_QToolTip::task183679()
{
QFETCH(Qt::Key, key);
QFETCH(bool, visible);
#ifdef Q_OS_MAC
QSKIP("This test fails in the CI system, QTBUG-30040");
#endif
Widget_task183679 widget;
widget.move(QGuiApplication::primaryScreen()->availableGeometry().topLeft() + QPoint(50, 50));
// Ensure cursor is not over tooltip, which causes it to hide
#ifndef QT_NO_CURSOR
QCursor::setPos(widget.geometry().topRight() + QPoint(-50, 50));
#endif
widget.setWindowTitle(QLatin1String(QTest::currentTestFunction())
+ QLatin1Char(' ') + QLatin1String(QTest::currentDataTag()));
widget.show();
QApplication::setActiveWindow(&widget);
QVERIFY(QTest::qWaitForWindowActive(&widget));
widget.showDelayedToolTip(100);
QTRY_VERIFY(QToolTip::isVisible());
QTest::keyPress(&widget, key);
// Important: the following delay must be larger than the duration of the timer potentially
// initiated by the key press (currently 300 msecs), but smaller than the minimum
// auto-close timeout (currently 10000 msecs)
QTest::qWait(1500);
QCOMPARE(QToolTip::isVisible(), visible);
if (visible)
QToolTip::hideText();
}
static QWidget *findWhatsThat()
{
foreach (QWidget *widget, QApplication::topLevelWidgets()) {
if (widget->inherits("QWhatsThat"))
return widget;
}
return nullptr;
}
void tst_QToolTip::whatsThis()
{
qApp->setStyleSheet( "QWidget { font-size: 72px; }" );
QWhatsThis::showText(QPoint(0, 0), "This is text");
QWidget *whatsthis = nullptr;
QTRY_VERIFY( (whatsthis = findWhatsThat()) );
QVERIFY(whatsthis->isVisible());
const int whatsThisHeight = whatsthis->height();
qApp->setStyleSheet(QString());
QWhatsThis::hideText();
QVERIFY2(whatsThisHeight > 100, QByteArray::number(whatsThisHeight)); // Test QTBUG-2416
}
static QWidget *findToolTip()
{
const QWidgetList &topLevelWidgets = QApplication::topLevelWidgets();
for (QWidget *widget : topLevelWidgets) {
if (widget->windowType() == Qt::ToolTip && widget->objectName() == QLatin1String("qtooltip_label"))
return widget;
}
return nullptr;
}
void tst_QToolTip::setPalette()
{
//the previous test may still have a tooltip pending for deletion
QVERIFY(!QToolTip::isVisible());
QToolTip::showText(QPoint(), "tool tip text", 0);
QTRY_VERIFY(QToolTip::isVisible());
QWidget *toolTip = findToolTip();
QVERIFY(toolTip);
QTRY_VERIFY(toolTip->isVisible());
const QPalette oldPalette = toolTip->palette();
QPalette newPalette = oldPalette;
newPalette.setColor(QPalette::ToolTipBase, Qt::red);
newPalette.setColor(QPalette::ToolTipText, Qt::blue);
QToolTip::setPalette(newPalette);
QCOMPARE(toolTip->palette(), newPalette);
QToolTip::hideText();
}
static QByteArray msgSizeTooSmall(const QSize &actual, const QSize &expected)
{
return QByteArray::number(actual.width()) + 'x'
+ QByteArray::number(actual.height()) + " < "
+ QByteArray::number(expected.width()) + 'x'
+ QByteArray::number(expected.height());
}
// QTBUG-4550: When setting a style sheet specifying a font size on the tooltip's
// parent widget (as opposed to setting on QApplication), the tooltip should
// resize accordingly. This is an issue on Windows since the ToolTip widget is
// not directly parented on the widget itself.
// Set a large font size and verify that the tool tip is big enough.
void tst_QToolTip::qtbug64550_stylesheet()
{
Widget_task183679 widget;
widget.setStyleSheet(QStringLiteral("* { font-size: 48pt; }\n"));
widget.show();
QApplication::setActiveWindow(&widget);
QVERIFY(QTest::qWaitForWindowActive(&widget));
widget.showDelayedToolTip(100);
QTRY_VERIFY(QToolTip::isVisible());
QWidget *toolTip = findToolTip();
QVERIFY(toolTip);
QTRY_VERIFY(toolTip->isVisible());
const QRect boundingRect = QFontMetrics(widget.font()).boundingRect(Widget_task183679::toolTipText());
const QSize toolTipSize = toolTip->size();
QVERIFY2(toolTipSize.width() >= boundingRect.width()
&& toolTipSize.height() >= boundingRect.height(),
msgSizeTooSmall(toolTipSize, boundingRect.size()).constData());
}
void tst_QToolTip::dontCrashOutsideScreenGeometry() {
QToolTip::showText(QPoint(-10000, -10000), "tip outside monitor", nullptr);
QTRY_VERIFY(QToolTip::isVisible());
QToolTip::hideText();
}
QTEST_MAIN(tst_QToolTip)
#include "tst_qtooltip.moc"