qt5base-lts/tests/auto/gui/kernel/qclipboard/tst_qclipboard.cpp
Eskil Abrahamsen Blomfeldt 74a20b77a6 Fix memory leak in QClipboard::setMimeData()
The setMimeData() function is documented to take ownership of
the object passed in, but in the case where the platform
plugin did not support the requested mode, we would simply
return without deleting the object nor telling the application,
so it would cause a potential memory leak. We need to honor the
contract, even when we fail to set the mime data.

Test was updated to avoid verifying the leak in cases where
the platform does not support all modes.

[ChangeLog][QtGui][Clipboard] Fixed a memory leak in setMimeData()
when the platform plugin did not support the requested mode.

Task-number: QTBUG-41852
Change-Id: I2112da1613199fe1b56724e7ccf097b9e912c117
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@digia.com>
2014-10-10 13:37:59 +02:00

451 lines
16 KiB
C++

/****************************************************************************
**
** Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies).
** Contact: http://www.qt-project.org/legal
**
** This file is part of the test suite of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:LGPL21$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia. For licensing terms and
** conditions see http://qt.digia.com/licensing. For further information
** use the contact form at http://qt.digia.com/contact-us.
**
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 or version 3 as published by the Free
** Software Foundation and appearing in the file LICENSE.LGPLv21 and
** LICENSE.LGPLv3 included in the packaging of this file. Please review the
** following information to ensure the GNU Lesser General Public License
** requirements will be met: https://www.gnu.org/licenses/lgpl.html and
** http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** In addition, as a special exception, Digia gives you certain additional
** rights. These rights are described in the Digia Qt LGPL Exception
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
** $QT_END_LICENSE$
**
****************************************************************************/
#include <QtTest/QtTest>
#include <QtCore/QDebug>
#include <QtCore/QFileInfo>
#include <QtCore/QDir>
#include <QtGui/QGuiApplication>
#include <QtGui/QClipboard>
#include <QtGui/QImage>
#include <QtGui/QColor>
#include "../../../shared/platformclipboard.h"
class tst_QClipboard : public QObject
{
Q_OBJECT
private slots:
#ifdef QT_NO_CLIPBOARD
void initTestCase();
void cleanupTestCase();
#else
void init();
#if defined(Q_OS_WIN) || defined(Q_OS_MAC) || defined(Q_OS_QNX)
void copy_exit_paste();
void copyImage();
#endif
void capabilityFunctions();
void modes();
void testSignals();
void setMimeData();
void clearBeforeSetText();
#endif
};
#ifdef QT_NO_CLIPBOARD
void tst_QClipboard::initTestCase()
{
QSKIP("This test requires clipboard support");
}
void tst_QClipboard::cleanupTestCase()
{
QSKIP("This test requires clipboard support");
}
#else
void tst_QClipboard::init()
{
const QString testdataDir = QFileInfo(QFINDTESTDATA("copier")).absolutePath();
QVERIFY2(QDir::setCurrent(testdataDir), qPrintable("Could not chdir to " + testdataDir));
}
Q_DECLARE_METATYPE(QClipboard::Mode)
/*
Tests that the capability functions are implemented on all
platforms.
*/
void tst_QClipboard::capabilityFunctions()
{
QClipboard * const clipboard = QGuiApplication::clipboard();
clipboard->supportsSelection();
clipboard->supportsFindBuffer();
clipboard->ownsSelection();
clipboard->ownsClipboard();
clipboard->ownsFindBuffer();
}
/*
Test that text inserted into the clipboard in different modes is
kept separate.
*/
void tst_QClipboard::modes()
{
QClipboard * const clipboard = QGuiApplication::clipboard();
if (!PlatformClipboard::isAvailable())
QSKIP("Native clipboard not working in this setup");
const QString defaultMode = "default mode text;";
clipboard->setText(defaultMode);
QCOMPARE(clipboard->text(), defaultMode);
if (clipboard->supportsSelection()) {
const QString selectionMode = "selection mode text";
clipboard->setText(selectionMode, QClipboard::Selection);
QCOMPARE(clipboard->text(QClipboard::Selection), selectionMode);
QCOMPARE(clipboard->text(), defaultMode);
}
if (clipboard->supportsFindBuffer()) {
const QString searchMode = "find mode text";
clipboard->setText(searchMode, QClipboard::FindBuffer);
QCOMPARE(clipboard->text(QClipboard::FindBuffer), searchMode);
QCOMPARE(clipboard->text(), defaultMode);
}
}
// A predicate to be used with a QSignalSpy / QTRY_VERIFY to ensure all delayed
// notifications are eaten. It waits at least one cycle and returns true when
// no new signals arrive.
class EatSignalSpyNotificationsPredicate
{
public:
explicit EatSignalSpyNotificationsPredicate(QSignalSpy &spy) : m_spy(spy) { reset(); }
operator bool() const
{
if (m_timer.elapsed() && !m_spy.count())
return true;
m_spy.clear();
return false;
}
inline void reset() { m_timer.start(); }
private:
QSignalSpy &m_spy;
QElapsedTimer m_timer;
};
/*
Test that the appropriate signals are emitted when the clipboard
contents is changed by calling the qt functions.
*/
void tst_QClipboard::testSignals()
{
qRegisterMetaType<QClipboard::Mode>("QClipboard::Mode");
if (!PlatformClipboard::isAvailable())
QSKIP("Native clipboard not working in this setup");
QClipboard * const clipboard = QGuiApplication::clipboard();
QSignalSpy changedSpy(clipboard, SIGNAL(changed(QClipboard::Mode)));
QSignalSpy dataChangedSpy(clipboard, SIGNAL(dataChanged()));
// Clipboard notifications are asynchronous with the new AddClipboardFormatListener
// in Windows Vista (5.4). Eat away all signals to ensure they don't interfere
// with the QTRY_COMPARE below.
EatSignalSpyNotificationsPredicate noLeftOverDataChanges(dataChangedSpy);
EatSignalSpyNotificationsPredicate noLeftOverChanges(changedSpy);
QTRY_VERIFY(noLeftOverChanges && noLeftOverDataChanges);
QSignalSpy searchChangedSpy(clipboard, SIGNAL(findBufferChanged()));
QSignalSpy selectionChangedSpy(clipboard, SIGNAL(selectionChanged()));
const QString text = "clipboard text;";
// Test the default mode signal.
clipboard->setText(text);
QTRY_COMPARE(dataChangedSpy.count(), 1);
QCOMPARE(searchChangedSpy.count(), 0);
QCOMPARE(selectionChangedSpy.count(), 0);
QCOMPARE(changedSpy.count(), 1);
QCOMPARE(changedSpy.at(0).count(), 1);
QCOMPARE(qvariant_cast<QClipboard::Mode>(changedSpy.at(0).at(0)), QClipboard::Clipboard);
changedSpy.clear();
// Test the selection mode signal.
if (clipboard->supportsSelection()) {
clipboard->setText(text, QClipboard::Selection);
QCOMPARE(selectionChangedSpy.count(), 1);
QCOMPARE(changedSpy.count(), 1);
QCOMPARE(changedSpy.at(0).count(), 1);
QCOMPARE(qvariant_cast<QClipboard::Mode>(changedSpy.at(0).at(0)), QClipboard::Selection);
} else {
QCOMPARE(selectionChangedSpy.count(), 0);
}
QCOMPARE(dataChangedSpy.count(), 1);
QCOMPARE(searchChangedSpy.count(), 0);
changedSpy.clear();
// Test the search mode signal.
if (clipboard->supportsFindBuffer()) {
clipboard->setText(text, QClipboard::FindBuffer);
QCOMPARE(searchChangedSpy.count(), 1);
QCOMPARE(changedSpy.count(), 1);
QCOMPARE(changedSpy.at(0).count(), 1);
QCOMPARE(qvariant_cast<QClipboard::Mode>(changedSpy.at(0).at(0)), QClipboard::FindBuffer);
} else {
QCOMPARE(searchChangedSpy.count(), 0);
}
QCOMPARE(dataChangedSpy.count(), 1);
}
#if defined(Q_OS_WIN) || defined(Q_OS_MAC) || defined(Q_OS_QNX)
static bool runHelper(const QString &program, const QStringList &arguments, QByteArray *errorMessage)
{
#ifndef QT_NO_PROCESS
QProcess process;
process.setReadChannelMode(QProcess::ForwardedChannels);
process.start(program, arguments);
if (!process.waitForStarted()) {
*errorMessage = "Unable to start '" + program.toLocal8Bit() + " ': "
+ process.errorString().toLocal8Bit();
return false;
}
// Windows: Due to implementation changes, the event loop needs
// to be spun since we ourselves also need to answer the
// WM_DRAWCLIPBOARD message as we are in the chain of clipboard
// viewers. Check for running before waitForFinished() in case
// the process terminated while processEvents() was executed.
bool running = true;
for (int i = 0; i < 60 && running; ++i) {
QGuiApplication::processEvents(QEventLoop::ExcludeUserInputEvents);
if (process.state() != QProcess::Running || process.waitForFinished(500))
running = false;
}
if (running) {
process.kill();
*errorMessage = "Timeout running '" + program.toLocal8Bit() + '\'';
return false;
}
if (process.exitStatus() != QProcess::NormalExit) {
*errorMessage = "Process '" + program.toLocal8Bit() + "' crashed.";
return false;
}
if (process.exitCode()) {
*errorMessage = "Process '" + program.toLocal8Bit() + "' returns "
+ QByteArray::number(process.exitCode());
return false;
}
return true;
#else // QT_NO_PROCESS
Q_UNUSED(program)
Q_UNUSED(arguments)
Q_UNUSED(errorMessage)
return false;
#endif // QT_NO_PROCESS
}
// Test that pasted text remains on the clipboard after a Qt application exits.
// This test does not make sense on X11 and embedded, copied data disappears from the clipboard when the application exits
void tst_QClipboard::copy_exit_paste()
{
#ifndef QT_NO_PROCESS
// ### It's still possible to test copy/paste - just keep the apps running
if (!PlatformClipboard::isAvailable())
QSKIP("Native clipboard not working in this setup");
const QString stringArgument(QStringLiteral("Test string."));
QByteArray errorMessage;
QVERIFY2(runHelper(QStringLiteral("copier/copier"), QStringList(stringArgument), &errorMessage),
errorMessage.constData());
#ifdef Q_OS_MAC
// The Pasteboard needs a moment to breathe (at least on older Macs).
QTest::qWait(100);
#endif // Q_OS_MAC
QVERIFY2(runHelper(QStringLiteral("paster/paster"),
QStringList() << QStringLiteral("--text") << stringArgument,
&errorMessage),
errorMessage.constData());
#endif // QT_NO_PROCESS
}
void tst_QClipboard::copyImage()
{
#ifndef QT_NO_PROCESS
if (!PlatformClipboard::isAvailable())
QSKIP("Native clipboard not working in this setup");
QImage image(100, 100, QImage::Format_ARGB32);
image.fill(QColor(Qt::transparent));
image.setPixel(QPoint(1, 0), QColor(Qt::blue).rgba());
QGuiApplication::clipboard()->setImage(image);
#ifdef Q_OS_OSX
// The Pasteboard needs a moment to breathe (at least on older Macs).
QTest::qWait(100);
#endif // Q_OS_OSX
// paster will perform hard-coded checks on the copied image.
QByteArray errorMessage;
QVERIFY2(runHelper(QStringLiteral("paster/paster"),
QStringList(QStringLiteral("--image")), &errorMessage),
errorMessage.constData());
#endif // QT_NO_PROCESS
}
#endif // Q_OS_WIN || Q_OS_MAC || Q_OS_QNX
void tst_QClipboard::setMimeData()
{
if (!PlatformClipboard::isAvailable())
QSKIP("Native clipboard not working in this setup");
QMimeData *mimeData = new QMimeData;
const QString TestName(QLatin1String("tst_QClipboard::setMimeData() mimeData"));
mimeData->setObjectName(TestName);
#if defined(Q_OS_WINCE)
// need to set text on CE
mimeData->setText(QLatin1String("Qt/CE foo"));
#endif
QGuiApplication::clipboard()->setMimeData(mimeData);
QCOMPARE(QGuiApplication::clipboard()->mimeData(), (const QMimeData *)mimeData);
QCOMPARE(QGuiApplication::clipboard()->mimeData()->objectName(), TestName);
// set it to the same data again, it shouldn't delete mimeData (and crash as a result)
QGuiApplication::clipboard()->setMimeData(mimeData);
QCOMPARE(QGuiApplication::clipboard()->mimeData(), (const QMimeData *)mimeData);
QCOMPARE(QGuiApplication::clipboard()->mimeData()->objectName(), TestName);
QGuiApplication::clipboard()->clear();
const QMimeData *appMimeData = QGuiApplication::clipboard()->mimeData();
QVERIFY(appMimeData != mimeData || appMimeData->objectName() != TestName);
// check for crash when using the same mimedata object on several clipboards
QMimeData *data = new QMimeData;
data->setText("foo");
QGuiApplication::clipboard()->setMimeData(data, QClipboard::Clipboard);
if (QGuiApplication::clipboard()->supportsSelection())
QGuiApplication::clipboard()->setMimeData(data, QClipboard::Selection);
if (QGuiApplication::clipboard()->supportsFindBuffer())
QGuiApplication::clipboard()->setMimeData(data, QClipboard::FindBuffer);
QSignalSpy spySelection(QGuiApplication::clipboard(), SIGNAL(selectionChanged()));
QSignalSpy spyData(QGuiApplication::clipboard(), SIGNAL(dataChanged()));
// Clipboard notifications are asynchronous with the new AddClipboardFormatListener
// in Windows Vista (5.4). Eat away all signals to ensure they don't interfere
// with the QTRY_COMPARE below.
EatSignalSpyNotificationsPredicate noLeftOverDataChanges(spyData);
QTRY_VERIFY(noLeftOverDataChanges);
QSignalSpy spyFindBuffer(QGuiApplication::clipboard(), SIGNAL(findBufferChanged()));
QGuiApplication::clipboard()->clear(QClipboard::Clipboard);
QGuiApplication::clipboard()->clear(QClipboard::Selection); // used to crash on X11
QGuiApplication::clipboard()->clear(QClipboard::FindBuffer);
if (QGuiApplication::clipboard()->supportsSelection())
QCOMPARE(spySelection.count(), 1);
else
QCOMPARE(spySelection.count(), 0);
if (QGuiApplication::clipboard()->supportsFindBuffer())
QCOMPARE(spyFindBuffer.count(), 1);
else
QCOMPARE(spyFindBuffer.count(), 0);
QTRY_COMPARE(spyData.count(), 1);
// an other crash test
data = new QMimeData;
data->setText("foo");
QGuiApplication::clipboard()->setMimeData(data, QClipboard::Clipboard);
if (QGuiApplication::clipboard()->supportsSelection())
QGuiApplication::clipboard()->setMimeData(data, QClipboard::Selection);
if (QGuiApplication::clipboard()->supportsFindBuffer())
QGuiApplication::clipboard()->setMimeData(data, QClipboard::FindBuffer);
QMimeData *newData = new QMimeData;
newData->setText("bar");
spySelection.clear();
noLeftOverDataChanges.reset();
QTRY_VERIFY(noLeftOverDataChanges);
spyFindBuffer.clear();
QGuiApplication::clipboard()->setMimeData(newData, QClipboard::Clipboard);
if (QGuiApplication::clipboard()->supportsSelection())
QGuiApplication::clipboard()->setMimeData(newData, QClipboard::Selection); // used to crash on X11
if (QGuiApplication::clipboard()->supportsFindBuffer())
QGuiApplication::clipboard()->setMimeData(newData, QClipboard::FindBuffer);
if (QGuiApplication::clipboard()->supportsSelection())
QCOMPARE(spySelection.count(), 1);
else
QCOMPARE(spySelection.count(), 0);
if (QGuiApplication::clipboard()->supportsFindBuffer())
QCOMPARE(spyFindBuffer.count(), 1);
else
QCOMPARE(spyFindBuffer.count(), 0);
QTRY_COMPARE(spyData.count(), 1);
}
void tst_QClipboard::clearBeforeSetText()
{
QGuiApplication::processEvents();
if (!PlatformClipboard::isAvailable())
QSKIP("Native clipboard not working in this setup");
const QString text = "tst_QClipboard::clearBeforeSetText()";
// setText() should work after processEvents()
QGuiApplication::clipboard()->setText(text);
QCOMPARE(QGuiApplication::clipboard()->text(), text);
QGuiApplication::processEvents();
QCOMPARE(QGuiApplication::clipboard()->text(), text);
// same with clear()
QGuiApplication::clipboard()->clear();
QVERIFY(QGuiApplication::clipboard()->text().isEmpty());
QGuiApplication::processEvents();
QVERIFY(QGuiApplication::clipboard()->text().isEmpty());
// setText() again
QGuiApplication::clipboard()->setText(text);
QCOMPARE(QGuiApplication::clipboard()->text(), text);
QGuiApplication::processEvents();
QCOMPARE(QGuiApplication::clipboard()->text(), text);
// clear() immediately followed by setText() should still return the text
QGuiApplication::clipboard()->clear();
QVERIFY(QGuiApplication::clipboard()->text().isEmpty());
QGuiApplication::clipboard()->setText(text);
QCOMPARE(QGuiApplication::clipboard()->text(), text);
QGuiApplication::processEvents();
QCOMPARE(QGuiApplication::clipboard()->text(), text);
}
#endif
QTEST_MAIN(tst_QClipboard)
#include "tst_qclipboard.moc"