qt5base-lts/qmake/library
Marc Mutz 1c6bf3e09e Port from container::count() and length() to size() - V5
This is a semantic patch using ClangTidyTransformator as in
qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8, but extended to
handle typedefs and accesses through pointers, too:

    const std::string o = "object";

    auto hasTypeIgnoringPointer = [](auto type) { return anyOf(hasType(type), hasType(pointsTo(type))); };

    auto derivedFromAnyOfClasses = [&](ArrayRef<StringRef> classes) {
        auto exprOfDeclaredType = [&](auto decl) {
            return expr(hasTypeIgnoringPointer(hasUnqualifiedDesugaredType(recordType(hasDeclaration(decl))))).bind(o);
        };
        return exprOfDeclaredType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))));
    };

    auto renameMethod = [&] (ArrayRef<StringRef> classes,
                            StringRef from, StringRef to) {
        return makeRule(cxxMemberCallExpr(on(derivedFromAnyOfClasses(classes)),
                            callee(cxxMethodDecl(hasName(from), parameterCountIs(0)))),
                        changeTo(cat(access(o, cat(to)), "()")),
                        cat("use '", to, "' instead of '", from, "'"));
    };

    renameMethod(<classes>, "count", "size");
    renameMethod(<classes>, "length", "size");

except that the on() matcher has been replaced by one that doesn't
ignoreParens().

a.k.a qt-port-to-std-compatible-api V5 with config Scope: 'Container'.

Added two NOLINTNEXTLINEs in tst_qbitarray and tst_qcontiguouscache,
to avoid porting calls that explicitly test count().

Change-Id: Icfb8808c2ff4a30187e9935a51cad26987451c22
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2022-11-03 14:59:24 +01:00
..
ioutils.cpp Port from container.count()/length() to size() 2022-10-04 07:40:08 +02:00
ioutils.h Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
proitems.cpp Port from container.count()/length() to size() 2022-10-04 07:40:08 +02:00
proitems.h Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
qmake_global.h Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
qmakebuiltins.cpp Port from container::count() and length() to size() - V5 2022-11-03 14:59:24 +01:00
qmakeevaluator_p.h Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
qmakeevaluator.cpp Port from container::count() and length() to size() - V5 2022-11-03 14:59:24 +01:00
qmakeevaluator.h Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
qmakeglobals.cpp Port from container::count() and length() to size() - V5 2022-11-03 14:59:24 +01:00
qmakeglobals.h Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
qmakeparser.cpp Port from container::count() and length() to size() - V5 2022-11-03 14:59:24 +01:00
qmakeparser.h Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
qmakevfs.cpp Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
qmakevfs.h Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
registry_p.h Use SPDX license identifiers 2022-05-16 16:37:38 +02:00
registry.cpp Use SPDX license identifiers 2022-05-16 16:37:38 +02:00