e667624371
Setting the parent of a QObject to nullptr means the ex-parent no longer owns and deletes the object as its child, leaking it. Fix by creating a scope-guard to defer deletion until the tests have run. This is simpler than the alternatives: Putting it into unique_ptr would require a new variable name, or a larger refactoring of the function, because the `test` variable is being re-used for many different objects in the course of the function, most of which should not be deleted. Using QAutoPointer would drag in QtWidgetsPrivate, and the class is probably not available in all active branches. Finally, deleteLater() would require reliably returning to the event loop, which may not happen if the test is run in isolation. Bug exists since the dawn of the public history, and QScopeGuard is available in all active branches. Pick-to: 6.6 6.5 6.2 5.15 Change-Id: Ib4fcb44b0b68d4ccbcf5af144a18ffb378a72213 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Ivan Solovev <ivan.solovev@qt.io> |
||
|---|---|---|
| .. | ||
| auto | ||
| baseline | ||
| benchmarks | ||
| global | ||
| libfuzzer | ||
| manual | ||
| shared | ||
| testserver | ||
| CMakeLists.txt | ||
| README | ||
This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.
Linux X11:
* The user must be logged in to an active desktop; you can't run the
autotests without a valid DISPLAY that allows X11 connections.
* The tests are run against a KDE3 or KDE4 desktop.
* Window manager uses "click to focus", and not "focus follows mouse". Many
tests move the mouse cursor around and expect this to not affect focus
and activation.
* Disable "click to activate", i.e., when a window is opened, the window
manager should automatically activate it (give it input focus) and not
wait for the user to click the window.