7523bbb0c0
In delegates we get into trouble with calling showPopup in setEditorData (edit by double click) - and that is not reasonable. The user has requested edit - and therefore it is natural to save a click for the user and show the popup at once. However that fails since we have the mouse down and as soon as we release the mouse we will call hidePopup. This patch ensures that the mouseReleaseEvent, that caused the problem is only considered if we have had a mousePressEvent. Change-Id: Ibe031fcb9ad2158f6969e41127bbb5f651b9cae6 Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
121 lines
4.3 KiB
C++
121 lines
4.3 KiB
C++
/****************************************************************************
|
|
**
|
|
** Copyright (C) 2012 Thorbjørn Lund Martsum - tmartsum[at]gmail.com
|
|
** Contact: http://www.qt-project.org/legal
|
|
**
|
|
** This file is part of the test suite of the Qt Toolkit.
|
|
**
|
|
** $QT_BEGIN_LICENSE:LGPL$
|
|
** Commercial License Usage
|
|
** Licensees holding valid commercial Qt licenses may use this file in
|
|
** accordance with the commercial license agreement provided with the
|
|
** Software or, alternatively, in accordance with the terms contained in
|
|
** a written agreement between you and Digia. For licensing terms and
|
|
** conditions see http://qt.digia.com/licensing. For further information
|
|
** use the contact form at http://qt.digia.com/contact-us.
|
|
**
|
|
** GNU Lesser General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU Lesser
|
|
** General Public License version 2.1 as published by the Free Software
|
|
** Foundation and appearing in the file LICENSE.LGPL included in the
|
|
** packaging of this file. Please review the following information to
|
|
** ensure the GNU Lesser General Public License version 2.1 requirements
|
|
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
|
|
**
|
|
** In addition, as a special exception, Digia gives you certain additional
|
|
** rights. These rights are described in the Digia Qt LGPL Exception
|
|
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
|
|
**
|
|
** GNU General Public License Usage
|
|
** Alternatively, this file may be used under the terms of the GNU
|
|
** General Public License version 3.0 as published by the Free Software
|
|
** Foundation and appearing in the file LICENSE.GPL included in the
|
|
** packaging of this file. Please review the following information to
|
|
** ensure the GNU General Public License version 3.0 requirements will be
|
|
** met: http://www.gnu.org/copyleft/gpl.html.
|
|
**
|
|
**
|
|
** $QT_END_LICENSE$
|
|
**
|
|
****************************************************************************/
|
|
|
|
#include <QLineEdit>
|
|
#include <QApplication>
|
|
#include <QTableView>
|
|
#include <QStandardItemModel>
|
|
#include <QItemDelegate>
|
|
#include <QDebug>
|
|
#include <QComboBox>
|
|
|
|
class ExampleEditor : public QLineEdit
|
|
{
|
|
public:
|
|
ExampleEditor(QWidget *parent = 0):QLineEdit(parent) { qDebug() << "ctor"; }
|
|
~ExampleEditor() { QApplication::instance()->quit(); }
|
|
};
|
|
|
|
class ExampleDelegate : public QItemDelegate
|
|
{
|
|
public:
|
|
ExampleDelegate() : QItemDelegate()
|
|
{
|
|
m_editor = new ExampleEditor(0);
|
|
m_combobox = new QComboBox(0);
|
|
m_combobox->addItem(QString::fromUtf8("item1"));
|
|
m_combobox->addItem(QString::fromUtf8("item2"));
|
|
}
|
|
protected:
|
|
QWidget* createEditor(QWidget *p, const QStyleOptionViewItem &o, const QModelIndex &i) const
|
|
{
|
|
// doubleclick rownumber 3 (last row) to see the difference.
|
|
if (i.row() == 3) {
|
|
m_combobox->setParent(p);
|
|
m_combobox->setGeometry(o.rect);
|
|
return m_combobox;
|
|
} else {
|
|
m_editor->setParent(p);
|
|
m_editor->setGeometry(o.rect);
|
|
return m_editor;
|
|
}
|
|
}
|
|
void destroyEditor(QWidget *editor, const QModelIndex &) const
|
|
{
|
|
editor->setParent(0);
|
|
qDebug() << "intercepted destroy :)";
|
|
}
|
|
|
|
// Avoid setting data - and therefore show that the editor keeps its state.
|
|
void setEditorData(QWidget* w, const QModelIndex &) const
|
|
{
|
|
QComboBox *combobox = qobject_cast<QComboBox*>(w);
|
|
if (combobox) {
|
|
qDebug() << "Try to show popup at once";
|
|
// Now we could try to make a call to
|
|
// QCoreApplication::processEvents();
|
|
// But it does not matter. The fix:
|
|
// https://codereview.qt-project.org/40608
|
|
// is blocking QComboBox from reacting to this doubleclick edit event
|
|
// and we need to do that since the mouseReleaseEvent has not yet happened,
|
|
// and therefore cannot be processed.
|
|
combobox->showPopup();
|
|
}
|
|
}
|
|
|
|
~ExampleDelegate() { delete m_editor; }
|
|
mutable ExampleEditor *m_editor;
|
|
mutable QComboBox *m_combobox;
|
|
};
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
QApplication app(argc, argv);
|
|
QTableView tv;
|
|
QStandardItemModel m;
|
|
m.setRowCount(4);
|
|
m.setColumnCount(2);
|
|
tv.setModel(&m);
|
|
tv.show();
|
|
tv.setItemDelegate(new ExampleDelegate());
|
|
app.exec();
|
|
}
|