qt5base-lts/src
Andreas Aardal Hanssen ed15e4eb07 Fix focusproxy-relayed crash in QGraphicsItem destructor.
Makes tst_qgraphicsitem::tst_focusProxyDeletion not crash.

valgrind reported the error when running tst_qgraphicsitem. The crash
was very real; when deleting an item that has another item as a focus
proxy, the proxy still had a reference to the deleted item's focusProxy
pointer. I'm not a huge fan of whitebox testing but thought this crash
justifies a modification of the test to make it fail, instead of just
passing silently with a warning only given by valgrind and friends.

FTR the reason the test doesn't crash hard is that the memory is freed
but not reused within the scope of the test. So the access to the
pointer d_ptr->focusProxy succeeds, it just accesses memory that might
as well have been reclaimed. But this is quite undefined...

Task-number: QTBUG-28321
Change-Id: I2624631f5e5c2a8aa8bd4efe1fc128eba6c61f56
Reviewed-by: Jan Arve Sæther <jan-arve.saether@digia.com>
2012-12-17 11:57:02 +01:00
..
3rdparty Change copyrights from Nokia to Digia 2012-12-05 06:33:43 +01:00
angle ANGLE: Always use DEF_FILE on Windows 2012-12-17 09:00:31 +01:00
concurrent Fixup concurrent docs 2012-11-30 00:48:37 +01:00
corelib QSettings docs: replace Q_WS_MAC with Q_OS_MAC 2012-12-14 23:39:14 +01:00
dbus D-Bus Examples: added qdoc files and path 2012-12-14 17:12:44 +01:00
gui Accessibility: Activate in QGuiApp instead of QApp. 2012-12-16 19:41:58 +01:00
network Fix some WS errors 2012-12-13 09:11:29 +01:00
opengl Fixed deadlock situation in QtOpenGL's texture management. 2012-12-14 08:56:02 +01:00
platformsupport Do not inform that a widget is not visible when it's disabled. 2012-12-16 19:41:33 +01:00
plugins Cocoa: make accessibility hit test not crash 2012-12-16 19:43:32 +01:00
printsupport Fixes to Qt D-Bus docs 2012-11-30 00:48:59 +01:00
sql Workaround with hardcoded url QT-BUG 28500 2012-12-11 10:51:15 +01:00
testlib Doc: recommend using QVERIFY with QSignalSpy::wait, so people don't forget. 2012-12-14 13:06:53 +01:00
tools Remove the timestamp info in genarated files 2012-12-15 11:32:38 +01:00
widgets Fix focusproxy-relayed crash in QGraphicsItem destructor. 2012-12-17 11:57:02 +01:00
winmain let winmain just use qtcore 2012-11-02 18:07:35 +01:00
xml Docs: fix code snippet paths in xml-processing.qdoc 2012-11-30 18:43:28 +01:00
src.pro Add ANGLE as a 3rdparty library to Qt. 2012-10-24 02:29:15 +02:00