ICU-10067 Implement feedback from API proposal.

X-SVN-Rev: 33955
This commit is contained in:
Travis Keep 2013-07-22 22:18:54 +00:00
parent b58875e894
commit 12b26e3073
2 changed files with 20 additions and 6 deletions

View File

@ -149,11 +149,16 @@ final public class ListFormatter {
/**
* Returns the pattern to use for a particular item count.
* @param count the item count.
* @return the pattern with {0}, {1}, {2}, etc.
* @internal
* @deprecated This API is ICU internal only.
* @return the pattern with {0}, {1}, {2}, etc. For English,
* getPatternForNumItems(3) == "{0}, {1}, and {2}"
* @throws IllegalArgumentException when count is 0 or negative.
* @draft ICU 52
* @provisional This API might change or be removed in a future release.
*/
public String createPatternForNumItems(int count) {
public String getPatternForNumItems(int count) {
if (count <= 0) {
throw new IllegalArgumentException("count must be > 0");
}
ArrayList<String> list = new ArrayList<String>();
for (int i = 0; i < count; i++) {
list.add(String.format("{%d}", i));

View File

@ -117,8 +117,17 @@ public class ListFormatterTest extends TestFmwk {
assertEquals(
"createPatternForNumItems",
"{0}, {1}, and {2}",
listFormatter.createPatternForNumItems(3));
listFormatter.getPatternForNumItems(3));
}
public void TestGetPatternForNumItemsException() {
ListFormatter listFormatter = ListFormatter.getInstance(ULocale.ENGLISH);
try {
listFormatter.getPatternForNumItems(0);
fail("IllegalArgumentException expected.");
} catch (IllegalArgumentException expected) {
// expected.
}
}
public void TestGetLocale() {