AuroraMiddleware/scuffed-code
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ICU-5990 Fixed a memory leak problem in ZoneStringFormat cache.

Browse Source 
X-SVN-Rev: 23024
This commit is contained in:
Yoshito Umaoka 2007-12-05 20:44:15 +00:00
parent 7ccc5b70ff
commit 155de1eafe
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
icu4c/source/i18n/zstrfmt.cpp
View File

@ -1582,10 +1582,11 @@ ZSFCache::get(const Locale &locale, UErrorCode &status) {
entry->fRefCount++;
// move the entry to the top
if (prev != NULL) {
if (entry != fFirst) {
prev->fNext = next;
entry->fNext = fFirst;
fFirst = entry;
}
fFirst = entry;
break;
}
prev = entry;
@ -1601,7 +1602,7 @@ ZSFCache::get(const Locale &locale, UErrorCode &status) {
}
// Now add the new entry
umtx_lock(&gZSFCacheLock);
// Make sure no other threads already creaded the one for the same locale
// Make sure no other threads already created the one for the same locale
entry = fFirst;
prev = NULL;
while (entry) {
@ -1611,10 +1612,11 @@ ZSFCache::get(const Locale &locale, UErrorCode &status) {
entry->fRefCount++;
// move the entry to the top
if (prev != NULL) {
if (entry != fFirst) {
prev->fNext = next;
entry->fNext = fFirst;
fFirst = entry;
}
fFirst = entry;
break;
}
prev = entry;
@ -1641,7 +1643,9 @@ ZSFCache::get(const Locale &locale, UErrorCode &status) {
while (entry) {
next = entry->fNext;
if (idx >= fCapacity && entry->fRefCount == 0) {
if (prev->fNext) {
if (entry == fFirst) {
fFirst = next;
} else {
prev->fNext = next;
}
delete entry;