AuroraMiddleware/scuffed-code
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ICU-21264 Re-enable optimizations for various functions on MSVC for VS2019 and above.

Browse Source
This commit is contained in:
Jeff Genovy 2020-09-04 11:58:40 -07:00
parent 941fddc19d
commit 2361a3258b
2 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
icu4c/source/common/uloc_tag.cpp
View File

@ -1988,11 +1988,12 @@ _appendPrivateuseToLanguageTag(const char* localeID, icu::ByteSink& sink, UBool
#define PRIV 0x0080
/**
* Ticket #12705 - Visual Studio 2015 Update 3 contains a new code optimizer which has problems optimizing
* this function. (See https://blogs.msdn.microsoft.com/vcblog/2016/05/04/new-code-optimizer/ )
* As a workaround, we will turn off optimization just for this function on VS2015 Update 3 and above.
* Ticket #12705 - The optimizer in Visual Studio 2015 Update 3 has problems optimizing this function.
* As a work-around, optimization is disabled for this function on VS2015 and VS2017.
* This work-around should be removed once the following versions of Visual Studio are no
* longer supported: All versions of VS2015/VS2017, and versions of VS2019 below 16.4.
*/
#if (defined(_MSC_VER) && (_MSC_VER >= 1900) && defined(_MSC_FULL_VER) && (_MSC_FULL_VER >= 190024210))
#if defined(_MSC_VER) && (_MSC_VER >= 1900) && (_MSC_VER < 1924)
#pragma optimize( "", off )
#endif
@ -2405,10 +2406,8 @@ ultag_parse(const char* tag, int32_t tagLen, int32_t* parsedLen, UErrorCode* sta
return t.orphan();
}
/**
* Ticket #12705 - Turn optimization back on.
*/
#if (defined(_MSC_VER) && (_MSC_VER >= 1900) && defined(_MSC_FULL_VER) && (_MSC_FULL_VER >= 190024210))
// Ticket #12705 - Turn optimization back on.
#if defined(_MSC_VER) && (_MSC_VER >= 1900) && (_MSC_VER < 1924)
#pragma optimize( "", on )
#endif

16
icu4c/source/test/cintltst/utf8tst.c
View File

@ -758,10 +758,12 @@ static void TestFwdBack() {
}
/**
* Ticket #13636 - Visual Studio 2017 has problems optimizing this function.
* As a workaround, we will turn off optimization just for this function on VS2017 and above.
*/
#if defined(_MSC_VER) && (_MSC_VER > 1900)
* Ticket #13636 - The optimizer in Visual Studio 2017 has problems optimizing this function.
* As a work-around, optimization is disabled for this function on VS2017.
* This work-around should be removed once the following versions of Visual Studio are no
* longer supported: All versions of VS2017, and versions of VS2019 below 16.4.
*/
#if defined(_MSC_VER) && (_MSC_VER > 1900) && (_MSC_VER < 1924)
#pragma optimize( "", off )
#endif
@ -850,10 +852,8 @@ static void TestFwdBackUnsafe() {
}
}
/**
* Ticket #13636 - Turn optimization back on.
*/
#if defined(_MSC_VER) && (_MSC_VER > 1900)
// Ticket #13636 - Turn optimization back on.
#if defined(_MSC_VER) && (_MSC_VER > 1900) && (_MSC_VER < 1924)
#pragma optimize( "", on )
#endif