AuroraMiddleware/scuffed-code
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ICU-3304 Code review changes.

Browse Source 
X-SVN-Rev: 18463
This commit is contained in:
Eric Mader 2005-08-25 22:20:16 +00:00
parent f9e6f15721
commit 7c0a4884e0
5 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
icu4c/source/layout/ArabicLayoutEngine.cpp
View File

@ -46,6 +46,12 @@ ArabicOpenTypeLayoutEngine::ArabicOpenTypeLayoutEngine(const LEFontInstance *fon
: OpenTypeLayoutEngine(fontInstance, scriptCode, languageCode, typoFlags)
{
fFeatureMap = ArabicShaping::getFeatureMap(fFeatureMapCount);
// NOTE: We don't need to set fFeatureOrder to TRUE here
// because this constructor is only called by the constructor
// for UnicodeArabicOpenTypeLayoutEngine, which uses a pre-built
// GSUB table that has the features in the correct order.
//fFeatureOrder = TRUE;
}

4
icu4c/source/layout/ContextualSubstSubtables.cpp
View File

@ -325,7 +325,9 @@ le_uint32 ChainingContextualSubstitutionSubtable::process(const LookupProcessor
}
// NOTE: This could be a #define, but that seems to confuse
// the Visual Studio .NET 2003 compiler...
// the Visual Studio .NET 2003 compiler on the calls to the
// GlyphIterator constructor. It somehow can't decide if
// emptyFeatureList matches an le_uint32 or an le_uint16...
static const FeatureMask emptyFeatureList = 0x00000000UL;
le_uint32 ChainingContextualSubstitutionFormat1Subtable::process(const LookupProcessor *lookupProcessor, GlyphIterator *glyphIterator,

7
icu4c/source/layout/KhmerReordering.cpp
View File

@ -163,19 +163,12 @@ public:
};
//TODO remove unused flags
#define nuktFeatureTag LE_NUKT_FEATURE_TAG
#define akhnFeatureTag LE_AKHN_FEATURE_TAG
#define rphfFeatureTag LE_RPHF_FEATURE_TAG
#define blwfFeatureTag LE_BLWF_FEATURE_TAG
#define halfFeatureTag LE_HALF_FEATURE_TAG
#define pstfFeatureTag LE_PSTF_FEATURE_TAG
#define vatuFeatureTag LE_VATU_FEATURE_TAG
#define presFeatureTag LE_PRES_FEATURE_TAG
#define blwsFeatureTag LE_BLWS_FEATURE_TAG
#define abvsFeatureTag LE_ABVS_FEATURE_TAG
#define pstsFeatureTag LE_PSTS_FEATURE_TAG
#define halnFeatureTag LE_HALN_FEATURE_TAG
#define blwmFeatureTag LE_BLWM_FEATURE_TAG
#define abvmFeatureTag LE_ABVM_FEATURE_TAG

5
icu4c/source/layout/LayoutEngine.cpp
View File

@ -16,6 +16,7 @@
#include "IndicLayoutEngine.h"
#include "KhmerLayoutEngine.h"
#include "ThaiLayoutEngine.h"
#include "TibetanLayoutEngine.h"
#include "GXLayoutEngine.h"
#include "ScriptAndLanguageTags.h"
#include "CharSubstitutionFilter.h"
@ -477,6 +478,10 @@ LayoutEngine *LayoutEngine::layoutEngineFactory(const LEFontInstance *fontInstan
break;
case tibtScriptCode:
result = new TibetanOpenTypeLayoutEngine(fontInstance, scriptCode, languageCode, typoFlags, gsubTable);
break;
case khmrScriptCode:
result = new KhmerOpenTypeLayoutEngine(fontInstance, scriptCode, languageCode, typoFlags, gsubTable);
break;

2
icu4c/source/layout/LookupProcessor.cpp
View File

@ -155,7 +155,7 @@ LookupProcessor::LookupProcessor(const char *baseAddress,
const FeatureTable *featureTable = NULL;
LETag featureTag;
const FeatureTable *requiredFeatureTable = 0;
const FeatureTable *requiredFeatureTable = NULL;
LETag requiredFeatureTag = 0x00000000U;
// Count the total number of lookups referenced by all features. This will