From 8c1c9bad8187ee647fc6171b0f91d26408fe0d84 Mon Sep 17 00:00:00 2001
From: Ram Viswanadha <rviswanadha@gmail.com>
Date: Sat, 24 May 2003 01:47:30 +0000
Subject: [PATCH] ICU-2836 update with review notes

X-SVN-Rev: 12101
---
 .../com/ibm/icu/dev/test/format/IntlTestDateFormatAPIC.java | 6 +++---
 .../com/ibm/icu/dev/test/lang/UCharacterIteratorTest.java   | 5 ++---
 .../com/ibm/icu/dev/test/normalizer/NormalizerBuilder.java  | 2 +-
 icu4j/src/com/ibm/icu/lang/UCharacter.java                  | 6 +++---
 4 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/icu4j/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPIC.java b/icu4j/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPIC.java
index 7b97874ed2..07a2927304 100755
--- a/icu4j/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPIC.java
+++ b/icu4j/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPIC.java
@@ -4,8 +4,8 @@
  * others. All Rights Reserved.                                                *
  *******************************************************************************
  * $Source: /xsrl/Nsvn/icu/icu4j/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPIC.java,v $ 
- * $Date: 2003/05/14 19:03:16 $ 
- * $Revision: 1.3 $
+ * $Date: 2003/05/24 01:47:30 $ 
+ * $Revision: 1.4 $
  *
  *****************************************************************************************
  */
@@ -108,7 +108,7 @@ public class IntlTestDateFormatAPIC extends com.ibm.icu.dev.test.TestFmwk {
             try {
                 obj = fmt.parse(str);
                 if(obj==null){
-                    errln("FAIL: The format object could parse the string : "+str);
+                    errln("FAIL: The format object could not parse the string : "+str);
                 }
             } catch (java.text.ParseException pe) {
                 System.out.println(pe);
diff --git a/icu4j/src/com/ibm/icu/dev/test/lang/UCharacterIteratorTest.java b/icu4j/src/com/ibm/icu/dev/test/lang/UCharacterIteratorTest.java
index 8e60eddca7..a88788d3f4 100644
--- a/icu4j/src/com/ibm/icu/dev/test/lang/UCharacterIteratorTest.java
+++ b/icu4j/src/com/ibm/icu/dev/test/lang/UCharacterIteratorTest.java
@@ -5,8 +5,8 @@
 *******************************************************************************
 *
 * $Source: /xsrl/Nsvn/icu/icu4j/src/com/ibm/icu/dev/test/lang/Attic/UCharacterIteratorTest.java,v $ 
-* $Date: 2003/05/24 01:39:09 $ 
-* $Revision: 1.3 $
+* $Date: 2003/05/24 01:47:30 $ 
+* $Revision: 1.4 $
 *
 *******************************************************************************
 */
@@ -15,7 +15,6 @@ package com.ibm.icu.dev.test.lang;
 
 
 import com.ibm.icu.dev.test.TestFmwk;
-import com.ibm.icu.text.UTF16;
 
 /**
 * Testing class for UCharacterIterator
diff --git a/icu4j/src/com/ibm/icu/dev/test/normalizer/NormalizerBuilder.java b/icu4j/src/com/ibm/icu/dev/test/normalizer/NormalizerBuilder.java
index d071a96ba0..40de273874 100644
--- a/icu4j/src/com/ibm/icu/dev/test/normalizer/NormalizerBuilder.java
+++ b/icu4j/src/com/ibm/icu/dev/test/normalizer/NormalizerBuilder.java
@@ -156,7 +156,7 @@ class NormalizerBuilder {
                 //System.out.println("debug: " + line);
             }
             end = line.indexOf(';',start=end+1); // name
-            /*String name =*/ line.substring(start,end);
+            /*String name = line.substring(start,end);*/
             end = line.indexOf(';',start=end+1); // general category
             end = line.indexOf(';',start=end+1); // canonical class
 
diff --git a/icu4j/src/com/ibm/icu/lang/UCharacter.java b/icu4j/src/com/ibm/icu/lang/UCharacter.java
index 686a81f434..b3409b5549 100755
--- a/icu4j/src/com/ibm/icu/lang/UCharacter.java
+++ b/icu4j/src/com/ibm/icu/lang/UCharacter.java
@@ -5,8 +5,8 @@
 *******************************************************************************
 *
 * $Source: /xsrl/Nsvn/icu/icu4j/src/com/ibm/icu/lang/UCharacter.java,v $ 
-* $Date: 2003/05/24 00:48:08 $ 
-* $Revision: 1.74 $
+* $Date: 2003/05/24 01:47:30 $ 
+* $Revision: 1.75 $
 *
 *******************************************************************************
 */
@@ -2472,7 +2472,7 @@ public final class UCharacter
      */
     public static boolean isUnicodeIdentifierStart(int ch)
     {
-        /*int cat = */getType(ch);
+        /*int cat = getType(ch);*/
         // if props == 0, it will just fall through and return false
         return ((1 << getType(ch)) 
                  & ((1 << UCharacterCategory.UPPERCASE_LETTER)