AuroraMiddleware/scuffed-code
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ICU-6956 Removed some comments and documentation to keep existing code from before.

Browse Source 
X-SVN-Rev: 26211
This commit is contained in:
John Vu 2009-06-30 21:01:58 +00:00
parent 07058ff285
commit ad76fc1b2e
4 changed files with 16 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
icu4j/main/classes/core/src/com/ibm/icu/lang/UCharacter.java
View File

@ -2058,6 +2058,8 @@ public final class UCharacter implements ECharacterCategory, ECharacterDirection
};
static {
// The following will only be true if COUNT or the array BLOCKS_
// is every changed to be inconsistent
if (COUNT!=BLOCKS_.length) {
throw new java.lang.IllegalStateException("UnicodeBlock fields are inconsistent!");
}
@ -3094,14 +3096,14 @@ public final class UCharacter implements ECharacterCategory, ECharacterDirection
mant=numericValue>>LARGE_MANT_SHIFT;
exp=numericValue&LARGE_EXP_MASK;
/* Values were tested for "int ch" from -20000000 to 20000000 and
/* Values were tested for "int ch" from -100000000 to 100000000 and
* none of the values ever reached the "if(mant==0)" or
* "else if(mant>9)"
*/
if(mant==0) {
mant=1;
exp+=LARGE_EXP_OFFSET_EXTRA;
} else if(mant>9) {
} else if(mant>9) {
return -2; /* reserved mantissa value */
} else {
exp+=LARGE_EXP_OFFSET;
@ -3128,10 +3130,10 @@ public final class UCharacter implements ECharacterCategory, ECharacterDirection
numValue*=10.;
break;
case 0:
/* Values were tested for "int ch" from -20000000 to 20000000 and
/* Values were tested for "int ch" from -100000000 to 100000000 and
* none of the values ever reached the "default" case
*/
default:
default: if(exp!=0)
break;
}
if(numValue<=Integer.MAX_VALUE) {

8
icu4j/main/classes/core/src/com/ibm/icu/lang/UCharacterNameIterator.java
View File

@ -70,17 +70,17 @@ class UCharacterNameIterator implements ValueIterator
return true;
}
}
/* JOHNVU:
// The following code was comment out for "return false"
/*
// "if (m_current_ >= m_limit_)" would not return true
// because it can never be reached due to:
// 1) It has already been checked earlier
// 2) When m_current_ is updated earlier, it returns true
// 3) No updates on m_limit_
// 3) No updates on m_limit_*/
if (m_current_ >= m_limit_) {
// after iterateGroup fails, current codepoint may be
// greater than limit
return false;
}*/
}
element.integer = m_current_;
element.value = m_name_.getAlgorithmName(m_algorithmIndex_,

13
icu4j/main/classes/core/src/com/ibm/icu/lang/UScript.java
View File

@ -13,6 +13,7 @@ import com.ibm.icu.util.ULocale;
import com.ibm.icu.util.UResourceBundle;
import java.util.Locale;
import java.util.MissingResourceException;
/**
* A class to reflect UTR #24: Script Names
@ -735,17 +736,15 @@ public final class UScript {
private static int[] findCodeFromLocale(ULocale locale) {
ICUResourceBundle rb;
/* JOHNVU:
// The following was comment out becuase the MissingResourceException
// seems to never be called because the "getBundleInstance" seems to
// correct this to ICUResourceBundle.FROM_DEFAULT if such invalid locale enters in.
try {
rb = (ICUResourceBundle)UResourceBundle.getBundleInstance(ICUResourceBundle.ICU_BASE_NAME, locale);
}
catch (MissingResourceException e) {
} catch (MissingResourceException e) {
/* This part seems to never be called since "UResourceBundle.getBundleInstance"
* corrects this by setting to ICUResourceBundle.FROM_DEFAULT
* when such an invalid locale is passed.
*/
return null;
}
*/
rb = (ICUResourceBundle)UResourceBundle.getBundleInstance(ICUResourceBundle.ICU_BASE_NAME, locale);

5
icu4j/main/tests/core/src/com/ibm/icu/dev/test/lang/TestUScript.java
View File

@ -407,9 +407,4 @@ public class TestUScript extends TestFmwk {
}
}
}
/* Tests the method "int[] findCodeFromLocale(ULocale locale)" */
public void TestFindFromLocale(){
// Tests when "if (w < result.length)" is true
}
}