AuroraMiddleware/scuffed-code
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ICU-8091 guard against pinIndices() reducing length to 0 or 1

Browse Source 
X-SVN-Rev: 28982
This commit is contained in:
Markus Scherer 2010-11-02 18:19:05 +00:00
parent 04000e60ff
commit b674f702e1
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
icu4c/source/common/unistr.cpp
View File

@ -1377,15 +1377,16 @@ UBool UnicodeString::hasMetaData() const {
}
UnicodeString&
UnicodeString::doReverse(int32_t start,
int32_t length)
{
if(this->length() <= 1 || !cloneArrayIfNeeded()) {
UnicodeString::doReverse(int32_t start, int32_t length) {
if(length <= 1 || !cloneArrayIfNeeded()) {
return *this;
}
// pin the indices to legal values
pinIndices(start, length);
if(length <= 1) { // pinIndices() might have shrunk the length
return *this;
}
UChar *left = getArrayStart() + start;
UChar *right = left + length - 1; // -1 for inclusive boundary (length>=2)