AuroraMiddleware/scuffed-code
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ICU-6967 Changed if statement to check for the same sign for the values instead of the exact number.

Browse Source 
X-SVN-Rev: 26144
This commit is contained in:
John Vu 2009-06-23 19:47:15 +00:00
parent edf161736f
commit e2879a0667
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
icu4c/source/test/cintltst/putiltst.c
View File

@ -305,15 +305,15 @@ static void TestCompareVersions()
u_versionFromString(v2, v2str); u_versionFromString(v2, v2str);
got = memcmp(v1, v2, sizeof(UVersionInfo)); got = memcmp(v1, v2, sizeof(UVersionInfo));
invgot = memcmp(v2, v1, sizeof(UVersionInfo)); /* Opposite */ invgot = memcmp(v2, v1, sizeof(UVersionInfo)); /* Opposite */
if(got==op) { if((got < 0 && op < 0) || (got > 0 && op > 0)) {
log_verbose("%d: %s %s %s, OK\n", (j/3), v1str, opstr, v2str); log_verbose("%d: %s %s %s, OK\n", (j/3), v1str, opstr, v2str);
} else { } else {
log_err("%d: %s %s %s: wanted %d got %d\n", (j/3), v1str, opstr, v2str, op, got); log_err("%d: %s %s %s: wanted values of the same sign, %d got %d\n", (j/3), v1str, opstr, v2str, op, got);
} }
if(invgot==invop) { if((invgot > 0 && invop > 0) || (invgot < 0 && invop < 0)) {
log_verbose("%d: %s (%d) %s, OK (inverse)\n", (j/3), v2str, invop, v1str); log_verbose("%d: %s (%d) %s, OK (inverse)\n", (j/3), v2str, invop, v1str);
} else { } else {
log_err("%d: %s (%d) %s: wanted %d got %d\n", (j/3), v2str, invop, v1str, invop, invgot); log_err("%d: %s (%d) %s: wanted values of the same sign, %d got %d\n", (j/3), v2str, invop, v1str, invop, invgot);
} }
} }
} }