ICU-5135 Added TODO comments in the update test cases in the previous code submission
X-SVN-Rev: 21149
This commit is contained in:
parent
51bebc6c94
commit
f65edbb549
@ -108,8 +108,10 @@ void DateFormatRoundTripTest::TestCentury()
|
|||||||
* offset calculation bug that observed DST in 1926, which was resolved.
|
* offset calculation bug that observed DST in 1926, which was resolved.
|
||||||
* Before the bug was resolved, result[0] == result[1] was true,
|
* Before the bug was resolved, result[0] == result[1] was true,
|
||||||
* but after the bug fix, the expected result is actually
|
* but after the bug fix, the expected result is actually
|
||||||
* result[0] != result[1]. We actually need to review this code
|
* result[0] != result[1]. -Yoshito
|
||||||
* and clarify what we really want to test here. -Yoshito
|
*/
|
||||||
|
/* TODO: We need to review this code and clarify what we really
|
||||||
|
* want to test here.
|
||||||
*/
|
*/
|
||||||
//if (date[1] != date[2] || result[0] != result[1]) {
|
//if (date[1] != date[2] || result[0] != result[1]) {
|
||||||
if (date[1] != date[2]) {
|
if (date[1] != date[2]) {
|
||||||
|
@ -473,6 +473,9 @@ void IntlCalendarTest::TestJapaneseFormat() {
|
|||||||
* If ICU properly capture entire Olson zone definition, the start time of "Meiji 1" is
|
* If ICU properly capture entire Olson zone definition, the start time of "Meiji 1" is
|
||||||
* -3197117222000. -Yoshito
|
* -3197117222000. -Yoshito
|
||||||
*/
|
*/
|
||||||
|
/* TODO: When ICU support the Olson LMT offset for America/Los_Angeles, we need to update
|
||||||
|
* the reference data.
|
||||||
|
*/
|
||||||
//aDate = -3197120400000.;
|
//aDate = -3197120400000.;
|
||||||
aDate = -3197116800000.;
|
aDate = -3197116800000.;
|
||||||
CHECK(status, "creating date format instance");
|
CHECK(status, "creating date format instance");
|
||||||
|
@ -493,6 +493,9 @@ void TimeZoneRegressionTest:: Test4126678()
|
|||||||
if (offset == raw_offset)
|
if (offset == raw_offset)
|
||||||
errln("Offsets should not match when in DST");
|
errln("Offsets should not match when in DST");
|
||||||
*/
|
*/
|
||||||
|
/* TODO: When ICU support the Olson LMT offset for America/Los_Angeles, we need to update
|
||||||
|
* the reference data.
|
||||||
|
*/
|
||||||
if (offset != raw_offset)
|
if (offset != raw_offset)
|
||||||
errln("Offsets should match");
|
errln("Offsets should match");
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user