AuroraMiddleware/scuffed-code
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ICU-20193 urename.h shouldn't be ignored by other compilers except VS IntelliSense (#189)

Browse Source 
The macro _MSC_VER is not defined in other compilers.
Change the logic and so urename.h is ignored on VS IntelliSense
This commit is contained in:
gvictor 2018-10-05 00:29:57 +01:00 committed by Jeff Genovy
parent 7d99ba4e57
commit ff72d74d1e
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
icu4c/source/common/unicode/urename.h
View File

@ -34,7 +34,7 @@
#if !U_DISABLE_RENAMING
// Disable Renaming for Visual Studio's IntelliSense feature, so that 'Go-to-Definition' (F12) will work.
#if defined(_MSC_VER) && !defined(__INTELLISENSE__)
#if !(defined(_MSC_VER) && defined(__INTELLISENSE__))
/* We need the U_ICU_ENTRY_POINT_RENAME definition. There's a default one in unicode/uvernum.h we can use, but we will give
the platform a chance to define it first.
@ -1858,7 +1858,7 @@
#define ztrans_setTime U_ICU_ENTRY_POINT_RENAME(ztrans_setTime)
#define ztrans_setTo U_ICU_ENTRY_POINT_RENAME(ztrans_setTo)
#endif /* defined(_MSC_VER) && !defined(__INTELLISENSE__) */
#endif /* !(defined(_MSC_VER) && defined(__INTELLISENSE__)) */
#endif /* U_DISABLE_RENAMING */
#endif /* URENAME_H */

4
icu4c/source/tools/genren/genren.pl
View File

@ -107,7 +107,7 @@ print HEADER <<"EndOfHeaderComment";
#if !U_DISABLE_RENAMING
// Disable Renaming for Visual Studio's IntelliSense feature, so that 'Go-to-Definition' (F12) will work.
#if defined(_MSC_VER) && !defined(__INTELLISENSE__)
#if !(defined(_MSC_VER) && defined(__INTELLISENSE__))
/* We need the U_ICU_ENTRY_POINT_RENAME definition. There's a default one in unicode/uvernum.h we can use, but we will give
the platform a chance to define it first.
@ -242,7 +242,7 @@ foreach(sort keys(%CFuncs)) {
print HEADER <<"EndOfHeaderFooter";
#endif /* defined(_MSC_VER) && !defined(__INTELLISENSE__) */
#endif /* !(defined(_MSC_VER) && defined(__INTELLISENSE__)) */
#endif /* U_DISABLE_RENAMING */
#endif /* URENAME_H */