Commit Graph

895 Commits

Author SHA1 Message Date
Abhinav Gupta
1efa6d411f ICU-8854 bitwise and/or of signed byte value.
Values loaded from a byte array are sign extended to 32-bits before any
bitwise operations are performed. Should &-down back to one-byte.

X-SVN-Rev: 30862
2011-10-24 19:24:08 +00:00
Abhinav Gupta
e35f720425 ICU-8854 dead store to local variable
X-SVN-Rev: 30861
2011-10-24 19:23:59 +00:00
Abhinav Gupta
3ae6d5af5b ICU-8854 computation of average could overflow.
X-SVN-Rev: 30860
2011-10-24 19:23:51 +00:00
Abhinav Gupta
5f0127fd5d ICU-8854 equals() does not check for null.
X-SVN-Rev: 30859
2011-10-24 19:23:44 +00:00
Abhinav Gupta
77598a7d62 ICU-8854 Unused final instance variable. Should be static.
X-SVN-Rev: 30858
2011-10-24 19:23:29 +00:00
Abhinav Gupta
04b9f1678a ICU-8854 unnecessary use of String constructor.
X-SVN-Rev: 30857
2011-10-24 19:23:20 +00:00
Abhinav Gupta
87f031cd34 ICU-8854 use of inefficient Number constructors. Use valueOf.
X-SVN-Rev: 30856
2011-10-24 19:14:19 +00:00
Abhinav Gupta
7f0d45c7ad ICU-8854 toString may return null
X-SVN-Rev: 30855
2011-10-24 19:14:10 +00:00
Abhinav Gupta
2192442a0e ICU-8854 integral division result cast to double (and floored).
Unnecessary because integral division already truncates the result.

X-SVN-Rev: 30854
2011-10-24 19:14:03 +00:00
Abhinav Gupta
9794f1727b ICU-8854 unchecked/unconfirmed cast.
X-SVN-Rev: 30853
2011-10-24 19:13:57 +00:00
Mark Davis
9424775dc1 ICU-8807 Small changes in Map, Property
X-SVN-Rev: 30852
2011-10-23 22:31:02 +00:00
Mark Davis
0e05f5d9d6 ICU-8898 Checked in (since shifting systems) but can retract if not approved.
X-SVN-Rev: 30851
2011-10-23 22:27:11 +00:00
Yoshito Umaoka
02bf9dd68a ICU-8649 Integrating JCite and embedding coding example in the ICU4J API reference doc.
X-SVN-Rev: 30841
2011-10-17 21:10:07 +00:00
Abhinav Gupta
728bdac7fa ICU-8854 possible null pointer dereference.
X-SVN-Rev: 30839
2011-10-17 20:24:17 +00:00
Abhinav Gupta
9c83ba6e64 ICU-8854 Unclosed streams.
X-SVN-Rev: 30838
2011-10-17 20:24:09 +00:00
Abhinav Gupta
0c1d2e9452 ICU-8854 Result of integer multiplication cast to long after
multiplication. Casting should be done before multiplication to avoid
overflow.

X-SVN-Rev: 30837
2011-10-17 20:23:59 +00:00
Abhinav Gupta
7a58e117d9 ICU-8854 Inefficient use of number constructors. Use valueOf instead.
X-SVN-Rev: 30836
2011-10-17 20:23:48 +00:00
Yoshito Umaoka
a5edd10c64 ICU-8446 System property user.script to initialize ULocale's script field on Java 6 or older JREs.
X-SVN-Rev: 30824
2011-10-14 22:11:56 +00:00
Abhinav Gupta
037aa7865a ICU-8876 disabled Clover where necessary.
Disabled for parts of  PluralRules, RBBIDataWrapper, RBBISetBuilder,
TimeZoneNames, Calendar.

X-SVN-Rev: 30811
2011-10-12 15:31:19 +00:00
Abhinav Gupta
ab30e3c400 ICU-8876 added test for SelectFormat.format exception.
X-SVN-Rev: 30810
2011-10-12 15:31:07 +00:00
Yoshito Umaoka
cd49cad3f7 ICU-8874 Modified TestCompareReferenceImpl to do the same tests with ICU4C corresponding test case. Fixed problems in IDNAReference, which was obviously out of date. Restored toUnicode tests in TestErrorCases (but still excluding ASCII only error cases).
X-SVN-Rev: 30805
2011-10-07 22:35:38 +00:00
Yoshito Umaoka
ed2c135303 ICU-8856 Explicit private constructor to prevent MessagePatternUtil instatiation. This change fixed unwanted javadoc/api report for MessagePatternUtil constructor.
X-SVN-Rev: 30791
2011-10-04 15:59:21 +00:00
Yoshito Umaoka
53eb6fa62f ICU-8856 Fixed a javac compiler warning.
X-SVN-Rev: 30790
2011-10-04 15:45:25 +00:00
Yoshito Umaoka
406f46d075 ICU-8856 Fixed Eclipse compiler warnings.
X-SVN-Rev: 30789
2011-10-04 15:09:36 +00:00
Yoshito Umaoka
504e04477a ICU-8856 Organized import statements
X-SVN-Rev: 30788
2011-10-04 14:38:02 +00:00
Michael Ow
46fc0ce9da ICU-8864 Use fallback mechanism for empty string in ICUResourceTableAccess get method
X-SVN-Rev: 30782
2011-10-03 19:17:07 +00:00
Michael Ow
1b6e647811 ICU-8592 Update ICU4J time zone data to 2011k
X-SVN-Rev: 30777
2011-10-03 17:59:37 +00:00
Peter Edberg
69bb199a1b ICU-8753 Replace confusing use of dst variable with prevOffset / newOffset
X-SVN-Rev: 30772
2011-09-30 21:32:41 +00:00
Yoshito Umaoka
c27fc1d6e5 ICU-8518 Misspelled again... Corrected.
X-SVN-Rev: 30771
2011-09-30 21:17:08 +00:00
Yoshito Umaoka
a87cae4ff8 ICU-8518 Corrected spelling found by Markus's review
X-SVN-Rev: 30769
2011-09-30 20:52:56 +00:00
Abhinav Gupta
33f9e7e935 ICU-8856 copyright info on com.ibm.icu.text.SourceTargetUtility.
X-SVN-Rev: 30768
2011-09-30 20:28:27 +00:00
Michael Ow
6903a27947 ICU-8515 Add missing provisional tag to draft API CharsetEncoderICU.getMaxBytesForString
X-SVN-Rev: 30760
2011-09-30 19:16:20 +00:00
Abhinav Gupta
2dde8091b2 ICU-8268 fixed problems found in code review.
X-SVN-Rev: 30759
2011-09-30 19:01:29 +00:00
John Emmons
e14fa4e630 ICU-8846 Merge CLDRv21M1 data into ICU
X-SVN-Rev: 30756
2011-09-29 21:57:33 +00:00
Abhinav Gupta
9f4b2deecc ICU-8856 fixed newline removed by icu-svnprops-check.
X-SVN-Rev: 30754
2011-09-29 21:05:55 +00:00
Steven R. Loomis
f2dea4dba1 ICU-8855 undo bad commit r30752
X-SVN-Rev: 30753
2011-09-29 20:18:13 +00:00
Abhinav Gupta
27cdc577c8 ICU-8855 utf-8 file properties for icu4j (with copyright updates).
X-SVN-Rev: 30752
2011-09-29 19:44:32 +00:00
Abhinav Gupta
deca5a8197 ICU-8856 text file line endings fixed for icu4j
X-SVN-Rev: 30741
2011-09-28 21:16:24 +00:00
Abhinav Gupta
00d87011fd ICU-8268 Unitialized read of field in constructor.
X-SVN-Rev: 30738
2011-09-28 20:30:19 +00:00
Abhinav Gupta
dc1f5c5a80 ICU-8268 Fixed use of & instead of &&.
X-SVN-Rev: 30737
2011-09-28 20:30:12 +00:00
Abhinav Gupta
7048d48b6e ICU-8268 equals(Object o) methods assume that o is the correct type.
X-SVN-Rev: 30736
2011-09-28 20:30:06 +00:00
Abhinav Gupta
6916271396 ICU-8268 computation of average could overflow.
The (a+b)/2 or (a+b)>>1 could cause an overflow. Use unsigned bit shift (>>>).

X-SVN-Rev: 30735
2011-09-28 20:29:59 +00:00
Abhinav Gupta
24f423c0f8 ICU-8268 inefficient use of Long, Integer, Character constructors.
X-SVN-Rev: 30734
2011-09-28 20:29:47 +00:00
Abhinav Gupta
79287fc66b ICU-8268 Inefficient use of new String(...) constructor.
X-SVN-Rev: 30733
2011-09-28 20:29:28 +00:00
Abhinav Gupta
7e90359b1a ICU-8268 null check of value previously dereferenced.
A value is null-checked after it has already been dereferenced. If it was
null, it would never get to the check because of NullPointerException.

X-SVN-Rev: 30732
2011-09-28 20:29:19 +00:00
Abhinav Gupta
e20dcd910d ICU-8268 toString on array doesn't produce anything useful. Use Arrays.toString.
X-SVN-Rev: 30730
2011-09-28 14:46:11 +00:00
Markus Scherer
077d3a16e0 ICU-8779 add UNKNOWN_ZONE & GMT_ZONE
X-SVN-Rev: 30728
2011-09-27 23:52:04 +00:00
Abhinav Gupta
c2769af599 ICU-8268 return value was ignored.
Return value of string concatenation was ignored. Results in invalid data.

X-SVN-Rev: 30726
2011-09-27 19:50:26 +00:00
Abhinav Gupta
c9b90e11db ICU-8268 dead store to local variable.
A value is assigned to a local variable but never read again.

Signed-off-by: Abhinav Gupta <abhinavg@ca.ibm.com>

X-SVN-Rev: 30725
2011-09-27 19:50:19 +00:00
Abhinav Gupta
b58534a609 ICU-8268 impossible cast from double[] to int[].
Java doesn't allow casting array of type A to array of type B. The elements
have to be manually casted.

X-SVN-Rev: 30723
2011-09-27 19:49:59 +00:00