AuroraMiddleware/scuffed-code
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
24,333 Commits 1 Branch 0 Tags 274 MiB
698b723ba9
Commit Graph

656 Commits

Author SHA1 Message Date
Abhinav Gupta
698b723ba9 ICU-8854 Dead store to local variable. 
X-SVN-Rev: 30923
 2011-11-04 15:17:52 +00:00
Abhinav Gupta
82962c12cb ICU-8854 Unused final instance variable. Should be static. 
X-SVN-Rev: 30922
 2011-11-04 15:17:34 +00:00
Abhinav Gupta
fc9b8646db ICU-8854 string concatenation in loop using + operator 
X-SVN-Rev: 30863
 2011-10-24 19:24:17 +00:00
Abhinav Gupta
1efa6d411f ICU-8854 bitwise and/or of signed byte value. 
Values loaded from a byte array are sign extended to 32-bits before any
bitwise operations are performed. Should &-down back to one-byte.

X-SVN-Rev: 30862
 2011-10-24 19:24:08 +00:00
Abhinav Gupta
e35f720425 ICU-8854 dead store to local variable 
X-SVN-Rev: 30861
 2011-10-24 19:23:59 +00:00
Abhinav Gupta
3ae6d5af5b ICU-8854 computation of average could overflow. 
X-SVN-Rev: 30860
 2011-10-24 19:23:51 +00:00
Abhinav Gupta
5f0127fd5d ICU-8854 equals() does not check for null. 
X-SVN-Rev: 30859
 2011-10-24 19:23:44 +00:00
Abhinav Gupta
77598a7d62 ICU-8854 Unused final instance variable. Should be static. 
X-SVN-Rev: 30858
 2011-10-24 19:23:29 +00:00
Abhinav Gupta
04b9f1678a ICU-8854 unnecessary use of String constructor. 
X-SVN-Rev: 30857
 2011-10-24 19:23:20 +00:00
Abhinav Gupta
87f031cd34 ICU-8854 use of inefficient Number constructors. Use valueOf. 
X-SVN-Rev: 30856
 2011-10-24 19:14:19 +00:00
Abhinav Gupta
7f0d45c7ad ICU-8854 toString may return null 
X-SVN-Rev: 30855
 2011-10-24 19:14:10 +00:00
Abhinav Gupta
2192442a0e ICU-8854 integral division result cast to double (and floored). 
Unnecessary because integral division already truncates the result.

X-SVN-Rev: 30854
 2011-10-24 19:14:03 +00:00
Abhinav Gupta
9794f1727b ICU-8854 unchecked/unconfirmed cast. 
X-SVN-Rev: 30853
 2011-10-24 19:13:57 +00:00
Mark Davis
0e05f5d9d6 ICU-8898 Checked in (since shifting systems) but can retract if not approved. 
X-SVN-Rev: 30851
 2011-10-23 22:27:11 +00:00
Yoshito Umaoka
02bf9dd68a ICU-8649 Integrating JCite and embedding coding example in the ICU4J API reference doc. 
X-SVN-Rev: 30841
 2011-10-17 21:10:07 +00:00
Abhinav Gupta
728bdac7fa ICU-8854 possible null pointer dereference. 
X-SVN-Rev: 30839
 2011-10-17 20:24:17 +00:00
Abhinav Gupta
9c83ba6e64 ICU-8854 Unclosed streams. 
X-SVN-Rev: 30838
 2011-10-17 20:24:09 +00:00
Abhinav Gupta
0c1d2e9452 ICU-8854 Result of integer multiplication cast to long after 
multiplication. Casting should be done before multiplication to avoid
overflow.

X-SVN-Rev: 30837
 2011-10-17 20:23:59 +00:00
Abhinav Gupta
7a58e117d9 ICU-8854 Inefficient use of number constructors. Use valueOf instead. 
X-SVN-Rev: 30836
 2011-10-17 20:23:48 +00:00
Yoshito Umaoka
a5edd10c64 ICU-8446 System property user.script to initialize ULocale's script field on Java 6 or older JREs. 
X-SVN-Rev: 30824
 2011-10-14 22:11:56 +00:00
Abhinav Gupta
037aa7865a ICU-8876 disabled Clover where necessary. 
Disabled for parts of  PluralRules, RBBIDataWrapper, RBBISetBuilder,
TimeZoneNames, Calendar.

X-SVN-Rev: 30811
 2011-10-12 15:31:19 +00:00
Yoshito Umaoka
ed2c135303 ICU-8856 Explicit private constructor to prevent MessagePatternUtil instatiation. This change fixed unwanted javadoc/api report for MessagePatternUtil constructor. 
X-SVN-Rev: 30791
 2011-10-04 15:59:21 +00:00
Yoshito Umaoka
53eb6fa62f ICU-8856 Fixed a javac compiler warning. 
X-SVN-Rev: 30790
 2011-10-04 15:45:25 +00:00
Yoshito Umaoka
504e04477a ICU-8856 Organized import statements 
X-SVN-Rev: 30788
 2011-10-04 14:38:02 +00:00
Michael Ow
46fc0ce9da ICU-8864 Use fallback mechanism for empty string in ICUResourceTableAccess get method 
X-SVN-Rev: 30782
 2011-10-03 19:17:07 +00:00
Peter Edberg
69bb199a1b ICU-8753 Replace confusing use of dst variable with prevOffset / newOffset 
X-SVN-Rev: 30772
 2011-09-30 21:32:41 +00:00
Yoshito Umaoka
a87cae4ff8 ICU-8518 Corrected spelling found by Markus's review 
X-SVN-Rev: 30769
 2011-09-30 20:52:56 +00:00
Abhinav Gupta
33f9e7e935 ICU-8856 copyright info on com.ibm.icu.text.SourceTargetUtility. 
X-SVN-Rev: 30768
 2011-09-30 20:28:27 +00:00
Michael Ow
6903a27947 ICU-8515 Add missing provisional tag to draft API CharsetEncoderICU.getMaxBytesForString 
X-SVN-Rev: 30760
 2011-09-30 19:16:20 +00:00
Abhinav Gupta
2dde8091b2 ICU-8268 fixed problems found in code review. 
X-SVN-Rev: 30759
 2011-09-30 19:01:29 +00:00
Steven R. Loomis
f2dea4dba1 ICU-8855 undo bad commit r30752 
X-SVN-Rev: 30753
 2011-09-29 20:18:13 +00:00
Abhinav Gupta
27cdc577c8 ICU-8855 utf-8 file properties for icu4j (with copyright updates). 
X-SVN-Rev: 30752
 2011-09-29 19:44:32 +00:00
Abhinav Gupta
00d87011fd ICU-8268 Unitialized read of field in constructor. 
X-SVN-Rev: 30738
 2011-09-28 20:30:19 +00:00
Abhinav Gupta
dc1f5c5a80 ICU-8268 Fixed use of & instead of &&. 
X-SVN-Rev: 30737
 2011-09-28 20:30:12 +00:00
Abhinav Gupta
7048d48b6e ICU-8268 equals(Object o) methods assume that o is the correct type. 
X-SVN-Rev: 30736
 2011-09-28 20:30:06 +00:00
Abhinav Gupta
6916271396 ICU-8268 computation of average could overflow. 
The (a+b)/2 or (a+b)>>1 could cause an overflow. Use unsigned bit shift (>>>).

X-SVN-Rev: 30735
 2011-09-28 20:29:59 +00:00
Abhinav Gupta
24f423c0f8 ICU-8268 inefficient use of Long, Integer, Character constructors. 
X-SVN-Rev: 30734
 2011-09-28 20:29:47 +00:00
Abhinav Gupta
79287fc66b ICU-8268 Inefficient use of new String(...) constructor. 
X-SVN-Rev: 30733
 2011-09-28 20:29:28 +00:00
Abhinav Gupta
7e90359b1a ICU-8268 null check of value previously dereferenced. 
A value is null-checked after it has already been dereferenced. If it was
null, it would never get to the check because of NullPointerException.

X-SVN-Rev: 30732
 2011-09-28 20:29:19 +00:00
Markus Scherer
077d3a16e0 ICU-8779 add UNKNOWN_ZONE & GMT_ZONE 
X-SVN-Rev: 30728
 2011-09-27 23:52:04 +00:00
Abhinav Gupta
c2769af599 ICU-8268 return value was ignored. 
Return value of string concatenation was ignored. Results in invalid data.

X-SVN-Rev: 30726
 2011-09-27 19:50:26 +00:00
Abhinav Gupta
c9b90e11db ICU-8268 dead store to local variable. 
A value is assigned to a local variable but never read again.

Signed-off-by: Abhinav Gupta <abhinavg@ca.ibm.com>

X-SVN-Rev: 30725
 2011-09-27 19:50:19 +00:00
Abhinav Gupta
b58534a609 ICU-8268 impossible cast from double[] to int[]. 
Java doesn't allow casting array of type A to array of type B. The elements
have to be manually casted.

X-SVN-Rev: 30723
 2011-09-27 19:49:59 +00:00
Abhinav Gupta
55e9ba2738 ICU-8268 Inefficient use of Map.keySet. Use entrySet instead. 
X-SVN-Rev: 30721
 2011-09-27 19:49:44 +00:00
Abhinav Gupta
b8f1bb9223 ICU-8268 concatenation of strings using + in a loop is inefficient. Use StringBuilder. 
X-SVN-Rev: 30720
 2011-09-27 18:15:21 +00:00
Abhinav Gupta
811b9905c8 ICU-8268 toString on array doesn't produce anything useful. Use Arrays.toString. 
X-SVN-Rev: 30719
 2011-09-27 18:15:12 +00:00
Abhinav Gupta
a65971645c ICU-8268 repeated conditional test 
X-SVN-Rev: 30718
 2011-09-27 18:15:03 +00:00
Abhinav Gupta
d96782f661 ICU-8268 update copyrights of previously touched files 
X-SVN-Rev: 30717
 2011-09-27 18:14:53 +00:00
Abhinav Gupta
d00e5b14fb ICU-8328 switched to separate icudata.jar and icutzdata.jar 
X-SVN-Rev: 30710
 2011-09-26 15:30:39 +00:00
Angshuman Deb
aab73b3bb7 ICU-8796 fixed Javadoc with {@icuenhanced} tag 
X-SVN-Rev: 30694
 2011-09-20 01:40:44 +00:00