2021-10-20 20:20:42 +00:00
|
|
|
workspace(name = "skia")
|
2020-09-11 16:11:33 +00:00
|
|
|
|
2022-04-01 12:29:11 +00:00
|
|
|
load("//toolchain:download_toolchains.bzl", "download_toolchains_for_skia")
|
|
|
|
|
|
[bazel] Add support for Macs to make Linux RBE builds
The big change here is having the C++ toolchain use
Bazel platforms instead of the C++ specific flags/setup.
In Bazel, platforms are a general purpose way to define
things like os, cpu architecture, etc. We were not using
platforms previously, because the best documentation at
the time focused on the old ways.
However, the old ways were clumsy/difficult when trying
to manage cross-compilation, specifically when trying
to have a Mac host trigger a build on our Linux RBE
system targeting a Linux x64 system. Thus, rather than
keep investing in the legacy system, this CL migrates
us to using platforms where possible.
Suggested background reading to better understand this CL:
- https://bazel.build/concepts/platforms-intro
- https://bazel.build/docs/platforms
- https://bazel.build/docs/toolchains#registering-building-toolchains
The hermetic toolchain itself is not changing in this CL
(and likely does not need to), only how we tell Bazel
about it (i.e. registering it) and how Bazel decides
to use it (i.e. resolving toolchains).
Here is my understanding of how platforms and toolchains
interact (supported by some evidence from [1][2])
- Bazel needs to resolve platforms for the Host, Execution,
and Target.
- If not specified via flags, these are the machine from
which Bazel is invoked, aka "@local_config_platform//:host".
- With this CL, the Host could be a Mac laptop, the Execution
platform is our Linux RBE pool, and the Target is "a Linux
system with a x64 CPU"
- To specify the Host, that is, describe to Bazel the
capabilities of the system it is running on, one can
set --host_platform [3] with a label pointing to a platform()
containing the appropriate settings. Tip: have this
platform inherit from @local_config_platform//:host
so it can add to any of the constraint_settings and
constraint_values that Bazel deduces automatically.
- To specify the Target platform(s), that is, the system
on which a final output resides and can execute, one
can set the --platforms flag with a label referencing
a platform().
- Bazel will then choose an execution platform to fulfill
that request. Bazel will look through a list of available
platforms, which can be augmented* with the
--extra_execution_platforms. Platforms specified by this
flag will be considered higher than the default platforms!
- Having selected the appropriate platforms, Bazel now
needs to select a toolchain to actually run the actions
of the appropriate type.
- Bazel looks through the list of available toolchains
and finds one that "matches" the Execution and the Target
platform. This means, the toolchain's exec_compatible_with
is a strict subset of the Execution platform and
the toolchain's target_compatible_with is a strict subset
of the Target platform. To register toolchains* (i.e. add
them to the resolution list), we use --extra_toolchains.
Once Bazel finds a match, it stops looking.
Using --toolchain_resolution_debug=".*" makes Bazel log
how it is resolving these toolchains and what execution
platform it picked.
* We can also register execution platforms and toolchains in
WORKSPACE.bazel [4], but the flags come with higher priority
and that made resolution a bit tricky. Also, when we want
to conditionally add them (e.g. --config=linux_rbe), we
cannot remove them conditionally in the WORKSPACE.bazel file.
The above resolution flow directly necessitated the changes
in this CL.
Example usage of the new configs and platforms:
# Can be run on a x64 Linux host and uses the hermetic toolchain.
bazel build //:skia_public
# Can be run on Mac or Linux and uses the Linux RBE system along
# with the hermetic toolchain to compile a binary for Linux x64.
bazel build //:skia_public --config=linux_rbe --config=for_linux_x64
# Shorthand for above
bazel build //:skia_public --config=for_linux_x64_with_rbe
Notice we don't have to type out --config=clang_linux anymore!
That was due to me reading the Bazel docs more carefully and
realizing we can set options for *all* Bazel build commands.
Current Limitations:
- Targets which require a py_binary (e.g. Dawn's genrules)
will not work on RBE when cross compiling because the
python runtime we download is for the host machine, not
the executor. This means //example:hello_world_dawn does
not work on Mac when cross-compiling via linux_rbe.
- Mac M1 linking not quite working with SkOpts settings.
Probably need to set -target [5]
Suggested Review order:
- toolchain/BUILD.bazel Notice how we do away with
cc_toolchain_suite for toolchain. These have the same
role: giving Bazel the information about where a toolchain
can run. The platforms one is more expressive (IMO), allowing
us to say both where to run the toolchain and what it can
make. In order to more easily force the use of our hermetic
toolchain, but also allow the hermetic toolchain to be used
on RBE, we specify "use_hermetic_toolchain" only on the target,
because the RBE image does not have the hermetic toolchain
on it by default (but can certainly run it).
- bazel/platform/BUILD.bazel to see the custom constraint_setting
and corresponding constraint_value. The names for both of these
are completely arbitrary - they do not need to have any deeper
meaning or relation to any file or Docker image or system or
any other constraints. Think of the constraint_setting as
an Enum and the constraint_value being the one and only member.
We need to pass around a constant value, not a type, so we
need to provide the constraint_value (e.g. in toolchain/BUILD.bazel)
but not a constraint_setting. However we need a
constraint_setting declared so we can make a constraint_value
of that "type".
Notice the platform declared here - it allows us to force
Bazel to use the hermetic toolchain because of the extra
constraint_value.
- .bazelrc I set a few flags that will be on for all
bazel build commands. Importantly, this causes the C++
build logic to use platforms and not the old, bespoke way.
I also found a way to avoid using the local toolchain on
the host, which will hopefully lead to clearer errors
if platforms are mis-specified instead of odd compile
errors because the host toolchain is too old or something.
There are also a few RBE settings tweaked to be a bit
more modern, as well the new shorthands for specifying
target platforms (e.g. for_linux_x64).
- bazel/buildrc where we have to turn off the platforms
logic for emscripten https://github.com/emscripten-core/emsdk/issues/984
- bazel/rbe/BUILD.bazel for a fix in the platform description
that makes it work on Mac.
- Notice that _m1 has been removed from the mac-related toolchain
files because the same toolchain should work on both
architectures.
- All other changes in any order.
[1] https://bazel.build/docs/toolchains#debugging-toolchains
[2] https://bazel.build/docs/toolchains#toolchain-resolution
[3] https://bazel.build/reference/command-line-reference
[4] https://bazel.build/docs/toolchains#registering-building-toolchains
[5] https://github.com/google/skia/blob/17dc3f16fc78477503ba1ef484c3b47bc3aab893/gn/skia/BUILD.gn#L258-L271
Change-Id: I515c114099d659639a808f74e47d489a68b7af62
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/549737
Reviewed-by: Erik Rose <erikrose@google.com>
Reviewed-by: Jorge Betancourt <jmbetancourt@google.com>
2022-06-22 19:28:10 +00:00
|
|
|
download_toolchains_for_skia("clang_linux_amd64", "clang_mac")
|
2022-04-01 12:29:11 +00:00
|
|
|
|
[infra] Add initial Bazel rules and files
These rules can be used to build our GMs on WASM+WebGL and
libskia.a with just the CPU backend (and most other features
turned off).
This can be done with the following commands:
- bazel build //modules/canvaskit:gm-bindings-wasm --gpu_backend=gl_backend --with_gl_standard=webgl_standard
- bazel build :skia-core --config clang
This pivots slightly from http://review.skia.org/463517
by using config_settings [1] instead of platforms for
the optional features that we control. This pivot was
suggested in [2]
We have BUILD.bazel files in many of the subdirectories
that specify filegroups for the appropriate files. In
an effort to make //BUILD.bazel more readable, it is
the responsibility of these subfolders to deal with
conditionally including certain .h or .cpp files.
This is done using select statements and config_settings
or platform constraints as necessary.
For example, src/gpu/BUILD.bazel will different private
filegroups for each of the supported gpu backends [3]
and a more-visible filegroup called "srcs" that has
the right selection of the private files to be used
for compilation.
An effort has been made to avoid using glob() in our
BUILD.bazel files. These file lists were made by using
`ls -1` and some regex to add in quotes. We might want
to make a helper script to assist with that, if necessary.
To specify which options we have, the settings in
//bazel/common_config_settings/BUILD.bazel have been
redesigned. They make use of a macro `string_flag_with_values`
that removes the boilerplate. Patchset 36 shows what the
file looks like w/o the macro.
The top level BUILD.bazel file will still need to use
some logic to handle defines, because local_defines is
a list of strings, not a list of labels [4].
Suggested Review Order:
- WORKSPACE.bazel to see the new dependencies on the
emsdk toolchain and bazel_skylib
- bazel/common_config_settings/* to see the few settings
defined (we have more to define, see BUILD.gn and
//gn/skia.gni for ideas)
- BUILD.bazel to see the "skia-core" cc_library rule.
See also "gms" and "tests"
- modules/canvaskit/BUILD.bazel to see the use of
the emscripten "wasm_cc_binary" rule, which depends
on the "skia-core", "gms", and "tests" rule. Note that
it only builds some of the gms as a proof of concept.
- The other BUILD.bazel files. Some of these are not
platform or feature dependent (e.g. pathops). Others
are (e.g. gpu).
- All other files.
[1] https://docs.bazel.build/versions/4.2.1/skylark/config.html#user-defined-build-settings
[2] https://github.com/emscripten-core/emsdk/pull/920
[3] In this CL, that's just the webgl one.
[4] https://docs.bazel.build/versions/main/be/c-cpp.html#cc_library.local_defines
Change-Id: Ieecf9c106d5e3a6ae97d13d66be06b4b3c207089
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458637
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
2021-11-08 20:26:09 +00:00
|
|
|
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
|
2021-10-20 20:20:42 +00:00
|
|
|
|
[infra] Add initial Bazel rules and files
These rules can be used to build our GMs on WASM+WebGL and
libskia.a with just the CPU backend (and most other features
turned off).
This can be done with the following commands:
- bazel build //modules/canvaskit:gm-bindings-wasm --gpu_backend=gl_backend --with_gl_standard=webgl_standard
- bazel build :skia-core --config clang
This pivots slightly from http://review.skia.org/463517
by using config_settings [1] instead of platforms for
the optional features that we control. This pivot was
suggested in [2]
We have BUILD.bazel files in many of the subdirectories
that specify filegroups for the appropriate files. In
an effort to make //BUILD.bazel more readable, it is
the responsibility of these subfolders to deal with
conditionally including certain .h or .cpp files.
This is done using select statements and config_settings
or platform constraints as necessary.
For example, src/gpu/BUILD.bazel will different private
filegroups for each of the supported gpu backends [3]
and a more-visible filegroup called "srcs" that has
the right selection of the private files to be used
for compilation.
An effort has been made to avoid using glob() in our
BUILD.bazel files. These file lists were made by using
`ls -1` and some regex to add in quotes. We might want
to make a helper script to assist with that, if necessary.
To specify which options we have, the settings in
//bazel/common_config_settings/BUILD.bazel have been
redesigned. They make use of a macro `string_flag_with_values`
that removes the boilerplate. Patchset 36 shows what the
file looks like w/o the macro.
The top level BUILD.bazel file will still need to use
some logic to handle defines, because local_defines is
a list of strings, not a list of labels [4].
Suggested Review Order:
- WORKSPACE.bazel to see the new dependencies on the
emsdk toolchain and bazel_skylib
- bazel/common_config_settings/* to see the few settings
defined (we have more to define, see BUILD.gn and
//gn/skia.gni for ideas)
- BUILD.bazel to see the "skia-core" cc_library rule.
See also "gms" and "tests"
- modules/canvaskit/BUILD.bazel to see the use of
the emscripten "wasm_cc_binary" rule, which depends
on the "skia-core", "gms", and "tests" rule. Note that
it only builds some of the gms as a proof of concept.
- The other BUILD.bazel files. Some of these are not
platform or feature dependent (e.g. pathops). Others
are (e.g. gpu).
- All other files.
[1] https://docs.bazel.build/versions/4.2.1/skylark/config.html#user-defined-build-settings
[2] https://github.com/emscripten-core/emsdk/pull/920
[3] In this CL, that's just the webgl one.
[4] https://docs.bazel.build/versions/main/be/c-cpp.html#cc_library.local_defines
Change-Id: Ieecf9c106d5e3a6ae97d13d66be06b4b3c207089
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458637
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
2021-11-08 20:26:09 +00:00
|
|
|
# See https://github.com/emscripten-core/emsdk/tree/85d27a4a2a60d591613a305b14ae438c2bb3ce11/bazel#setup-instructions
|
|
|
|
|
http_archive(
|
|
|
|
|
name = "emsdk",
|
2022-07-01 21:18:47 +00:00
|
|
|
sha256 = "74c7c54b3544555ec38d1e9dcc7e90b9f49ed0e04f2cc3fd44663c598af24124",
|
|
|
|
|
strip_prefix = "emsdk-3.1.15/bazel",
|
2022-01-13 15:19:38 +00:00
|
|
|
urls = [
|
2022-07-01 21:18:47 +00:00
|
|
|
"https://github.com/emscripten-core/emsdk/archive/refs/tags/3.1.15.tar.gz",
|
|
|
|
|
"https://storage.googleapis.com/skia-world-readable/bazel/74c7c54b3544555ec38d1e9dcc7e90b9f49ed0e04f2cc3fd44663c598af24124.tar.gz",
|
2022-01-13 15:19:38 +00:00
|
|
|
],
|
[infra] Add initial Bazel rules and files
These rules can be used to build our GMs on WASM+WebGL and
libskia.a with just the CPU backend (and most other features
turned off).
This can be done with the following commands:
- bazel build //modules/canvaskit:gm-bindings-wasm --gpu_backend=gl_backend --with_gl_standard=webgl_standard
- bazel build :skia-core --config clang
This pivots slightly from http://review.skia.org/463517
by using config_settings [1] instead of platforms for
the optional features that we control. This pivot was
suggested in [2]
We have BUILD.bazel files in many of the subdirectories
that specify filegroups for the appropriate files. In
an effort to make //BUILD.bazel more readable, it is
the responsibility of these subfolders to deal with
conditionally including certain .h or .cpp files.
This is done using select statements and config_settings
or platform constraints as necessary.
For example, src/gpu/BUILD.bazel will different private
filegroups for each of the supported gpu backends [3]
and a more-visible filegroup called "srcs" that has
the right selection of the private files to be used
for compilation.
An effort has been made to avoid using glob() in our
BUILD.bazel files. These file lists were made by using
`ls -1` and some regex to add in quotes. We might want
to make a helper script to assist with that, if necessary.
To specify which options we have, the settings in
//bazel/common_config_settings/BUILD.bazel have been
redesigned. They make use of a macro `string_flag_with_values`
that removes the boilerplate. Patchset 36 shows what the
file looks like w/o the macro.
The top level BUILD.bazel file will still need to use
some logic to handle defines, because local_defines is
a list of strings, not a list of labels [4].
Suggested Review Order:
- WORKSPACE.bazel to see the new dependencies on the
emsdk toolchain and bazel_skylib
- bazel/common_config_settings/* to see the few settings
defined (we have more to define, see BUILD.gn and
//gn/skia.gni for ideas)
- BUILD.bazel to see the "skia-core" cc_library rule.
See also "gms" and "tests"
- modules/canvaskit/BUILD.bazel to see the use of
the emscripten "wasm_cc_binary" rule, which depends
on the "skia-core", "gms", and "tests" rule. Note that
it only builds some of the gms as a proof of concept.
- The other BUILD.bazel files. Some of these are not
platform or feature dependent (e.g. pathops). Others
are (e.g. gpu).
- All other files.
[1] https://docs.bazel.build/versions/4.2.1/skylark/config.html#user-defined-build-settings
[2] https://github.com/emscripten-core/emsdk/pull/920
[3] In this CL, that's just the webgl one.
[4] https://docs.bazel.build/versions/main/be/c-cpp.html#cc_library.local_defines
Change-Id: Ieecf9c106d5e3a6ae97d13d66be06b4b3c207089
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458637
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
2021-11-08 20:26:09 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
load("@emsdk//:deps.bzl", emsdk_deps = "deps")
|
|
|
|
|
|
2022-02-23 14:02:11 +00:00
|
|
|
# One of the deps here is build_bazel_rules_nodejs, currently version 4.4.1
|
|
|
|
|
# If we try to install it ourselves after this, it won't work.
|
[infra] Add initial Bazel rules and files
These rules can be used to build our GMs on WASM+WebGL and
libskia.a with just the CPU backend (and most other features
turned off).
This can be done with the following commands:
- bazel build //modules/canvaskit:gm-bindings-wasm --gpu_backend=gl_backend --with_gl_standard=webgl_standard
- bazel build :skia-core --config clang
This pivots slightly from http://review.skia.org/463517
by using config_settings [1] instead of platforms for
the optional features that we control. This pivot was
suggested in [2]
We have BUILD.bazel files in many of the subdirectories
that specify filegroups for the appropriate files. In
an effort to make //BUILD.bazel more readable, it is
the responsibility of these subfolders to deal with
conditionally including certain .h or .cpp files.
This is done using select statements and config_settings
or platform constraints as necessary.
For example, src/gpu/BUILD.bazel will different private
filegroups for each of the supported gpu backends [3]
and a more-visible filegroup called "srcs" that has
the right selection of the private files to be used
for compilation.
An effort has been made to avoid using glob() in our
BUILD.bazel files. These file lists were made by using
`ls -1` and some regex to add in quotes. We might want
to make a helper script to assist with that, if necessary.
To specify which options we have, the settings in
//bazel/common_config_settings/BUILD.bazel have been
redesigned. They make use of a macro `string_flag_with_values`
that removes the boilerplate. Patchset 36 shows what the
file looks like w/o the macro.
The top level BUILD.bazel file will still need to use
some logic to handle defines, because local_defines is
a list of strings, not a list of labels [4].
Suggested Review Order:
- WORKSPACE.bazel to see the new dependencies on the
emsdk toolchain and bazel_skylib
- bazel/common_config_settings/* to see the few settings
defined (we have more to define, see BUILD.gn and
//gn/skia.gni for ideas)
- BUILD.bazel to see the "skia-core" cc_library rule.
See also "gms" and "tests"
- modules/canvaskit/BUILD.bazel to see the use of
the emscripten "wasm_cc_binary" rule, which depends
on the "skia-core", "gms", and "tests" rule. Note that
it only builds some of the gms as a proof of concept.
- The other BUILD.bazel files. Some of these are not
platform or feature dependent (e.g. pathops). Others
are (e.g. gpu).
- All other files.
[1] https://docs.bazel.build/versions/4.2.1/skylark/config.html#user-defined-build-settings
[2] https://github.com/emscripten-core/emsdk/pull/920
[3] In this CL, that's just the webgl one.
[4] https://docs.bazel.build/versions/main/be/c-cpp.html#cc_library.local_defines
Change-Id: Ieecf9c106d5e3a6ae97d13d66be06b4b3c207089
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458637
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
2021-11-08 20:26:09 +00:00
|
|
|
emsdk_deps()
|
|
|
|
|
|
|
|
|
|
load("@emsdk//:emscripten_deps.bzl", emsdk_emscripten_deps = "emscripten_deps")
|
|
|
|
|
|
2022-04-28 21:32:16 +00:00
|
|
|
emsdk_emscripten_deps(emscripten_version = "3.1.9")
|
[infra] Add initial Bazel rules and files
These rules can be used to build our GMs on WASM+WebGL and
libskia.a with just the CPU backend (and most other features
turned off).
This can be done with the following commands:
- bazel build //modules/canvaskit:gm-bindings-wasm --gpu_backend=gl_backend --with_gl_standard=webgl_standard
- bazel build :skia-core --config clang
This pivots slightly from http://review.skia.org/463517
by using config_settings [1] instead of platforms for
the optional features that we control. This pivot was
suggested in [2]
We have BUILD.bazel files in many of the subdirectories
that specify filegroups for the appropriate files. In
an effort to make //BUILD.bazel more readable, it is
the responsibility of these subfolders to deal with
conditionally including certain .h or .cpp files.
This is done using select statements and config_settings
or platform constraints as necessary.
For example, src/gpu/BUILD.bazel will different private
filegroups for each of the supported gpu backends [3]
and a more-visible filegroup called "srcs" that has
the right selection of the private files to be used
for compilation.
An effort has been made to avoid using glob() in our
BUILD.bazel files. These file lists were made by using
`ls -1` and some regex to add in quotes. We might want
to make a helper script to assist with that, if necessary.
To specify which options we have, the settings in
//bazel/common_config_settings/BUILD.bazel have been
redesigned. They make use of a macro `string_flag_with_values`
that removes the boilerplate. Patchset 36 shows what the
file looks like w/o the macro.
The top level BUILD.bazel file will still need to use
some logic to handle defines, because local_defines is
a list of strings, not a list of labels [4].
Suggested Review Order:
- WORKSPACE.bazel to see the new dependencies on the
emsdk toolchain and bazel_skylib
- bazel/common_config_settings/* to see the few settings
defined (we have more to define, see BUILD.gn and
//gn/skia.gni for ideas)
- BUILD.bazel to see the "skia-core" cc_library rule.
See also "gms" and "tests"
- modules/canvaskit/BUILD.bazel to see the use of
the emscripten "wasm_cc_binary" rule, which depends
on the "skia-core", "gms", and "tests" rule. Note that
it only builds some of the gms as a proof of concept.
- The other BUILD.bazel files. Some of these are not
platform or feature dependent (e.g. pathops). Others
are (e.g. gpu).
- All other files.
[1] https://docs.bazel.build/versions/4.2.1/skylark/config.html#user-defined-build-settings
[2] https://github.com/emscripten-core/emsdk/pull/920
[3] In this CL, that's just the webgl one.
[4] https://docs.bazel.build/versions/main/be/c-cpp.html#cc_library.local_defines
Change-Id: Ieecf9c106d5e3a6ae97d13d66be06b4b3c207089
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458637
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
2021-11-08 20:26:09 +00:00
|
|
|
|
|
|
|
|
http_archive(
|
|
|
|
|
name = "bazel_skylib",
|
|
|
|
|
sha256 = "c6966ec828da198c5d9adbaa94c05e3a1c7f21bd012a0b29ba8ddbccb2c93b0d",
|
|
|
|
|
urls = [
|
|
|
|
|
"https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.1.1/bazel-skylib-1.1.1.tar.gz",
|
2022-01-13 15:19:38 +00:00
|
|
|
"https://github.com/bazelbuild/bazel-skylib/releases/download/1.1.1/bazel-skylib-1.1.1.tar.gz",
|
[infra] Add initial Bazel rules and files
These rules can be used to build our GMs on WASM+WebGL and
libskia.a with just the CPU backend (and most other features
turned off).
This can be done with the following commands:
- bazel build //modules/canvaskit:gm-bindings-wasm --gpu_backend=gl_backend --with_gl_standard=webgl_standard
- bazel build :skia-core --config clang
This pivots slightly from http://review.skia.org/463517
by using config_settings [1] instead of platforms for
the optional features that we control. This pivot was
suggested in [2]
We have BUILD.bazel files in many of the subdirectories
that specify filegroups for the appropriate files. In
an effort to make //BUILD.bazel more readable, it is
the responsibility of these subfolders to deal with
conditionally including certain .h or .cpp files.
This is done using select statements and config_settings
or platform constraints as necessary.
For example, src/gpu/BUILD.bazel will different private
filegroups for each of the supported gpu backends [3]
and a more-visible filegroup called "srcs" that has
the right selection of the private files to be used
for compilation.
An effort has been made to avoid using glob() in our
BUILD.bazel files. These file lists were made by using
`ls -1` and some regex to add in quotes. We might want
to make a helper script to assist with that, if necessary.
To specify which options we have, the settings in
//bazel/common_config_settings/BUILD.bazel have been
redesigned. They make use of a macro `string_flag_with_values`
that removes the boilerplate. Patchset 36 shows what the
file looks like w/o the macro.
The top level BUILD.bazel file will still need to use
some logic to handle defines, because local_defines is
a list of strings, not a list of labels [4].
Suggested Review Order:
- WORKSPACE.bazel to see the new dependencies on the
emsdk toolchain and bazel_skylib
- bazel/common_config_settings/* to see the few settings
defined (we have more to define, see BUILD.gn and
//gn/skia.gni for ideas)
- BUILD.bazel to see the "skia-core" cc_library rule.
See also "gms" and "tests"
- modules/canvaskit/BUILD.bazel to see the use of
the emscripten "wasm_cc_binary" rule, which depends
on the "skia-core", "gms", and "tests" rule. Note that
it only builds some of the gms as a proof of concept.
- The other BUILD.bazel files. Some of these are not
platform or feature dependent (e.g. pathops). Others
are (e.g. gpu).
- All other files.
[1] https://docs.bazel.build/versions/4.2.1/skylark/config.html#user-defined-build-settings
[2] https://github.com/emscripten-core/emsdk/pull/920
[3] In this CL, that's just the webgl one.
[4] https://docs.bazel.build/versions/main/be/c-cpp.html#cc_library.local_defines
Change-Id: Ieecf9c106d5e3a6ae97d13d66be06b4b3c207089
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458637
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Owners-Override: Kevin Lubick <kjlubick@google.com>
2021-11-08 20:26:09 +00:00
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
|
|
|
|
|
|
|
|
|
|
bazel_skylib_workspace()
|
2021-11-16 19:09:44 +00:00
|
|
|
|
2022-03-25 18:59:33 +00:00
|
|
|
http_archive(
|
|
|
|
|
name = "bazel_toolchains",
|
|
|
|
|
sha256 = "e52789d4e89c3e2dc0e3446a9684626a626b6bec3fde787d70bae37c6ebcc47f",
|
|
|
|
|
strip_prefix = "bazel-toolchains-5.1.1",
|
|
|
|
|
urls = [
|
|
|
|
|
"https://github.com/bazelbuild/bazel-toolchains/archive/refs/tags/v5.1.1.tar.gz",
|
|
|
|
|
"https://storage.googleapis.com/skia-world-readable/bazel/e52789d4e89c3e2dc0e3446a9684626a626b6bec3fde787d70bae37c6ebcc47f.tar.gz",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
load("@bazel_toolchains//repositories:repositories.bzl", bazel_toolchains_repositories = "repositories")
|
|
|
|
|
|
|
|
|
|
bazel_toolchains_repositories()
|
|
|
|
|
|
2022-03-25 16:36:17 +00:00
|
|
|
#######################################################################################
|
|
|
|
|
# Python
|
|
|
|
|
#######################################################################################
|
|
|
|
|
|
|
|
|
|
# https://github.com/bazelbuild/rules_python
|
2021-11-16 19:09:44 +00:00
|
|
|
http_archive(
|
|
|
|
|
name = "rules_python",
|
2022-06-30 15:28:23 +00:00
|
|
|
sha256 = "5fa3c738d33acca3b97622a13a741129f67ef43f5fdfcec63b29374cc0574c29",
|
|
|
|
|
strip_prefix = "rules_python-0.9.0",
|
2022-01-13 15:19:38 +00:00
|
|
|
urls = [
|
2022-06-30 15:28:23 +00:00
|
|
|
"https://github.com/bazelbuild/rules_python/archive/refs/tags/0.9.0.tar.gz",
|
|
|
|
|
"https://storage.googleapis.com/skia-world-readable/bazel/5fa3c738d33acca3b97622a13a741129f67ef43f5fdfcec63b29374cc0574c29.tar.gz",
|
|
|
|
|
]
|
2021-11-16 19:09:44 +00:00
|
|
|
)
|
2021-11-23 19:58:20 +00:00
|
|
|
|
2022-03-25 16:36:17 +00:00
|
|
|
# This sets up a hermetic python3, rather than depending on what is installed.
|
|
|
|
|
load("@rules_python//python:repositories.bzl", "python_register_toolchains")
|
|
|
|
|
|
|
|
|
|
python_register_toolchains(
|
|
|
|
|
name = "python3_9",
|
|
|
|
|
# https://github.com/bazelbuild/rules_python/blob/main/python/versions.bzl
|
|
|
|
|
python_version = "3.9",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
load("@python3_9//:defs.bzl", "interpreter")
|
|
|
|
|
load("@rules_python//python:pip.bzl", "pip_install")
|
|
|
|
|
|
|
|
|
|
pip_install(
|
|
|
|
|
name = "py_deps",
|
|
|
|
|
python_interpreter_target = interpreter,
|
|
|
|
|
requirements = "//:requirements.txt",
|
|
|
|
|
)
|
|
|
|
|
|
2021-11-23 19:58:20 +00:00
|
|
|
#######################################################################################
|
|
|
|
|
# Gazelle
|
|
|
|
|
#######################################################################################
|
|
|
|
|
http_archive(
|
|
|
|
|
name = "io_bazel_rules_go",
|
|
|
|
|
sha256 = "2b1641428dff9018f9e85c0384f03ec6c10660d935b750e3fa1492a281a53b0f",
|
|
|
|
|
urls = [
|
|
|
|
|
"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.29.0/rules_go-v0.29.0.zip",
|
|
|
|
|
"https://github.com/bazelbuild/rules_go/releases/download/v0.29.0/rules_go-v0.29.0.zip",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
http_archive(
|
|
|
|
|
name = "bazel_gazelle",
|
|
|
|
|
sha256 = "de69a09dc70417580aabf20a28619bb3ef60d038470c7cf8442fafcf627c21cb",
|
|
|
|
|
urls = [
|
|
|
|
|
"https://mirror.bazel.build/github.com/bazelbuild/bazel-gazelle/releases/download/v0.24.0/bazel-gazelle-v0.24.0.tar.gz",
|
|
|
|
|
"https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.24.0/bazel-gazelle-v0.24.0.tar.gz",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
|
|
|
|
|
load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
|
|
|
|
|
load("//:go_repositories.bzl", "go_repositories")
|
|
|
|
|
|
|
|
|
|
# gazelle:repository_macro go_repositories.bzl%go_repositories
|
|
|
|
|
go_repositories()
|
|
|
|
|
|
|
|
|
|
go_rules_dependencies()
|
|
|
|
|
|
|
|
|
|
go_register_toolchains(version = "1.17.2")
|
|
|
|
|
|
|
|
|
|
gazelle_dependencies(go_repository_default_config = "//:WORKSPACE.bazel")
|
2022-02-23 14:02:11 +00:00
|
|
|
|
2022-03-03 15:42:57 +00:00
|
|
|
# Because the skia infra repo has a dependency on google.golang.org/grpc (aka
|
|
|
|
|
# @org_golang_google_grpc), we need to have this library available to build protos.
|
|
|
|
|
# https://github.com/bazelbuild/rules_go#protobuf-and-grpc
|
|
|
|
|
http_archive(
|
|
|
|
|
name = "com_google_protobuf",
|
|
|
|
|
sha256 = "d0f5f605d0d656007ce6c8b5a82df3037e1d8fe8b121ed42e536f569dec16113",
|
|
|
|
|
strip_prefix = "protobuf-3.14.0",
|
|
|
|
|
urls = [
|
|
|
|
|
"https://mirror.bazel.build/github.com/protocolbuffers/protobuf/archive/v3.14.0.tar.gz",
|
|
|
|
|
"https://github.com/protocolbuffers/protobuf/archive/v3.14.0.tar.gz",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
|
|
|
|
|
|
|
|
|
|
protobuf_deps()
|
|
|
|
|
|
2022-02-23 14:02:11 +00:00
|
|
|
###################################################
|
|
|
|
|
# JavaScript / TypeScript rules and dependencies. #
|
|
|
|
|
###################################################
|
|
|
|
|
|
|
|
|
|
# The npm_install rule runs anytime the package.json or package-lock.json file changes. It also
|
|
|
|
|
# extracts any Bazel rules distributed in an npm package.
|
|
|
|
|
load("@build_bazel_rules_nodejs//:index.bzl", "npm_install")
|
|
|
|
|
|
|
|
|
|
# Manages the node_modules directory.
|
|
|
|
|
npm_install(
|
|
|
|
|
name = "npm",
|
|
|
|
|
package_json = "//:package.json",
|
|
|
|
|
package_lock_json = "//:package-lock.json",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
# io_bazel_rules_webtesting allows us to download browsers in a hermetic, repeatable way. This
|
|
|
|
|
# currently includes Chromium and Firefox. Note that the version on this does not necessarily
|
|
|
|
|
# match the version below of the browsers-X.Y.Z below that is available.
|
|
|
|
|
http_archive(
|
|
|
|
|
name = "io_bazel_rules_webtesting",
|
|
|
|
|
sha256 = "e9abb7658b6a129740c0b3ef6f5a2370864e102a5ba5ffca2cea565829ed825a",
|
|
|
|
|
urls = [
|
|
|
|
|
"https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.5/rules_webtesting.tar.gz",
|
|
|
|
|
"https://storage.googleapis.com/skia-world-readable/bazel/e9abb7658b6a129740c0b3ef6f5a2370864e102a5ba5ffca2cea565829ed825a.tar.gz",
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
# https://github.com/bazelbuild/rules_webtesting/blob/e9cf17123068b1123c68219edf9b274bf057b9cc/web/versioned/browsers-0.3.3.bzl
|
|
|
|
|
load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.3.bzl", "browser_repositories")
|
|
|
|
|
|
|
|
|
|
browser_repositories(
|
|
|
|
|
chromium = True,
|
|
|
|
|
firefox = True,
|
|
|
|
|
)
|
2022-03-21 17:06:32 +00:00
|
|
|
|
|
|
|
|
###################################################
|
|
|
|
|
# External C++ deps with Bazel support #
|
|
|
|
|
###################################################
|
2022-04-29 12:23:25 +00:00
|
|
|
# https://bazel.build/reference/be/workspace#local_repository
|
2022-03-21 17:06:32 +00:00
|
|
|
local_repository(
|
|
|
|
|
name = "abseil_cpp",
|
|
|
|
|
path = "third_party/externals/abseil-cpp",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
local_repository(
|
|
|
|
|
name = "spirv_tools",
|
|
|
|
|
path = "third_party/externals/spirv-tools",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
local_repository(
|
|
|
|
|
# This name is important because spirv_tools expects @spirv_headers to exist by that name.
|
|
|
|
|
name = "spirv_headers",
|
|
|
|
|
path = "third_party/externals/spirv-headers",
|
|
|
|
|
)
|
2022-04-29 12:23:25 +00:00
|
|
|
|
2022-05-16 12:59:45 +00:00
|
|
|
###############################################################################
|
|
|
|
|
# External C++ deps with NO Bazel support #
|
|
|
|
|
# In this case, we need to supply a BUILD file which exposes targets/files #
|
|
|
|
|
# we need. If these deps depend on other deps (e.g. @dawn -> @spirv_tools), #
|
|
|
|
|
# then we need to specify those here as well. The workspace_file_content is #
|
|
|
|
|
# generally ignored; external repos (i.e. the ones starting with @) will be #
|
|
|
|
|
# resolved with Skia's version of those repos, which is how Bazel avoids #
|
|
|
|
|
# multiple versions of the same project being compiled together. #
|
|
|
|
|
###############################################################################
|
2022-04-29 12:23:25 +00:00
|
|
|
# https://bazel.build/reference/be/workspace#new_local_repository
|
|
|
|
|
new_local_repository(
|
2022-05-31 20:22:31 +00:00
|
|
|
name = "dawn",
|
|
|
|
|
build_file = "bazel/external/dawn/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/dawn",
|
2022-05-16 12:59:45 +00:00
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-06-01 18:45:18 +00:00
|
|
|
new_local_repository(
|
|
|
|
|
name = "dng_sdk",
|
|
|
|
|
build_file = "bazel/external/dng_sdk/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/dng_sdk",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-06-27 14:07:26 +00:00
|
|
|
new_local_repository(
|
|
|
|
|
name = "expat",
|
|
|
|
|
build_file = "bazel/external/expat/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/expat",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-06-01 18:45:18 +00:00
|
|
|
new_local_repository(
|
|
|
|
|
name = "libjpeg_turbo",
|
|
|
|
|
build_file = "bazel/external/libjpeg_turbo/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/libjpeg-turbo",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-05-16 12:59:45 +00:00
|
|
|
new_local_repository(
|
2022-05-31 20:22:31 +00:00
|
|
|
name = "libpng",
|
|
|
|
|
build_file = "bazel/external/libpng/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/libpng",
|
2022-05-16 12:59:45 +00:00
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-06-01 18:45:18 +00:00
|
|
|
new_local_repository(
|
|
|
|
|
name = "libwebp",
|
|
|
|
|
build_file = "bazel/external/libwebp/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/libwebp",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-06-14 20:42:28 +00:00
|
|
|
new_local_repository(
|
|
|
|
|
name = "perfetto",
|
|
|
|
|
build_file = "bazel/external/perfetto/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/perfetto",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-06-01 18:45:18 +00:00
|
|
|
new_local_repository(
|
|
|
|
|
name = "piex",
|
|
|
|
|
build_file = "bazel/external/piex/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/piex",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-05-16 12:59:45 +00:00
|
|
|
new_local_repository(
|
|
|
|
|
name = "vulkan_headers",
|
2022-05-17 11:47:44 +00:00
|
|
|
build_file = "bazel/external/vulkan_headers/BUILD.bazel",
|
2022-05-16 12:59:45 +00:00
|
|
|
path = "third_party/externals/vulkan-headers",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
new_local_repository(
|
|
|
|
|
name = "vulkan_tools",
|
2022-05-17 11:47:44 +00:00
|
|
|
build_file = "bazel/external/vulkan_tools/BUILD.bazel",
|
2022-05-16 12:59:45 +00:00
|
|
|
path = "third_party/externals/vulkan-tools",
|
|
|
|
|
workspace_file_content = "",
|
2022-04-29 12:23:25 +00:00
|
|
|
)
|
2022-05-31 20:22:31 +00:00
|
|
|
|
|
|
|
|
new_local_repository(
|
|
|
|
|
name = "vulkanmemoryallocator",
|
|
|
|
|
build_file = "bazel/external/vulkanmemoryallocator/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/vulkanmemoryallocator",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-06-01 18:45:18 +00:00
|
|
|
new_local_repository(
|
|
|
|
|
name = "wuffs",
|
|
|
|
|
build_file = "bazel/external/wuffs/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/wuffs",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
|
|
|
|
|
2022-05-31 20:22:31 +00:00
|
|
|
new_local_repository(
|
|
|
|
|
# Some other dependency downloads zlib but with their own rules
|
|
|
|
|
name = "zlib_skia",
|
|
|
|
|
build_file = "bazel/external/zlib/BUILD.bazel",
|
|
|
|
|
path = "third_party/externals/zlib",
|
|
|
|
|
workspace_file_content = "",
|
|
|
|
|
)
|
