skia2/tests/sksl/errors/OverflowUintLiteral.glsl

### Compilation failed:

error: 4: integer is out of range for type 'uint': -1
error: 6: integer is too large: 4294967296
error: 8: integer is out of range for type 'ushort': -1
error: 9: integer is out of range for type 'ushort': 65536
error: 11: integer is out of range for type 'uint': 4294967296
error: 12: integer is out of range for type 'ushort': 65536
6 errors
Detect and report numeric overflows in the SkSL parser. Previously, some types of overflow were detected, but most would assert or silently generate invalid code. Now, the parser will properly report an error if it encounters any integer that exceeds UINT_MAX or any float that exceeds FLT_MAX. This fixes test OverflowUintLiteral.sksl. Added a test for floats as well, OverflowFloatLiteral.sksl. OverflowIntLiteral.sksl does not fail yet, because its values are larger than INT_MAX, not UINT_MAX. These are legal from the perspective of the parser. This must be caught later at IR generation time. Change-Id: Ia5a904d01427cdc9f2ab5f4174154418737835e6 Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/347176 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2020-12-23 23:58:43 +00:00			`### Compilation failed:`
Add unit tests for overflowing int and uint literal limits. At present, we do not report any error; the values wrap silently. Change-Id: I8c435cfdd81f6c2e5fd87e9c39c708138bf4ec82 Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333676 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> 2020-11-10 19:17:42 +00:00
Reject scalar casts of literals to types that can't hold them. With this change, we no longer have any SkSL tests which are able to make a Literal integer that overflows its type. Literal::MakeInt now asserts that its value is within bounds. I look forward to the fuzzer's inevitable attempts to trigger these assertions. Change-Id: I7b15e862caaf65984d33f5d72d2c1de816d1d292 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464124 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> 2021-10-27 18:14:53 +00:00			`error: 4: integer is out of range for type 'uint': -1`
			`error: 6: integer is too large: 4294967296`
			`error: 8: integer is out of range for type 'ushort': -1`
			`error: 9: integer is out of range for type 'ushort': 65536`
Report int-literal overflow via cast-from-float. The fuzzer discovered that SkSL could create an out-of-range int literal by casting from a floating point literal. We were only doing range checks when the starting literal was an integer. Since we now assert when an out-of-range int literal is created (as of http://review.skia.org/464124), the fuzzer can detect this error. Change-Id: Ie66f60ddbe7b4fbe5b648c17292c59a4ba079716 Bug: oss-fuzz:40456 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/465385 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> 2021-10-29 14:21:50 +00:00			`error: 11: integer is out of range for type 'uint': 4294967296`
			`error: 12: integer is out of range for type 'ushort': 65536`
			`6 errors`