AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
059d34594e
skia2/tests/sksl/errors/ReservedNameAttribute.glsl

5 lines
74 B
Plaintext
Raw Normal View History

Added four more reserved words to SkSL. We now detect attribute, varying, precision and invariant as reserved. Change-Id: I8c90655a70b1bad31bf6143c3fdcb2ce582320b1 Bug: skia:12484 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459479 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-10-14 15:42:33 +00:00
### Compilation failed:
Add a distinct error message for reserved words. After reporting the error, we convert the reserved word to an identifier as this led to the best error reporting. (This avoids double error reporting or strange cascading errors.) Change-Id: I67209bc342fe794287baeaaaf34fa77afd4ac26b Bug: skia:12560 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462096 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-10-21 13:48:08 +00:00
error: 1: 'attribute' is a reserved word
Added four more reserved words to SkSL. We now detect attribute, varying, precision and invariant as reserved. Change-Id: I8c90655a70b1bad31bf6143c3fdcb2ce582320b1 Bug: skia:12484 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459479 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-10-14 15:42:33 +00:00
1 error
Reference in New Issue Copy Permalink