AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
059d34594e
skia2/tests/sksl/errors/ReservedNameSamplerCube.glsl

5 lines
76 B
Plaintext
Raw Normal View History

Fix up samplerCube/textureCube for ES2 conformance. `samplerCube` is a type which we don't support at all. It has been added to the reserved-word list. `textureCube` was in our list of built-in types, but was not actually used in any way; it wasn't actually added to the root or private symbol tables, and was totally unreferenced by the code. It's been deleted. Change-Id: I4f79ce5d40ac6ebdb2a7067fa60cc79e316b01b6 Bug: skia:12484 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459123 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-10-13 21:15:33 +00:00
### Compilation failed:
Add a distinct error message for reserved words. After reporting the error, we convert the reserved word to an identifier as this led to the best error reporting. (This avoids double error reporting or strange cascading errors.) Change-Id: I67209bc342fe794287baeaaaf34fa77afd4ac26b Bug: skia:12560 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/462096 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-10-21 13:48:08 +00:00
error: 1: 'samplerCube' is a reserved word
Fix up samplerCube/textureCube for ES2 conformance. `samplerCube` is a type which we don't support at all. It has been added to the reserved-word list. `textureCube` was in our list of built-in types, but was not actually used in any way; it wasn't actually added to the root or private symbol tables, and was totally unreferenced by the code. It's been deleted. Change-Id: I4f79ce5d40ac6ebdb2a7067fa60cc79e316b01b6 Bug: skia:12484 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459123 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-10-13 21:15:33 +00:00
1 error
Reference in New Issue Copy Permalink