This website requires JavaScript.
ReeceSX
Explore
Aurora
Register
Sign In
AuroraMiddleware
/
skia2
Watch
1
Star
0
Fork
0
You've already forked skia2
Code
Issues
Pull Requests
Projects
Releases
Wiki
Activity
059d34594e
skia2
/
tests
/
sksl
/
spirv
/
Ossfuzz44096.asm.frag
5 lines
90 B
GLSL
Raw
Normal View
History
Unescape
Escape
Fix fuzzer-discovered error with sk_SecondaryFragColor in SPIR-V. sk_SecondaryFragColor corresponds to an ES2-only concept (gl_SecondaryFragColorEXT) and does not have any SPIR-V equivalent. Two fixes were needed: - sk_SecondaryFragColor shouldn't be in SPIR-V code at all. Report it as an error when it appears. - We don't stop compilation when this error is reported, so we need to fix up the assertion that the fuzzer initially discovered. Specifically, the fuzzer found that the `sk_SecondaryFragColor` variable never got a SPIR-V ID assigned to it in fVariableMap, so the compiler would assert when assembling an expression containing that variable. Now, we make sure to populate fVariableMap with an (unused) ID in `writeGlobalVar` to avoid this crash. Change-Id: Ib86919dfc9a325b2b82a7f4b2054b747dad7c32f Bug: oss-fuzz:44096 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/501976 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-01-28 22:15:44 +00:00
### Compilation failed:
Fixed a past-the-end error location in SPIR-V output The error was being reported at the position of the var declaration, rather than the position of the reference. And since the declaration was in a module, its position was both incorrect (with respect to the program source) and could be past the end. Change-Id: I443b9fbbe016c43b93d457abfefd17025e451d8a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/521522 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-03-16 21:15:53 +00:00
error
:
1
:
sk_SecondaryFragColor
is
not
allowed
in
SPIR
-
V
Fix fuzzer-discovered error with sk_SecondaryFragColor in SPIR-V. sk_SecondaryFragColor corresponds to an ES2-only concept (gl_SecondaryFragColorEXT) and does not have any SPIR-V equivalent. Two fixes were needed: - sk_SecondaryFragColor shouldn't be in SPIR-V code at all. Report it as an error when it appears. - We don't stop compilation when this error is reported, so we need to fix up the assertion that the fuzzer initially discovered. Specifically, the fuzzer found that the `sk_SecondaryFragColor` variable never got a SPIR-V ID assigned to it in fVariableMap, so the compiler would assert when assembling an expression containing that variable. Now, we make sure to populate fVariableMap with an (unused) ID in `writeGlobalVar` to avoid this crash. Change-Id: Ib86919dfc9a325b2b82a7f4b2054b747dad7c32f Bug: oss-fuzz:44096 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/501976 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-01-28 22:15:44 +00:00
1
error
Reference in New Issue
Copy Permalink