AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
0857bef61b
skia2/gn/skia.gni

150 lines
5.2 KiB
Plaintext
Raw Normal View History

GN/ICU cleanup For targets that depend on ICU, only define if `skia_use_icu` is set. Move declare_args/skia_use_icu into skia.gni. Other variables that need to work like that can move there later. icu/BUILD.gn defines SK_USING_THIRD_PARTY_ICU if needed. SkShaper_harfbuzz.cpp SkPDFSubsetFont.cpp respects SK_USING_THIRD_PARTY_ICU when calling SkLoadICU(). sfntly/BUILD.gn, harfbuzz/BUILD.gn, icu/icu.gni uses $_src variable to reduce verbosity. icu/icu.gni adds more headersto sources. Change-Id: I9e000b9b19902d9f5c0c64e989bf42466aa8a299 Reviewed-on: https://skia-review.googlesource.com/c/189304 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
2019-02-04 20:36:31 +00:00
# Copyright 2019 Google LLC.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
[canvaskit] JS API in place for shaped text Depends on https://skia-review.googlesource.com/c/skia/+/186870 It's optional at build time, which is good given that it adds about 2MB of uncompressed size (from 4.3 MB to 6.4 MB) Bug: skia: Change-Id: I5f54ad628b735c3bc880e917394fb27d16849ebe Reviewed-on: https://skia-review.googlesource.com/c/187924 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-02-22 15:04:06 +00:00
if (!defined(is_skia_standalone)) {
is_skia_standalone = false
}
SKQP Build for Fuchsia SDK Change-Id: I2619784eca0f7a4dd66f2db0104cb746d9266b4e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244369 Commit-Queue: John Rosasco <rosasco@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-25 21:14:35 +00:00
is_skia_dev_build = is_skia_standalone && !is_official_build
gn: try again to fix fuchsia Change-Id: Ie5e437fa08fb85c764703d8e292e696a568f5dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239117 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-09-04 14:05:33 +00:00
GN/ICU cleanup For targets that depend on ICU, only define if `skia_use_icu` is set. Move declare_args/skia_use_icu into skia.gni. Other variables that need to work like that can move there later. icu/BUILD.gn defines SK_USING_THIRD_PARTY_ICU if needed. SkShaper_harfbuzz.cpp SkPDFSubsetFont.cpp respects SK_USING_THIRD_PARTY_ICU when calling SkLoadICU(). sfntly/BUILD.gn, harfbuzz/BUILD.gn, icu/icu.gni uses $_src variable to reduce verbosity. icu/icu.gni adds more headersto sources. Change-Id: I9e000b9b19902d9f5c0c64e989bf42466aa8a299 Reviewed-on: https://skia-review.googlesource.com/c/189304 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
2019-02-04 20:36:31 +00:00
declare_args() {
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_android_serial = ""
skia_compile_processors = false
Allows Skia users to disable use of API_AVAILABLE in the Metal backend. On certain older versions of the Clang toolchain, the use of the API_AVAILABLE macro on symbols in C++ translation units causes the visibility of those symbols to me treated as default instead of the hidden. This causes internal symbols to be exposed from release dylibs. This mechanism allows users of the toolchains that have not been updated to the latest versions to disable the use of the macro in release configurations. Change-Id: I656361770c2011cff4c1b252761b5d0f3d89edc5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277775 Auto-Submit: Chinmay Garde <chinmaygarde@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-03-18 21:37:23 +00:00
skia_enable_api_available_macro = true
Reland "Move SkFrontBufferedStream into Android-only dir" This reverts commit b25f30348bfee972b509fd4a13a0de99e89caa6a. Bug: skia:10154 Original message: > Add client_utils for code that is specifically for a single client. > Move SkFrontBufferedStream into its android/ subdir. Rename the class > to android::skia::FrontBufferedStream. Temporarily leave in > SkFrontBufferedStream until Android updates to the new API. > > Add a new optional target for client_utils/android. It is built in dev > builds for testing, and when building for the Android framework. Deliberately do not include client_utils in Google3, since the whole point is to only include where necessary. Change-Id: I48938c56aabb98e1ed820240d43ffcd0fdce7956 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285104 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-04-24 17:00:48 +00:00
skia_enable_android_utils = is_skia_dev_build
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_enable_ccpr = true
skia_enable_discrete_gpu = true
skia_enable_flutter_defines = false
skia_enable_fontmgr_empty = false
skia_enable_fontmgr_fuchsia = is_fuchsia
skia_enable_fontmgr_win = is_win
skia_enable_fontmgr_win_gdi = is_win
[canvaskit] JS API in place for shaped text Depends on https://skia-review.googlesource.com/c/skia/+/186870 It's optional at build time, which is good given that it adds about 2MB of uncompressed size (from 4.3 MB to 6.4 MB) Bug: skia: Change-Id: I5f54ad628b735c3bc880e917394fb27d16849ebe Reviewed-on: https://skia-review.googlesource.com/c/187924 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-02-22 15:04:06 +00:00
skia_enable_gpu = true
Cache ICU break iterators in SkUnicode_icu Gate this behind an ifdef that can be disabled in environments where the ICU ubrk_safeClone API is not available. Change-Id: Ia1a3f677271622f2b7ae478b4d1ce76c74eed057 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/352876 Reviewed-by: Julia Lavrova <jlavrova@google.com> Commit-Queue: Jason Simmons <jsimmons@google.com>
2021-01-11 23:52:03 +00:00
skia_enable_icu_ubrk_safeclone = false
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_enable_pdf = true
Fix build when (is_ios && !skia_enable_skottie) Bug: skia:9726 Change-Id: I2ad05e28f8699fc7c5159145cc59065fc8bd5b93 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/265520 Reviewed-by: Hal Canary <halcanary@skia.org> Commit-Queue: Hal Canary <halcanary@skia.org> Auto-Submit: Hal Canary <halcanary@google.com>
2020-01-21 17:39:20 +00:00
skia_enable_skottie = !(is_win && is_component_build)
Reland "[skrive] Initial parser plumbing" This reverts commit e923ae1be4b5c9e728409f0d73ba8f70d5fd3cee. Original change's description: > Revert "[skrive] Initial parser plumbing" > > This reverts commit 00a96f2c994c0eb8f9706cf50e849fa8bcab5c66. > > Reason for revert: breaking wuffs > > Original change's description: > > [skrive] Initial parser plumbing > > > > TBR= > > Change-Id: If96d81840b5bb3bc8c6e26f8aacca4d9dd8896e3 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293677 > > Reviewed-by: Florin Malita <fmalita@chromium.org> > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > TBR=fmalita@chromium.org,reed@google.com > > Change-Id: I63258d560cc8ee8d069e6417d987342a74a3f0c2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295001 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Florin Malita <fmalita@chromium.org> TBR=fmalita@chromium.org,reed@google.com # Not skipping CQ checks because this is a reland. Change-Id: I0a671bb7476ee92c365fbea1f156c73c6954fe40 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295003 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
2020-06-08 16:03:48 +00:00
skia_enable_skrive = true
Revert "remove sksl interpreter guards" This reverts commit 7f1117e88611a9df157864884bb55040aa65867d. Reason for revert: Seems like Clang gets stuck allocating registers on ARM, [2477/38027] CXX obj/skia/skia/SkSLByteCode.o FAILED: obj/skia/skia/SkSLByteCode.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) fatal error: error in backend: Error while trying to spill LR from class GPR: Cannot scavenge register without an emergency spill slot! PLEASE submit a bug report to https://crbug.com and run tools/clang/scripts/process_crashreports.py (only works inside Google) which will upload a report and include the crash backtrace, preprocessed source, and associated run script. Stack dump: 0. Program arguments: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/skia/ski...(too long) Original change's description: > remove sksl interpreter guards > > This is only used by particles, benchmarks, and tests, > and should be swept away by dead code elimination otherwise. > > Change-Id: I10462d6ae0a08dd8219fc49325160ec6790632af > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/311759 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,brianosman@google.com Change-Id: I1b6370d39285210267425f090235a4d80aebe4fa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312034 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-08-20 00:41:00 +00:00
skia_enable_sksl_interpreter = is_skia_dev_build
Reland "move conditions for JIT into SkVM.h" This is a reland of 166cd52cee64fb59a1c8daad379feca2e18d723a with iOS simulator builds disabled. Original change's description: > move conditions for JIT into SkVM.h > > This makes it easier to keep in sync with the implementation in > SkVM.cpp, and it's easier to handle here once than in each build system. > > Change-Id: I429f90cfc16f35a0d7e0b0fde176bc013aa7db18 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310263 > Commit-Queue: Mike Klein <mtklein@google.com> > Commit-Queue: Herb Derby <herb@google.com> > Auto-Submit: Mike Klein <mtklein@google.com> > Reviewed-by: Herb Derby <herb@google.com> Change-Id: I82837c3d959769f26197f2402d3b911e71a35675 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310465 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-08-14 12:36:54 +00:00
skia_enable_skvm_jit_when_possible = is_skia_dev_build
Reland "[svg] Relocate out of experimental" Move the SVG rendering code to modules/svg, and componentize. Also split into include/src/utils. As external clients still reference the old header locations, introduce temporary forwarding headers to facilitate the migration. This reverts commit d6cf56fd3400f16aed443807390340c8efdcce1c. TBR= Change-Id: Ibadd7c8dc0464ec0c27841530ade0c2098305d20 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/327344 Commit-Queue: Florin Malita <fmalita@google.com> Reviewed-by: Florin Malita <fmalita@google.com>
2020-10-15 22:10:29 +00:00
skia_enable_svg = true
[canvaskit] JS API in place for shaped text Depends on https://skia-review.googlesource.com/c/skia/+/186870 It's optional at build time, which is good given that it adds about 2MB of uncompressed size (from 4.3 MB to 6.4 MB) Bug: skia: Change-Id: I5f54ad628b735c3bc880e917394fb27d16849ebe Reviewed-on: https://skia-review.googlesource.com/c/187924 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-02-22 15:04:06 +00:00
skia_enable_tools = is_skia_dev_build
Reland "Create D3D device and queue" This is a reland of 29dc430f43e1b27a26d2413ca427109f616539db Original change's description: > Create D3D device and queue > > Bug: skia:9935 > Change-Id: Ib6548f413ca3a8befb553d2d47354b400c9162b9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272520 > Commit-Queue: Jim Van Verth <jvanverth@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> Bug: skia:9935 Change-Id: I1c8797e09cdeb3694ea7f47b2236ab7d91d9519f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272996 Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2020-02-24 16:36:15 +00:00
skia_enable_gpu_debug_layers = is_skia_dev_build && is_debug
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_generate_workarounds = false
skia_include_multiframe_procs = false
skia_lex = false
Replace third_party/gif: Preflight changes Something is breaking client code in unexpected ways. Let's try this piecemeal. - skia_libgifcodec_path gn var. Default is third_party/externals/libgifcodec. Anfroid framework uses third_party/libgifcodec. - skia_use_libgifcodec gn var; defaults to !skia_use_wuffs. Allow disabling both codecs. - GN template("optional"): add public_include_dirs, similar to public_defines. - SK_USE_LIBGIFCODEC, ifdef for skia_use_libgifcodec. - SkCodec.cpp: use SK_USE_LIBGIFCODEC Original CL: https://review.skia.org/254582 Cq-Include-Trybots: luci.skia.skia.primary:Build-Debian9-Clang-x86-devrel-Android_SKQP Bug: skia:9654 Change-Id: I70561f5f945656065e4b318d5fff505961fb0b6b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255578 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-11-20 21:01:31 +00:00
skia_libgifcodec_path = "third_party/externals/libgifcodec"
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
skia_pdf_subset_harfbuzz =
false # TODO: set skia_pdf_subset_harfbuzz to skia_use_harfbuzz.
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_qt_path = getenv("QT_PATH")
skia_skqp_global_error_tolerance = 0
skia_tools_require_resources = false
SKQP Build for Fuchsia SDK Change-Id: I2619784eca0f7a4dd66f2db0104cb746d9266b4e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244369 Commit-Queue: John Rosasco <rosasco@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-25 21:14:35 +00:00
skia_update_fuchsia_sdk = false
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_use_angle = false
skia_use_dawn = false
Start adding D3D backend Bug: skia: Change-Id: Id24ed653adb80fe9b2ad597a34e459eb91ca53ec Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271057 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-02-18 19:34:38 +00:00
skia_use_direct3d = false
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_use_egl = false
skia_use_expat = true
skia_use_experimental_xform = false
skia_use_ffmpeg = false
skia_use_fixed_gamma_text = is_android
skia_use_fontconfig = is_linux
Regularize SkFontMgr for CoreText build. Move SkFontHost_mac.cpp into an 'optional' like the other fontmgr build rules. This allows building with other fontmgrs on Mac and makes the lib dependencies explicit. In the future this helps with splitting the out the default factory. Change-Id: Iecef9e428acb69f89b54afa00b4e779f5858c61a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294076 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-04 03:29:43 +00:00
skia_use_fonthost_mac = is_mac || is_ios
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_use_freetype = is_android || is_fuchsia || is_linux
Allow system harfbuzz. This should allow shaper to run on the no-deps bot. Change-Id: I2515875d4e9b428681c20877630b904c3229ecc5 Reviewed-on: https://skia-review.googlesource.com/c/194420 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-22 20:55:39 +00:00
skia_use_harfbuzz = true
Reland fully delineate GL usage w/ skia_use_gl. Change-Id: I90f40467be145537cc08461fd3805606432f0cfd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254240 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: John Rosasco <rosasco@google.com> Auto-Submit: John Rosasco <rosasco@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-11-08 21:18:15 +00:00
skia_use_gl = !is_fuchsia
Enable skia_use_icu for iOS Bug: skia:9977 Change-Id: I0bf7fe972efe48c5c2b0fd8eabab1d6ff249faee Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275959 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Julia Lavrova <jlavrova@google.com> Commit-Queue: Julia Lavrova <jlavrova@google.com>
2020-03-09 13:59:56 +00:00
skia_use_icu = !is_fuchsia
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_use_libheif = is_skia_dev_build
Reland "Split building encoding from decoding" This reverts commit 9d4b788807fcca010399c0987aed41b3af5d938f. Copyright issue has been fixed in https://skia-review.googlesource.com/c/skia/+/275998. Original description: Bug: skia:9756 In CanvasKit, a large part of the binary is for encoding. Clients would be happier with a smaller binary and no webp/jpeg encoding. Make this an option by splitting up the GN arguments. Split SK_HAS_WEBP_LIBRARY into SK_CODEC_DECODES_WEBP (to match the existing SK_CODEC_DECODES_RAW) and SK_ENCODE_WEBP. Same for JPEG and PNG. Update CanvasKit compile script to disable webp and jpeg encoding. Update debugger compile script to disable all encoding. Change IsPng signature to match other SkCodecs. TBR=djsollen@google.com Change-Id: Ic847bae0154e0a2922100b3f2ee14a077ee5635a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276007 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-03-09 18:23:30 +00:00
skia_use_libjpeg_turbo_decode = true
skia_use_libjpeg_turbo_encode = true
skia_use_libpng_decode = true
skia_use_libpng_encode = true
skia_use_libwebp_decode = true
skia_use_libwebp_encode = true
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_use_lua = is_skia_dev_build && !is_ios
skia_use_metal = false
Add platform image encoder for using NDK APIs Bug: skia:10369 Add SkEncodeImageWithNDK, mirroring the CG and WIC versions, for encoding with the NDK APIs added to R. Rename SK_ENABLE_NDK_DECODING to SK_ENABLE_NDK_IMAGES and use it for both encoding and decoding. Move code for converting to/from NDK types into a common location. Update encode_platform.cpp to use NDK encoding APIs when available and to use both types of webp (lossy and lossless). Add tests specifically for the new implementation. Update NdkDecodeTest to use ToolUtils::equal_pixels for comparing pixels. Change-Id: Ic62f89af27372ccce90b8e028e01c388a135a68c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308800 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-05 20:51:10 +00:00
skia_use_ndk_images = is_android && defined(ndk_api) && ndk_api >= 30
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_use_opencl = false
skia_use_piex = !is_win
SFML [1] backed for SkAudioPlayer/Linux For now this relies on system libs and requires explicit opt-in (skia_use_sfml=true). [1] https://www.sfml-dev.org/ TBR= Change-Id: Iff89efdb4494f79530d0d41dee80ff38d4e75671 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310065 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Florin Malita <fmalita@google.com>
2020-08-13 18:12:10 +00:00
skia_use_sfml = false
[canvaskit] Remove fringe EGL dependency. This removes about 5 kb of wasm code size (2 kb gzipped), 20 kb of js code size (4kb gzipped). I think I can remove getproc (which is a somewhat large function made up of a lot of string data) with some clever adjustments of macros in a follow-on CL. Change-Id: If3a4b30681e13abddea8e84d62297e90316ed7cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/311817 Reviewed-by: Chris Dalton <csmartdalton@google.com>
2020-08-19 18:30:58 +00:00
skia_use_webgl = false
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_use_wuffs = false
skia_use_x11 = is_linux
skia_use_xps = true
skia_use_zlib = true
add vtune support back I spent a little time working on adding the --dylib JIT mode to Windows where we'd shell out to Clang to make a .dll, but then I remembered this VTune JIT API. That dylib approach is nice for working with a wide range of tools (perf, Instruments, gdb, etc.), but when your only need is Vtune, this API is actually the best option. You get your profiler aware of your JIT'd code with way less overhead than the shell-then-dlopen approach. If we need to expand to more tools I'll go make the dylib mode work, but I think this is good enough to make me happy on Windows for now. This should look really similar to https://skia-review.googlesource.com/c/skia/+/255124. Change-Id: I9e283cdf9bdfeb11c647a2315a7916dc68ef73c7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/301935 Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Herb Derby <herb@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Herb Derby <herb@google.com>
2020-07-10 17:56:07 +00:00
skia_vtune_path = ""
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
if (is_ios) {
skia_ios_identity = ".*Google.*"
skia_ios_profile = "Google Development"
}
if (is_mac) {
skia_gl_standard = "gl"
} else if (is_ios) {
skia_gl_standard = "gles"
} else {
skia_gl_standard = ""
}
if (is_android) {
skia_use_vulkan = defined(ndk_api) && ndk_api >= 24
} else if (is_fuchsia) {
SKQP Build for Fuchsia SDK Change-Id: I2619784eca0f7a4dd66f2db0104cb746d9266b4e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244369 Commit-Queue: John Rosasco <rosasco@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-25 21:14:35 +00:00
skia_use_vulkan = true
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
} else {
Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" Updated to use sentinel GL context even when GL backend is not built. This reverts commit 1171d314efc7e131b039c94126d26575cfb9e70c. Change-Id: Ia94bbe4865ddd4e898446c13886877c539f0eb0b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277976 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-03-19 19:54:28 +00:00
skia_use_vulkan = false
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
}
[fuzz] Add libfuzzer binaries to BUILD.gn For the longest time, the libfuzzer binaries used by oss-fuzz were just hacked onto the BUILD.gn file. This removes that patch and makes them buildable from Skia proper. After this, there should not be any modifications oss-fuzz needs to do to a Skia checkout before it builds and runs. Of note, oss-fuzz will define skia_use_libfuzzer_defaults to be false so it can control those flags with more finesse (e.g. fuzz with ASAN, fuzz with hong fuzz instead of libfuzzer). I added on skia_use_libfuzzer_defaults so that a normal developer gets something that works by default. Bug: skia:10713 Change-Id: I024f5805060cba8f8560e1c2569b9309fb49a564 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316536 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-09-15 14:05:41 +00:00
unbreak Build-Debian10-Clang-x86-Debug fuzzers can't build there, but I don't really care. Cq-Include-Trybots: luci.skia.skia.primary:Build-Debian10-Clang-x86-Debug Change-Id: Icb729e8802ccd3cdd1e1384d006d46bd7dc2cd08 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317150 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-09-15 16:01:45 +00:00
skia_build_fuzzers = is_clang && is_linux && target_cpu == "x64"
[fuzz] Add libfuzzer binaries to BUILD.gn For the longest time, the libfuzzer binaries used by oss-fuzz were just hacked onto the BUILD.gn file. This removes that patch and makes them buildable from Skia proper. After this, there should not be any modifications oss-fuzz needs to do to a Skia checkout before it builds and runs. Of note, oss-fuzz will define skia_use_libfuzzer_defaults to be false so it can control those flags with more finesse (e.g. fuzz with ASAN, fuzz with hong fuzz instead of libfuzzer). I added on skia_use_libfuzzer_defaults so that a normal developer gets something that works by default. Bug: skia:10713 Change-Id: I024f5805060cba8f8560e1c2569b9309fb49a564 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316536 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-09-15 14:05:41 +00:00
skia_use_libfuzzer_defaults = true
GN/ICU cleanup For targets that depend on ICU, only define if `skia_use_icu` is set. Move declare_args/skia_use_icu into skia.gni. Other variables that need to work like that can move there later. icu/BUILD.gn defines SK_USING_THIRD_PARTY_ICU if needed. SkShaper_harfbuzz.cpp SkPDFSubsetFont.cpp respects SK_USING_THIRD_PARTY_ICU when calling SkLoadICU(). sfntly/BUILD.gn, harfbuzz/BUILD.gn, icu/icu.gni uses $_src variable to reduce verbosity. icu/icu.gni adds more headersto sources. Change-Id: I9e000b9b19902d9f5c0c64e989bf42466aa8a299 Reviewed-on: https://skia-review.googlesource.com/c/189304 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
2019-02-04 20:36:31 +00:00
}
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
SkPDF: Add experimental Harfbuzz font subsetter Currently hidden behind gn flag: skia_pdf_subset_harfbuzz Replaces Sfntly subsetter. TODO: 1) Test on all clients. 2) Enable on each client. 3) Set skia_pdf_subset_harfbuzz default to true, 4) Delete sfntly dependency. Bug: chromium:931719 Change-Id: I5c763ce3e6b21d6bc65284d4105b9974e0907cdc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/171223 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2019-02-20 16:25:45 +00:00
declare_args() {
Generate SkSL golden output files from test inputs during the build. Golden SkSL outputs are intended to eventually replace the majority of our unit tests, since they can automatically update themselves when we change implementation details of the compiler. If you change the compiler output without updating the Golden files, the CheckGeneratedFiles housekeeper will be triggered. Set `skia_compile_processors` or `skia_compile_sksl_tests` to true in your GN args to regenerate them. Almost all of the tests from SkSLFPTests.cpp and SkSLGLSLTests.cpp can be migrated into separate unit-test .fp/.sksl files in a followup CL. hcm@ has signed off on removing the copyright boilerplate preamble from our unit test files. Change-Id: I9e24a944bbac8f8efd62c92481b022a0b1ecdd0b Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316336 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-14 14:21:44 +00:00
skia_compile_sksl_tests = skia_compile_processors
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_enable_fontmgr_android = skia_use_expat && skia_use_freetype
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
skia_enable_fontmgr_custom_directory = skia_use_freetype && !is_fuchsia
skia_enable_fontmgr_custom_embedded = skia_use_freetype && !is_fuchsia
skia_enable_fontmgr_custom_empty = skia_use_freetype
skia_enable_fontmgr_fontconfig = skia_use_freetype && skia_use_fontconfig
skia_enable_fontmgr_FontConfigInterface =
skia_use_freetype && skia_use_fontconfig
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_enable_nvpr = !skia_enable_flutter_defines
skia_enable_spirv_validation = is_skia_dev_build && is_debug && !skia_use_dawn
Reland "Split building encoding from decoding" This reverts commit 9d4b788807fcca010399c0987aed41b3af5d938f. Copyright issue has been fixed in https://skia-review.googlesource.com/c/skia/+/275998. Original description: Bug: skia:9756 In CanvasKit, a large part of the binary is for encoding. Clients would be happier with a smaller binary and no webp/jpeg encoding. Make this an option by splitting up the GN arguments. Split SK_HAS_WEBP_LIBRARY into SK_CODEC_DECODES_WEBP (to match the existing SK_CODEC_DECODES_RAW) and SK_ENCODE_WEBP. Same for JPEG and PNG. Update CanvasKit compile script to disable webp and jpeg encoding. Update debugger compile script to disable all encoding. Change IsPng signature to match other SkCodecs. TBR=djsollen@google.com Change-Id: Ic847bae0154e0a2922100b3f2ee14a077ee5635a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276007 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-03-09 18:23:30 +00:00
skia_use_dng_sdk =
!is_fuchsia && skia_use_libjpeg_turbo_decode && skia_use_zlib
Replace third_party/gif: Preflight changes Something is breaking client code in unexpected ways. Let's try this piecemeal. - skia_libgifcodec_path gn var. Default is third_party/externals/libgifcodec. Anfroid framework uses third_party/libgifcodec. - skia_use_libgifcodec gn var; defaults to !skia_use_wuffs. Allow disabling both codecs. - GN template("optional"): add public_include_dirs, similar to public_defines. - SK_USE_LIBGIFCODEC, ifdef for skia_use_libgifcodec. - SkCodec.cpp: use SK_USE_LIBGIFCODEC Original CL: https://review.skia.org/254582 Cq-Include-Trybots: luci.skia.skia.primary:Build-Debian9-Clang-x86-devrel-Android_SKQP Bug: skia:9654 Change-Id: I70561f5f945656065e4b318d5fff505961fb0b6b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/255578 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-11-20 21:01:31 +00:00
skia_use_libgifcodec = !skia_use_wuffs
gn: move all skia_* declare_args to skia.gni motivation: put them all in one place. Change-Id: Id40aff1f6ddc36b99b14567f110b5084da7e2bd4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238899 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-09-03 17:46:25 +00:00
skia_use_sfntly = skia_use_icu
Reland "Create D3D device and queue" This is a reland of 29dc430f43e1b27a26d2413ca427109f616539db Original change's description: > Create D3D device and queue > > Bug: skia:9935 > Change-Id: Ib6548f413ca3a8befb553d2d47354b400c9162b9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272520 > Commit-Queue: Jim Van Verth <jvanverth@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> Bug: skia:9935 Change-Id: I1c8797e09cdeb3694ea7f47b2236ab7d91d9519f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272996 Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2020-02-24 16:36:15 +00:00
skia_enable_vulkan_debug_layers = skia_enable_gpu_debug_layers
skia_enable_direct3d_debug_layer = skia_enable_gpu_debug_layers
Reland "Make compiling the amd vulkan memory allocator optional." This reverts commit 6a5a91e1643ae6f692feb8fc67d6b8319cbdb63f. Reason for revert: chrome gn updated, so this should roll fine now Original change's description: > Revert "Make compiling the amd vulkan memory allocator optional." > > This reverts commit 23da19863e321349393c61312293b090ec792287. > > Reason for revert: break chrome roll, need to land chrome change first > > Original change's description: > > Make compiling the amd vulkan memory allocator optional. > > > > Change-Id: I79b9f78b52f215076a371cbd0ff057d61dd855f0 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285380 > > Reviewed-by: Brian Osman <brianosman@google.com> > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > TBR=egdaniel@google.com,brianosman@google.com,penghuang@chromium.org > > Change-Id: Ifc17a07f5cdfcf7b38272e5c44e5b894019cf44a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285538 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,brianosman@google.com,penghuang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4767039236137d3eaece2e16abef57278ce199ed Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285662 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-04-27 14:26:21 +00:00
skia_use_vma = skia_use_vulkan
SkPDF: Add experimental Harfbuzz font subsetter Currently hidden behind gn flag: skia_pdf_subset_harfbuzz Replaces Sfntly subsetter. TODO: 1) Test on all clients. 2) Enable on each client. 3) Set skia_pdf_subset_harfbuzz default to true, 4) Delete sfntly dependency. Bug: chromium:931719 Change-Id: I5c763ce3e6b21d6bc65284d4105b9974e0907cdc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/171223 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2019-02-20 16:25:45 +00:00
}
[canvaskit] JS API in place for shaped text Depends on https://skia-review.googlesource.com/c/skia/+/186870 It's optional at build time, which is good given that it adds about 2MB of uncompressed size (from 4.3 MB to 6.4 MB) Bug: skia: Change-Id: I5f54ad628b735c3bc880e917394fb27d16849ebe Reviewed-on: https://skia-review.googlesource.com/c/187924 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-02-22 15:04:06 +00:00
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
declare_args() {
# skia_fontmgr_factory should define SkFontMgr::Factory()
if (skia_enable_fontmgr_empty) {
Allow fontmgr factory to depend on fontmgrs. In 75626e4b1a "Regularize selection of fontmgr." a clever change was made which allowed the skia_fontmgr_factory to be specified as a source file to allow the user to specify which factory to use. Unfortunately this implies that the Skia target which uses this source does not know which other targets (like fontmgr targets) to depend on. A factory target must generally depend on the target which provides the widget the factory makes. This change puts all the current factories into targets of their own so that they can depend on whatever they need. The skia_fontmgr_factory is now the name of a target which is the sole public member of the :fontmgr_factory target. Users can now specify a particular fontmgr target to build into Skia as the default instead of simply specifying a source file. The fontmgr_fontconfig target now also properly publicly depends on the fontconfig target since it has a public header which includes fontconfig.h. Bug: b/160133836 Change-Id: I212d842b8e07c4e99ab53e32310642d18eeb7cb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299677 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-06-29 15:59:10 +00:00
skia_fontmgr_factory = ":fontmgr_empty_factory"
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
} else if (is_android && skia_enable_fontmgr_android) {
Allow fontmgr factory to depend on fontmgrs. In 75626e4b1a "Regularize selection of fontmgr." a clever change was made which allowed the skia_fontmgr_factory to be specified as a source file to allow the user to specify which factory to use. Unfortunately this implies that the Skia target which uses this source does not know which other targets (like fontmgr targets) to depend on. A factory target must generally depend on the target which provides the widget the factory makes. This change puts all the current factories into targets of their own so that they can depend on whatever they need. The skia_fontmgr_factory is now the name of a target which is the sole public member of the :fontmgr_factory target. Users can now specify a particular fontmgr target to build into Skia as the default instead of simply specifying a source file. The fontmgr_fontconfig target now also properly publicly depends on the fontconfig target since it has a public header which includes fontconfig.h. Bug: b/160133836 Change-Id: I212d842b8e07c4e99ab53e32310642d18eeb7cb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299677 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-06-29 15:59:10 +00:00
skia_fontmgr_factory = ":fontmgr_android_factory"
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
} else if (is_win && skia_enable_fontmgr_win) {
Allow fontmgr factory to depend on fontmgrs. In 75626e4b1a "Regularize selection of fontmgr." a clever change was made which allowed the skia_fontmgr_factory to be specified as a source file to allow the user to specify which factory to use. Unfortunately this implies that the Skia target which uses this source does not know which other targets (like fontmgr targets) to depend on. A factory target must generally depend on the target which provides the widget the factory makes. This change puts all the current factories into targets of their own so that they can depend on whatever they need. The skia_fontmgr_factory is now the name of a target which is the sole public member of the :fontmgr_factory target. Users can now specify a particular fontmgr target to build into Skia as the default instead of simply specifying a source file. The fontmgr_fontconfig target now also properly publicly depends on the fontconfig target since it has a public header which includes fontconfig.h. Bug: b/160133836 Change-Id: I212d842b8e07c4e99ab53e32310642d18eeb7cb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299677 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-06-29 15:59:10 +00:00
skia_fontmgr_factory = ":fontmgr_win_factory"
Use Mac font manager for both iOS and macOS If skia_use_fonthost_mac is set, use SkFontMgr_mac_ct_factory.cpp on both macOS and iOS. Previously, this was only used on macOS, causing iOS Flutter builds to default to SkFontMgr_empty_factory.cpp on that platform. Patch that introduced the Flutter iOS issue: https://skia-review.googlesource.com/c/skia/+/295437 Change-Id: If2f1e7db47a55245de6c2658ad564e79134d3e7d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297194 Commit-Queue: Chris Bracken <cbracken@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-06-17 21:10:52 +00:00
} else if ((is_mac || is_ios) && skia_use_fonthost_mac) {
Allow fontmgr factory to depend on fontmgrs. In 75626e4b1a "Regularize selection of fontmgr." a clever change was made which allowed the skia_fontmgr_factory to be specified as a source file to allow the user to specify which factory to use. Unfortunately this implies that the Skia target which uses this source does not know which other targets (like fontmgr targets) to depend on. A factory target must generally depend on the target which provides the widget the factory makes. This change puts all the current factories into targets of their own so that they can depend on whatever they need. The skia_fontmgr_factory is now the name of a target which is the sole public member of the :fontmgr_factory target. Users can now specify a particular fontmgr target to build into Skia as the default instead of simply specifying a source file. The fontmgr_fontconfig target now also properly publicly depends on the fontconfig target since it has a public header which includes fontconfig.h. Bug: b/160133836 Change-Id: I212d842b8e07c4e99ab53e32310642d18eeb7cb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299677 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-06-29 15:59:10 +00:00
skia_fontmgr_factory = ":fontmgr_mac_ct_factory"
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
} else if (skia_enable_fontmgr_fontconfig) {
Allow fontmgr factory to depend on fontmgrs. In 75626e4b1a "Regularize selection of fontmgr." a clever change was made which allowed the skia_fontmgr_factory to be specified as a source file to allow the user to specify which factory to use. Unfortunately this implies that the Skia target which uses this source does not know which other targets (like fontmgr targets) to depend on. A factory target must generally depend on the target which provides the widget the factory makes. This change puts all the current factories into targets of their own so that they can depend on whatever they need. The skia_fontmgr_factory is now the name of a target which is the sole public member of the :fontmgr_factory target. Users can now specify a particular fontmgr target to build into Skia as the default instead of simply specifying a source file. The fontmgr_fontconfig target now also properly publicly depends on the fontconfig target since it has a public header which includes fontconfig.h. Bug: b/160133836 Change-Id: I212d842b8e07c4e99ab53e32310642d18eeb7cb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299677 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-06-29 15:59:10 +00:00
skia_fontmgr_factory = ":fontmgr_fontconfig_factory"
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
} else if (skia_enable_fontmgr_custom_directory) {
Allow fontmgr factory to depend on fontmgrs. In 75626e4b1a "Regularize selection of fontmgr." a clever change was made which allowed the skia_fontmgr_factory to be specified as a source file to allow the user to specify which factory to use. Unfortunately this implies that the Skia target which uses this source does not know which other targets (like fontmgr targets) to depend on. A factory target must generally depend on the target which provides the widget the factory makes. This change puts all the current factories into targets of their own so that they can depend on whatever they need. The skia_fontmgr_factory is now the name of a target which is the sole public member of the :fontmgr_factory target. Users can now specify a particular fontmgr target to build into Skia as the default instead of simply specifying a source file. The fontmgr_fontconfig target now also properly publicly depends on the fontconfig target since it has a public header which includes fontconfig.h. Bug: b/160133836 Change-Id: I212d842b8e07c4e99ab53e32310642d18eeb7cb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299677 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-06-29 15:59:10 +00:00
skia_fontmgr_factory = ":fontmgr_custom_directory_factory"
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
} else if (skia_enable_fontmgr_custom_embedded) {
Allow fontmgr factory to depend on fontmgrs. In 75626e4b1a "Regularize selection of fontmgr." a clever change was made which allowed the skia_fontmgr_factory to be specified as a source file to allow the user to specify which factory to use. Unfortunately this implies that the Skia target which uses this source does not know which other targets (like fontmgr targets) to depend on. A factory target must generally depend on the target which provides the widget the factory makes. This change puts all the current factories into targets of their own so that they can depend on whatever they need. The skia_fontmgr_factory is now the name of a target which is the sole public member of the :fontmgr_factory target. Users can now specify a particular fontmgr target to build into Skia as the default instead of simply specifying a source file. The fontmgr_fontconfig target now also properly publicly depends on the fontconfig target since it has a public header which includes fontconfig.h. Bug: b/160133836 Change-Id: I212d842b8e07c4e99ab53e32310642d18eeb7cb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299677 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-06-29 15:59:10 +00:00
skia_fontmgr_factory = ":fontmgr_custom_embedded_factory"
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
} else if (skia_enable_fontmgr_custom_empty) {
Allow fontmgr factory to depend on fontmgrs. In 75626e4b1a "Regularize selection of fontmgr." a clever change was made which allowed the skia_fontmgr_factory to be specified as a source file to allow the user to specify which factory to use. Unfortunately this implies that the Skia target which uses this source does not know which other targets (like fontmgr targets) to depend on. A factory target must generally depend on the target which provides the widget the factory makes. This change puts all the current factories into targets of their own so that they can depend on whatever they need. The skia_fontmgr_factory is now the name of a target which is the sole public member of the :fontmgr_factory target. Users can now specify a particular fontmgr target to build into Skia as the default instead of simply specifying a source file. The fontmgr_fontconfig target now also properly publicly depends on the fontconfig target since it has a public header which includes fontconfig.h. Bug: b/160133836 Change-Id: I212d842b8e07c4e99ab53e32310642d18eeb7cb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299677 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-06-29 15:59:10 +00:00
skia_fontmgr_factory = ":fontmgr_custom_empty_factory"
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
} else {
#"src/ports/SkFontMgr_FontConfigInterface_factory.cpp" #WontFix
#"src/ports/SkFontMgr_win_gdi_factory.cpp" # WontFix
Allow fontmgr factory to depend on fontmgrs. In 75626e4b1a "Regularize selection of fontmgr." a clever change was made which allowed the skia_fontmgr_factory to be specified as a source file to allow the user to specify which factory to use. Unfortunately this implies that the Skia target which uses this source does not know which other targets (like fontmgr targets) to depend on. A factory target must generally depend on the target which provides the widget the factory makes. This change puts all the current factories into targets of their own so that they can depend on whatever they need. The skia_fontmgr_factory is now the name of a target which is the sole public member of the :fontmgr_factory target. Users can now specify a particular fontmgr target to build into Skia as the default instead of simply specifying a source file. The fontmgr_fontconfig target now also properly publicly depends on the fontconfig target since it has a public header which includes fontconfig.h. Bug: b/160133836 Change-Id: I212d842b8e07c4e99ab53e32310642d18eeb7cb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299677 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-06-29 15:59:10 +00:00
skia_fontmgr_factory = ":fontmgr_empty_factory"
Regularize selection of fontmgr. Change-Id: Id7c51504450c1c7c9421eba3838bd6bc3440ca4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295437 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-06-03 17:20:37 +00:00
}
}
[canvaskit] JS API in place for shaped text Depends on https://skia-review.googlesource.com/c/skia/+/186870 It's optional at build time, which is good given that it adds about 2MB of uncompressed size (from 4.3 MB to 6.4 MB) Bug: skia: Change-Id: I5f54ad628b735c3bc880e917394fb27d16849ebe Reviewed-on: https://skia-review.googlesource.com/c/187924 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-02-22 15:04:06 +00:00
# Our tools require static linking (they use non-exported symbols), and the GPU backend.
skia_enable_tools = skia_enable_tools && !is_component_build && skia_enable_gpu
Reference in New Issue Copy Permalink