AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
0d226afee9
skia2/tests/sksl/runtime_errors/Ossfuzz36655.skvm

16 lines
625 B
Plaintext
Raw Normal View History

Add improved regression test for oss-fuzz:36655. Most of the code generated by the fuzzer is nonsense, but there is a method to its madness. The crash is only triggered under specific conditions: - The runtime effect has enough helper functions to mostly fill up the call graph hash-map. It won't rehash until it gets close to capacity. - There must be several calls to built-in functions, in order to add elements to the call graph to force a rehash. The fuzzer-generated code manages to satisfy both these requirements. Change-Id: I9a1d7535557fedd4e9bfece3930ac86ede291ffe Bug: oss-fuzz:36655 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/437118 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-08-05 20:50:56 +00:00
### Compilation failed:
Report incomplete expression-statements as errors. Previously, a dangling type or function reference would be eliminated silently with optimizations on, or would assert when optimizations were off. Change-Id: Ib2e273b6f069724e8872c9cb97351b647b875a62 Bug: skia:12472 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/469525 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-11-09 21:29:13 +00:00
error: 2: expected '(' to begin constructor invocation
Improve parser behavior with invalid statements inside a Block. Previously, when the parser found a bad statement inside a Block, it would stop processing that Block entirely. This caused our brace matching to fall out of balance. block() would normally only return once the Block's closing brace was consumed, but in this case, the closing brace would still be in the parse stream awaiting consumption even though block() had returned. Now, when a bad statement is found inside a Block, we just ignore it and continue processing. (I tried injecting a poisoned statement as well, to see if it would affect the test results, but they were identical.) This seems to generate somewhat better errors. Change-Id: I8dc781d5602bf99d7610f8280cde8b7c1925cb65 Bug: skia:12868 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/506463 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-02-09 21:01:32 +00:00
error: 11: expected '(' to begin function call
error: 17: expected '(' to begin function call
error: 21: expected '(' to begin function call
error: 23: expected '(' to begin constructor invocation
error: 26: expected '(' to begin function call
error: 32: expected '(' to begin function call
error: 32: expected '(' to begin function call
error: 35: expected '(' to begin function call
error: 39: expected '(' to begin function call
error: 43: expected '(' to begin constructor invocation
error: 46: expected '(' to begin function call
12 errors
Reference in New Issue Copy Permalink