AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
1315333b6b
skia2/gn/flutter_defines.gni

28 lines
790 B
Plaintext
Raw Normal View History

Add GN arg to allow Flutter-specific API guards Bug: skia: Change-Id: I5a97da664626eebf30bba3f391fff0d8b9e62ea5 Reviewed-on: https://skia-review.googlesource.com/23042 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-07-13 19:50:03 +00:00
# Copyright 2017 Google Inc.
#
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
Preemptively disable upcoming Skia features in Flutter/Fuchsia Change-Id: I8be706846fecde704a29ba1dda0d7329046980b4 Reviewed-on: https://skia-review.googlesource.com/69840 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2017-11-10 13:22:28 +00:00
flutter_defines = [
Switch MDB GrContextOptions over to Enable style Change-Id: Id6541c346a13649c89ca3b9ccb13972976f9b973 Reviewed-on: https://skia-review.googlesource.com/105603 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-02-08 15:59:38 +00:00
"SK_DISABLE_EXPLICIT_GPU_RESOURCE_ALLOCATION",
Revert "remove old name for SkCodec::kNoFrame" This reverts commit 06a477c3300d7e1ceae339f704df7b6e0710dc1d. Reason for revert: <INSERT REASONING HERE> Original change's description: > remove old name for SkCodec::kNoFrame > > Cq-Include-Trybots: skia.primary:Build-Debian9-Clang-arm-Release-Flutter_Android > Change-Id: I039aed7591aa7767046f28a48798b6fa2f7fd643 > Reviewed-on: https://skia-review.googlesource.com/c/169224 > Reviewed-by: Leon Scroggins <scroggo@google.com> TBR=mtklein@google.com,scroggo@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I6c61ee27a4167127c74c14e0f9e05a4bbac931a8 Cq-Include-Trybots: skia.primary:Build-Debian9-Clang-arm-Release-Flutter_Android Reviewed-on: https://skia-review.googlesource.com/c/170422 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-12 16:08:30 +00:00
"SK_LEGACY_SKCODEC_NONE_ENUM",
Reland "disable DAA and AAA in flutter" This is a reland of 14211203162bb2d8f13b6393cd4dba268c5441e6 PS2 rescopes a variable tighter, and reindents to make the #if-#else logic stand out a little more clearly. Original change's description: > disable DAA and AAA in flutter > > If we're looking to cut out unnecessary code in Flutter, > SkScan_AAA always jumps out to me as a bunch of code that > is not logically required for GPU rendering. > > Looking at a treemap[1], SkScan_AAA is the biggest chunk of > code under src/core. I don't see DAA... maybe it's small, > or somehow already trimmed? Anyway, I cut it out too. > > [1] https://storage.googleapis.com/flutter_infra/flutter/c8755d74c17e949ee7c19cd114f084b465dac632/android-arm-release/sizes/index.html > > Change-Id: I4acf4aec365504c90e6b66393fd265a399f0f525 > Reviewed-on: https://skia-review.googlesource.com/c/159760 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> Change-Id: I6770781c26a0a581ed0df33c404386415472bed5 Reviewed-on: https://skia-review.googlesource.com/c/161581 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-04 19:28:07 +00:00
move this define to be with its friends in flutter_defines.gni I'd like to get to the point where the only Flutter-specific configuration is defines, in flutter_defines.gni. Change-Id: Idda141c4dcdb5f18275e29d2ab60bb73bf416d59 Reviewed-on: https://skia-review.googlesource.com/c/169102 Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 14:38:55 +00:00
# Flutter always wants this https://github.com/flutter/flutter/issues/11402
"SK_ENABLE_DUMP_GPU",
Reland "disable DAA and AAA in flutter" This is a reland of 14211203162bb2d8f13b6393cd4dba268c5441e6 PS2 rescopes a variable tighter, and reindents to make the #if-#else logic stand out a little more clearly. Original change's description: > disable DAA and AAA in flutter > > If we're looking to cut out unnecessary code in Flutter, > SkScan_AAA always jumps out to me as a bunch of code that > is not logically required for GPU rendering. > > Looking at a treemap[1], SkScan_AAA is the biggest chunk of > code under src/core. I don't see DAA... maybe it's small, > or somehow already trimmed? Anyway, I cut it out too. > > [1] https://storage.googleapis.com/flutter_infra/flutter/c8755d74c17e949ee7c19cd114f084b465dac632/android-arm-release/sizes/index.html > > Change-Id: I4acf4aec365504c90e6b66393fd265a399f0f525 > Reviewed-on: https://skia-review.googlesource.com/c/159760 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> Change-Id: I6770781c26a0a581ed0df33c404386415472bed5 Reviewed-on: https://skia-review.googlesource.com/c/161581 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-04 19:28:07 +00:00
# Remove software rasterizers to save some code size.
"SK_DISABLE_AAA",
"SK_DISABLE_DAA",
disable lowp raster pipeline stages in Flutter Flutter barely needs the float stages, and probably doesn't care at all about these. Change-Id: I663e5496f4f9a6c689c1ef0137b2318177fb3760 Reviewed-on: https://skia-review.googlesource.com/c/161582 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-10-12 02:05:14 +00:00
Revert[4] "hide nested hinting enum" This reverts commit 8e12cc6dfe3801e5a32b7bfa02a39c48fa03c207. Bug: skia: Change-Id: Ice5e3480adad75ab77d97f7366495015f36b15a6 Reviewed-on: https://skia-review.googlesource.com/c/169520 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2018-11-08 00:54:33 +00:00
# API staging
re-add guard to flutter for fuchsia build -- until newer flutter lands Bug: skia: Change-Id: I408bc113f5036710c743890de45e286021c6be88 Reviewed-on: https://skia-review.googlesource.com/c/170346 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-11-12 14:45:12 +00:00
"SK_SUPPORT_LEGACY_NESTED_HINTINGENUM",
Revert[4] "hide nested hinting enum" This reverts commit 8e12cc6dfe3801e5a32b7bfa02a39c48fa03c207. Bug: skia: Change-Id: Ice5e3480adad75ab77d97f7366495015f36b15a6 Reviewed-on: https://skia-review.googlesource.com/c/169520 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2018-11-08 00:54:33 +00:00
stub SkReadBuffer when SK_DISABLE_READBUFFER This seems like a way to disable SkReadBuffer that won't require other preprocessor checks in the various effects. Disable SkReadBuffer in Flutter too, for about 20K. Change-Id: I87039b67d90ad372a21940d7e96fc46bf5114bfd Reviewed-on: https://skia-review.googlesource.com/c/165021 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-25 15:35:56 +00:00
# Flutter doesn't deserialize anything.
"SK_DISABLE_READBUFFER",
Reland "simplify disabling effect deserialization" This reverts commit 34d7a163a4a749d6e91cf768d0f1767e8da6ceb2. Reason for revert: ok now? Original change's description: > Revert "simplify disabling effect deserialization" > > This reverts commit 5bbf790b5beeb2ed74f04551502259b54ac5556f. > > Reason for revert: flutter GN needs some love > > Original change's description: > > simplify disabling effect deserialization > > > > Switch to a simple #define instead of conditional build targets. > > > > No one changes skia_enable_effects or skia_enable_effects_imagefilters, > > so we can merge all that together back into :skia. > > > > Change-Id: I2985f95ee89149ddc687dc31f4c6bf35cb3a93c7 > > Reviewed-on: https://skia-review.googlesource.com/c/169220 > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > Commit-Queue: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,kjlubick@google.com > > Change-Id: I3b818418d303dbc6d2a926a19df64a68499f0ec3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/169222 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,kjlubick@google.com Cq-Include-Trybots: skia.primary:Build-Debian9-Clang-arm-Release-Flutter_Android Change-Id: I534346c3ef3561a871f1af6df976bfee0b48014a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/169640 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2018-11-08 12:08:05 +00:00
"SK_DISABLE_EFFECT_DESERIALIZATION",
stub SkReadBuffer when SK_DISABLE_READBUFFER This seems like a way to disable SkReadBuffer that won't require other preprocessor checks in the various effects. Disable SkReadBuffer in Flutter too, for about 20K. Change-Id: I87039b67d90ad372a21940d7e96fc46bf5114bfd Reviewed-on: https://skia-review.googlesource.com/c/165021 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-25 15:35:56 +00:00
disable lowp raster pipeline stages in Flutter Flutter barely needs the float stages, and probably doesn't care at all about these. Change-Id: I663e5496f4f9a6c689c1ef0137b2318177fb3760 Reviewed-on: https://skia-review.googlesource.com/c/161582 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-10-12 02:05:14 +00:00
# Fast low-precision software rendering isn't a priority for Flutter.
disable legacy shaders in flutter All of Flutter's non-test drawing is done with Ganesh, and the few shaders that are legacy-only are not used by Flutter. This should cut a bunch of essentially-dead code from Flutter, though some of the Flutter test images may change because those test images are software rasterized. Hopefully nothing should look terribly different. Looks like this cuts ~27K from Flutter. Change-Id: I4c8078db17fe9d24b15ed9d8c6adb528a382f02a Reviewed-on: https://skia-review.googlesource.com/c/163165 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-17 17:51:30 +00:00
"SK_DISABLE_LEGACY_SHADERCONTEXT",
disable lowp raster pipeline stages in Flutter Flutter barely needs the float stages, and probably doesn't care at all about these. Change-Id: I663e5496f4f9a6c689c1ef0137b2318177fb3760 Reviewed-on: https://skia-review.googlesource.com/c/161582 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-10-12 02:05:14 +00:00
"SK_DISABLE_LOWP_RASTER_PIPELINE",
cut out the rest of blend modes in flutter SkXfermode_opts.h is moot when SK_FORCE_RASTER_PIPELINE_BLITTER is defined. There are a couple other blitters and routines and things that are also just there for 565/8888 performance, so I think we can just turn on SK_FORCE_RASTER_PIPELINE_BLITTER and start guarding the rest of them similarly. Looks like maybe cuts another 13K? Change-Id: Ib3894b07da649a93e93b6a4cb7686772a57b6def Reviewed-on: https://skia-review.googlesource.com/c/164181 Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2018-10-22 13:48:01 +00:00
"SK_FORCE_RASTER_PIPELINE_BLITTER",
Preemptively disable upcoming Skia features in Flutter/Fuchsia Change-Id: I8be706846fecde704a29ba1dda0d7329046980b4 Reviewed-on: https://skia-review.googlesource.com/69840 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2017-11-10 13:22:28 +00:00
]
Reference in New Issue Copy Permalink