[PathKit] Adding test infrastructure to support Gold output
To get the gold images out of the browser tests, this adds
testReporter.js and pathkit_aggregator.go. testReporter bundles
up the output as a base64 encoded PNG and sends it over the local
network to pathkit_aggregator. pathkit_aggregator will keep
a list of test results reported in this way and write the PNGs
to /OUT of the container (which is the swarming output directory).
Finally, after all the tests are run, the helper script "test_pathkit.sh"
makes a POST request that creates the JSON file that gold expects
(following the schema https://github.com/google/skia-buildbot/blob/master/golden/docs/INGESTION.md)
pathkit_aggregator takes many command line arguments which control
the keys that Gold needs in order to ingest and handle the data.
Of note, this creates a new set (i.e. source_type) of gold images
called "pathkit", which will distinguish it from "gm", "image", etc.
There will be at least 2 sub-sets of "pathkit" images, "canvas" and "svg",
(representing the 2 output types of PathKit). This CL doesn't
quite handle SVG yet, as it needs a way to convert SVG to PNG in the
browser and will be addressed in a follow up CL.
A "standard" gm is sized at 600x600. This was arbitrarily picked.
Note that the functions in testReporter.js return Promises based
on the fetch requests to post the data. This eliminates the race
condition between the /report_gold_data and /dump_json since
running the karma tests won't return until all reports are done.
Other changes of note:
- Adds go to karma-chrome-tests container.
- renames recipe_modules/build/wasm.py -> pathkit.py to be consistent with
the name of test_pathkit.py and make for easier grepping.
- Increases the JS test timeout to 10s (up from 5) to hopefully avoid
the flakes seen in the Debug Test.
Bug: skia:8216
Change-Id: Ic2cad54f3d19cc16601cf2e9a87798db1e6887a2
Reviewed-on: https://skia-review.googlesource.com/147042
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-15 17:45:28 +00:00
|
|
|
# Docker container with Chrome, and karma/jasmine, to be used to run JS tests.
|
2018-08-09 14:00:02 +00:00
|
|
|
# Inspired by https://github.com/eirslett/chrome-karma-docker
|
[PathKit] Adding test infrastructure to support Gold output
To get the gold images out of the browser tests, this adds
testReporter.js and pathkit_aggregator.go. testReporter bundles
up the output as a base64 encoded PNG and sends it over the local
network to pathkit_aggregator. pathkit_aggregator will keep
a list of test results reported in this way and write the PNGs
to /OUT of the container (which is the swarming output directory).
Finally, after all the tests are run, the helper script "test_pathkit.sh"
makes a POST request that creates the JSON file that gold expects
(following the schema https://github.com/google/skia-buildbot/blob/master/golden/docs/INGESTION.md)
pathkit_aggregator takes many command line arguments which control
the keys that Gold needs in order to ingest and handle the data.
Of note, this creates a new set (i.e. source_type) of gold images
called "pathkit", which will distinguish it from "gm", "image", etc.
There will be at least 2 sub-sets of "pathkit" images, "canvas" and "svg",
(representing the 2 output types of PathKit). This CL doesn't
quite handle SVG yet, as it needs a way to convert SVG to PNG in the
browser and will be addressed in a follow up CL.
A "standard" gm is sized at 600x600. This was arbitrarily picked.
Note that the functions in testReporter.js return Promises based
on the fetch requests to post the data. This eliminates the race
condition between the /report_gold_data and /dump_json since
running the karma tests won't return until all reports are done.
Other changes of note:
- Adds go to karma-chrome-tests container.
- renames recipe_modules/build/wasm.py -> pathkit.py to be consistent with
the name of test_pathkit.py and make for easier grepping.
- Increases the JS test timeout to 10s (up from 5) to hopefully avoid
the flakes seen in the Debug Test.
Bug: skia:8216
Change-Id: Ic2cad54f3d19cc16601cf2e9a87798db1e6887a2
Reviewed-on: https://skia-review.googlesource.com/147042
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-08-15 17:45:28 +00:00
|
|
|
#
|
|
|
|
|
# Tests will be run as non-root (user skia, in fact), so /OUT should have permissions
|
|
|
|
|
# 777 so as to be able to create output there.
|
2018-08-09 14:00:02 +00:00
|
|
|
|
|
|
|
|
FROM node:8.11
|
|
|
|
|
|
|
|
|
|
RUN apt-get update && apt-get upgrade -y
|
|
|
|
|
|
|
|
|
|
RUN wget https://github.com/Yelp/dumb-init/releases/download/v1.2.2/dumb-init_1.2.2_amd64.deb
|
|
|
|
|
RUN dpkg -i dumb-init_*.deb
|
|
|
|
|
|
|
|
|
|
ENTRYPOINT ["/usr/bin/dumb-init", "--"]
|
|
|
|
|
|
|
|
|
|
RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add -
|
|
|
|
|
RUN sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'
|
|
|
|
|
RUN apt-get update && apt-get install -y google-chrome-stable
|
|
|
|
|
|
|
|
|
|
RUN npm install --global jasmine-core@3.1.0 karma@2.0.5 \
|
2018-08-22 13:35:32 +00:00
|
|
|
karma-chrome-launcher@2.2.0 karma-jasmine@1.1.2 requirejs@2.3.5 \
|
|
|
|
|
is-docker@1.1.0
|
|
|
|
|
|
|
|
|
|
# Allows require('is-docker') or require('karma') to work from anywhere.
|
|
|
|
|
# https://stackoverflow.com/a/15646750
|
|
|
|
|
ENV NODE_PATH=/usr/local/lib/node_modules
|
2018-08-09 14:00:02 +00:00
|
|
|
|
|
|
|
|
#Add user so we don't have to run as root (prevents us from over-writing files in /SRC)
|
|
|
|
|
RUN groupadd -g 2000 skia \
|
|
|
|
|
&& useradd -u 2000 -g 2000 skia \
|
|
|
|
|
&& mkdir -p /home/skia \
|
|
|
|
|
&& chown -R skia:skia /home/skia
|
|
|
|
|
|
|
|
|
|
# These directories can be used for mounting a source checkout and having a place to put outputs.
|
|
|
|
|
RUN mkdir -m 0777 /SRC /OUT
|
|
|
|
|
|
|
|
|
|
# Run everything after as non-privileged user.
|
|
|
|
|
USER skia
|
|
|
|
|
|
|
|
|
|
WORKDIR /home/skia
|