skia2/.clang-tidy

Checks: >
    -*,
    bugprone-argument-comment,
    bugprone-bool-pointer-implicit-conversion,
    bugprone-undelegated-constructor,
    bugprone-unused-raii,
    bugprone-use-after-move,
    google-build-namespaces,
    llvm-namespace-comment,
    misc-definitions-in-headers,
    modernize-make-unique,
    modernize-use-nullptr,
    modernize-use-override,
    performance-for-range-copy,
    performance-unnecessary-copy-initialization,
    readability-const-return-type,
    readability-redundant-preprocessor,
    readability-static-accessed-through-instance
CheckOptions:
  - key:             llvm-namespace-comment.SpacesBeforeComments
    value:           2
Enable ClangTidy flag modernize-use-override. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Adds override (introduced in C++11) to overridden virtual functions and removes virtual from those functions as it is not required. virtual on non base class implementations was used to help indicate to the user that a function was virtual. C++ compilers did not use the presence of this to signify an overridden function. Change-Id: If66d8919358f72a4035190caf8d7569268037a9a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310160 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com> 2020-08-14 02:58:04 +00:00			`Checks: >`
			`-*,`
			`bugprone-argument-comment,`
			`bugprone-bool-pointer-implicit-conversion,`
			`bugprone-undelegated-constructor,`
			`bugprone-unused-raii,`
			`bugprone-use-after-move,`
			`google-build-namespaces,`
			`llvm-namespace-comment,`
			`misc-definitions-in-headers,`
			`modernize-make-unique,`
Enable ClangTidy check modernize-use-nullptr. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html The check converts the usage of null pointer constants (eg. NULL, 0) to use the new C++11 nullptr keyword. Change-Id: Iaea2d843154c70e49d62affdc5dceb3bca8c1089 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310297 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com> 2020-08-14 14:52:06 +00:00			`modernize-use-nullptr,`
Enable ClangTidy flag modernize-use-override. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Adds override (introduced in C++11) to overridden virtual functions and removes virtual from those functions as it is not required. virtual on non base class implementations was used to help indicate to the user that a function was virtual. C++ compilers did not use the presence of this to signify an overridden function. Change-Id: If66d8919358f72a4035190caf8d7569268037a9a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310160 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com> 2020-08-14 02:58:04 +00:00			`modernize-use-override,`
			`performance-for-range-copy,`
			`performance-unnecessary-copy-initialization,`
			`readability-const-return-type,`
			`readability-redundant-preprocessor,`
			`readability-static-accessed-through-instance`
Enable ClangTidy check llvm-namespace-comment. This fixes a large number of SkSL namespaces which were labeled as if they were anonymous, and also a handful of other mislabeled namespaces. Missing namespace-end comments have been added throughout. A number of diffs are just indentation-related (adjusting 1- or 3- space indents to 2-space). Change-Id: I6c62052a0d3aea4ae12ca07e0c2a8587b2fce4ec Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308503 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2020-08-06 18:11:56 +00:00			`CheckOptions:`
			`- key: llvm-namespace-comment.SpacesBeforeComments`
			`value: 2`