AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
24e7ec7713
skia2/tests/sksl/errors/ArrayOfInvalidSize.glsl

25 lines
932 B
Plaintext
Raw Normal View History

Improve error-checking during array-size conversion. The fuzzer noticed insufficient guards in IndexExpression::Convert when converting an array size from an IntLiteral to a SKSL_INT. We had code in IRGenerator which did this properly, so I moved our array-size conversion logic into SkSLType and had IndexExpression share it. Also, a variety of tests around similar error conditions were added. Change-Id: I51529dea25f9029f81ae236511610069d66be29f Bug: oss-fuzz:37462 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441236 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-08-23 13:24:33 +00:00
### Compilation failed:
error: 1: array size must be positive
error: 2: array size must be positive
error: 3: array size must be positive
error: 4: expected 'int', but found 'float'
Refuse to coerce integer values that don't fit into their type. Previously, we would create SkSL literals of ints that didn't fit into an int. This change causes a few errors to report differently. (In particular, we no longer create global variables containing values that wouldn't fit in that variable, so those symbols are invalid later.) Change-Id: I29d219e853126ea78dd2d2a6d8a69b23ef2b06b8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464121 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-10-27 14:40:21 +00:00
error: 5: integer is out of range for type 'int': 4000000000
Fix error with inlined literals overflowing their types. It's possible to write code containing errors that are only apparent once the inliner runs. For instance, a function which takes a short and returns its negative it is valid for most inputs, but undefined for -32768 (because +32768 does not fit in a short). A function which takes floats and casts them to ints is valid for many inputs, but not valid if you pass in 5 billion. This CL restructures our out-of-range integer error detection to report errors cleanly in these cases instead of asserting. It also refactors the range checking code to be usable in situations where we don't yet have a Literal expression. Change-Id: I98f0be63bf9afbbf1ab90233fa86d380cfae42b4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/466439 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-11-02 13:49:02 +00:00
error: 5: array size must be an integer
Improve error-checking during array-size conversion. The fuzzer noticed insufficient guards in IndexExpression::Convert when converting an array size from an IntLiteral to a SKSL_INT. We had code in IRGenerator which did this properly, so I moved our array-size conversion logic into SkSLType and had IndexExpression share it. Also, a variety of tests around similar error conditions were added. Change-Id: I51529dea25f9029f81ae236511610069d66be29f Bug: oss-fuzz:37462 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441236 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-08-23 13:24:33 +00:00
error: 6: expected 'int', but found 'bool'
error: 7: expected 'int', but found 'bool'
error: 8: expected 'int', but found 'int2'
Reenable DSLParser Change-Id: I1819b2c40902611d7e86245bff73ad8c2bd7629c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/449060 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2021-09-16 14:42:24 +00:00
error: 9: missing index in '[]'
Fix fuzzer-discovered assertion with nonsense array sizes. Change-Id: I7512491f55c10118f0ab058500f6ce9b5b8545cd Bug: oss-fuzz:40557 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/466296 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-11-01 14:50:05 +00:00
error: 10: integer is out of range for type 'int': 4000000000
Improve error-checking during array-size conversion. The fuzzer noticed insufficient guards in IndexExpression::Convert when converting an array size from an IntLiteral to a SKSL_INT. We had code in IRGenerator which did this properly, so I moved our array-size conversion logic into SkSLType and had IndexExpression share it. Also, a variety of tests around similar error conditions were added. Change-Id: I51529dea25f9029f81ae236511610069d66be29f Bug: oss-fuzz:37462 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441236 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-08-23 13:24:33 +00:00
error: 12: array size must be positive
Fix fuzzer-discovered assertion with nonsense array sizes. Change-Id: I7512491f55c10118f0ab058500f6ce9b5b8545cd Bug: oss-fuzz:40557 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/466296 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-11-01 14:50:05 +00:00
error: 13: array size must be positive
error: 14: array size must be positive
Allow const int variables to be used for array sizes. See http://review.skia.org/460037 for an example of the existing behavior. Const variables are constant-expressions and should be allowed here. Change-Id: I41383d79668785f270b7825485e9f6fa56c553c1 Bug: skia:12549 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460036 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-10-16 00:01:49 +00:00
error: 15: array size must be an integer
Fix fuzzer-discovered assertion with nonsense array sizes. Change-Id: I7512491f55c10118f0ab058500f6ce9b5b8545cd Bug: oss-fuzz:40557 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/466296 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-11-01 14:50:05 +00:00
error: 16: array size out of bounds
Allow const int variables to be used for array sizes. See http://review.skia.org/460037 for an example of the existing behavior. Const variables are constant-expressions and should be allowed here. Change-Id: I41383d79668785f270b7825485e9f6fa56c553c1 Bug: skia:12549 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460036 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-10-16 00:01:49 +00:00
error: 17: array size must be an integer
Fix fuzzer-discovered assertion with nonsense array sizes. Change-Id: I7512491f55c10118f0ab058500f6ce9b5b8545cd Bug: oss-fuzz:40557 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/466296 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-11-01 14:50:05 +00:00
error: 18: array size must be an integer
error: 19: array size must be an integer
error: 20: expected array dimension
error: 21: integer is out of range for type 'int': 4000000000
Fix error with inlined literals overflowing their types. It's possible to write code containing errors that are only apparent once the inliner runs. For instance, a function which takes a short and returns its negative it is valid for most inputs, but undefined for -32768 (because +32768 does not fit in a short). A function which takes floats and casts them to ints is valid for many inputs, but not valid if you pass in 5 billion. This CL restructures our out-of-range integer error detection to report errors cleanly in these cases instead of asserting. It also refactors the range checking code to be usable in situations where we don't yet have a Literal expression. Change-Id: I98f0be63bf9afbbf1ab90233fa86d380cfae42b4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/466439 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-11-02 13:49:02 +00:00
21 errors
Reference in New Issue Copy Permalink