2021-11-23 19:58:20 +00:00
|
|
|
generate:
|
2022-05-31 13:32:24 +00:00
|
|
|
echo "You do not need to run this any more for C++ code, only if you modify go code"
|
|
|
|
|
|
|
|
|
|
generate_go:
|
|
|
|
|
cd .. && bazelisk run //:gazelle -- update infra/bots/task_drivers modules/canvaskit/go
|
2021-11-23 19:58:20 +00:00
|
|
|
|
2022-01-11 12:35:26 +00:00
|
|
|
# This target should be run after the go.mod file is updated (e.g. version rolls or new updates)
|
2021-11-23 19:58:20 +00:00
|
|
|
gazelle_update_repo:
|
2022-01-06 16:19:22 +00:00
|
|
|
cd .. && bazelisk run //:gazelle -- update-repos -from_file=go.mod -to_macro=go_repositories.bzl%go_repositories
|
|
|
|
|
|
|
|
|
|
# Run this target to test all known working Bazel builds
|
|
|
|
|
known_good_builds:
|
2022-06-01 18:45:46 +00:00
|
|
|
bazelisk build //:skia_public --config=clang_linux
|
|
|
|
|
bazelisk build //:skia_internal --config=clang_linux
|
[bazel] Add in hierarchical filegroup Bazel rules.
The primary goal of this organization structure is to keep
our top level BUILD.bazel file short, with as little logic
as feasible. The logic required to control which files to
include, which third_party deps are needed, what system libraries
should be linked again, etc, should be in the BUILD.bazel
file best should be as close to the affected files as feasible.
In essence, we use filegroup() rules to bubble up the files
needed to build Skia (all as one big cc_library call) and
cc_library rules to bubble up the other components needed to build.
For example, //src/ports/SkFontHost_FreeType.cpp needs FreeType,
but only if we are compiling Skia with that type of font
support. With the new organization structure in this CL,
//src/ports/BUILD.bazel should have the logic that determines
if the cpp file should be included in the build of Skia and
if it is, that the Skia build should depend on //third_party:freetype2
Another example is //src/gpu/ganesh/BUILD.bazel, which
chooses which of the dawn, gl, vulkan, etc backend sources,
and the associated dependencies to include in the build.
It does not specify what those are, but delegates to the
BUILD.bazel files in the subdirectories housing the
backend-specific code.
The structure guidelines for BUILD.bazel files are as follows:
- Have a filegroup() called "hdrs" (for public headers) or
"srcs" (for private headers and all .cpp files) that is
visible to the parent directory. This should list the
files from the containing directory to include in the
build.
See //include/core/BUILD.bazel and //src/effects/BUILD.bazel
as examples.
- filegroup() rules can list a child directory's "hdrs"
or "srcs" in their "srcs" attributes, but should not contain
select statements pertaining to child directory files.
See //include/gpu/BUILD.bazel and //src/gpu/ganesh/BUILD.bazel
as examples.
- May have a cc_library() called "deps". This can specify
dependencies, cc_opts, and linkopts, but not srcs or hdrs. [1]
See //src/codec/BUILD.bazel as an example. These should
be visible to the parent directory.
- "hdrs", "srcs", and "deps" for the primary Skia build
(currently called "skia_core") should bubble up through
//include/BUILD.bazel and //src/BUILD.bazel, one directory
at a time.
This CL demonstrates a very basic build of Skia with many features
turned off (CPU only, no fonts, no codecs). Follow-on CLs will
add to these rules as more targets are supported. See bazel/Makefile
for the builds that work with just this CL.
Suggested Review Order:
- //BUILD.bazel to see the very small skia_core rule which
delegates all the logic down stack. Note that it has a
dependency on //bazel:defines_from_flags which will set
all the defines listed there when compiling all the
.cpp and .h files in skia_core *and* anything that depends
on skia_core, but *not* //src:deps.
- //include/BUILD.bazel and other BUILD.bazel files in the
subdirectories of that folder. Note that the filegroups in
//include/private/... are called "srcs" to be similar to
how Bazel wants "private headers" to be in the "srcs" of
cc_library, cc_binary, etc. and only public headers are
to be in "hdrs" [2].
- //src/BUILD.bazel and other BUILD.bazel files in the
subdirectories of that folder. //src/gpu/ganesh/...
will be filled in for dawn, vulkan, and GL in the next CL.
- //PRESUBMIT.py, which adds a check that runs buildifier [3]
on modified BUILD.bazel files to make sure they stay
consistently formatted.
- //bazel/... to see the new option I added to make sksl
opt-in or opt-out, so one could build Skia with sksl,
but not with a gpu backend.
- Misc .h and .cpp files, whose includes were removed if
unnecessary or #ifdef'd out to make the minimal build
work without GPU or SkSL includes.
- //bazel/Makefile to see the builds that work with this CL.
[1] Setting srcs or hdrs is error-prone at best, because those
files will be compiled with a different set of defines than
the rest of skia_core, because they wouldn't depend on
//bazel:defines_from_flags.
[2] https://bazel.build/reference/be/c-cpp#cc_library.hdrs
[3] https://github.com/bazelbuild/buildtools/releases
Change-Id: I5e0e3ae01ad42d672506d5aad1239f2512188191
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/543977
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-05-27 17:56:03 +00:00
|
|
|
bazelisk build //experimental/bazel_test/... --config=clang_linux
|
|
|
|
|
bazelisk run //experimental/bazel_test:bazel_test_exe --config=clang_linux
|
2022-05-27 18:47:29 +00:00
|
|
|
bazelisk build //example:hello_world_gl --config=clang_linux
|
|
|
|
|
bazelisk build //example:hello_world_vulkan --config=clang_linux
|
|
|
|
|
bazelisk build //example:hello_world_dawn --config=clang_linux
|
|
|
|
|
bazelisk build //example:vulkan_basic --config=clang_linux
|
2022-05-27 19:03:36 +00:00
|
|
|
bazelisk build //src/sksl/lex:sksllex --config=clang_linux
|
|
|
|
|
bazelisk build //tools/skdiff --config=clang_linux
|
|
|
|
|
bazelisk build //tools/skslc --config=clang_linux
|
2022-05-27 19:12:31 +00:00
|
|
|
bazelisk build //modules/canvaskit:canvaskit_wasm --config=ck_release
|
2022-03-25 18:59:33 +00:00
|
|
|
|
|
|
|
|
rbe_known_good_builds:
|
2022-06-01 18:45:46 +00:00
|
|
|
bazelisk build //:skia_public --config=linux_rbe --remote_download_minimal
|
|
|
|
|
bazelisk build //:skia_internal --config=linux_rbe --remote_download_minimal
|
[bazel] Add in hierarchical filegroup Bazel rules.
The primary goal of this organization structure is to keep
our top level BUILD.bazel file short, with as little logic
as feasible. The logic required to control which files to
include, which third_party deps are needed, what system libraries
should be linked again, etc, should be in the BUILD.bazel
file best should be as close to the affected files as feasible.
In essence, we use filegroup() rules to bubble up the files
needed to build Skia (all as one big cc_library call) and
cc_library rules to bubble up the other components needed to build.
For example, //src/ports/SkFontHost_FreeType.cpp needs FreeType,
but only if we are compiling Skia with that type of font
support. With the new organization structure in this CL,
//src/ports/BUILD.bazel should have the logic that determines
if the cpp file should be included in the build of Skia and
if it is, that the Skia build should depend on //third_party:freetype2
Another example is //src/gpu/ganesh/BUILD.bazel, which
chooses which of the dawn, gl, vulkan, etc backend sources,
and the associated dependencies to include in the build.
It does not specify what those are, but delegates to the
BUILD.bazel files in the subdirectories housing the
backend-specific code.
The structure guidelines for BUILD.bazel files are as follows:
- Have a filegroup() called "hdrs" (for public headers) or
"srcs" (for private headers and all .cpp files) that is
visible to the parent directory. This should list the
files from the containing directory to include in the
build.
See //include/core/BUILD.bazel and //src/effects/BUILD.bazel
as examples.
- filegroup() rules can list a child directory's "hdrs"
or "srcs" in their "srcs" attributes, but should not contain
select statements pertaining to child directory files.
See //include/gpu/BUILD.bazel and //src/gpu/ganesh/BUILD.bazel
as examples.
- May have a cc_library() called "deps". This can specify
dependencies, cc_opts, and linkopts, but not srcs or hdrs. [1]
See //src/codec/BUILD.bazel as an example. These should
be visible to the parent directory.
- "hdrs", "srcs", and "deps" for the primary Skia build
(currently called "skia_core") should bubble up through
//include/BUILD.bazel and //src/BUILD.bazel, one directory
at a time.
This CL demonstrates a very basic build of Skia with many features
turned off (CPU only, no fonts, no codecs). Follow-on CLs will
add to these rules as more targets are supported. See bazel/Makefile
for the builds that work with just this CL.
Suggested Review Order:
- //BUILD.bazel to see the very small skia_core rule which
delegates all the logic down stack. Note that it has a
dependency on //bazel:defines_from_flags which will set
all the defines listed there when compiling all the
.cpp and .h files in skia_core *and* anything that depends
on skia_core, but *not* //src:deps.
- //include/BUILD.bazel and other BUILD.bazel files in the
subdirectories of that folder. Note that the filegroups in
//include/private/... are called "srcs" to be similar to
how Bazel wants "private headers" to be in the "srcs" of
cc_library, cc_binary, etc. and only public headers are
to be in "hdrs" [2].
- //src/BUILD.bazel and other BUILD.bazel files in the
subdirectories of that folder. //src/gpu/ganesh/...
will be filled in for dawn, vulkan, and GL in the next CL.
- //PRESUBMIT.py, which adds a check that runs buildifier [3]
on modified BUILD.bazel files to make sure they stay
consistently formatted.
- //bazel/... to see the new option I added to make sksl
opt-in or opt-out, so one could build Skia with sksl,
but not with a gpu backend.
- Misc .h and .cpp files, whose includes were removed if
unnecessary or #ifdef'd out to make the minimal build
work without GPU or SkSL includes.
- //bazel/Makefile to see the builds that work with this CL.
[1] Setting srcs or hdrs is error-prone at best, because those
files will be compiled with a different set of defines than
the rest of skia_core, because they wouldn't depend on
//bazel:defines_from_flags.
[2] https://bazel.build/reference/be/c-cpp#cc_library.hdrs
[3] https://github.com/bazelbuild/buildtools/releases
Change-Id: I5e0e3ae01ad42d672506d5aad1239f2512188191
Bug: skia:12541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/543977
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2022-05-27 17:56:03 +00:00
|
|
|
bazelisk build //experimental/bazel_test/... --config=linux_rbe --remote_download_minimal
|
|
|
|
|
bazelisk run //experimental/bazel_test:bazel_test_exe --config=linux_rbe --remote_download_toplevel
|
2022-05-27 18:47:29 +00:00
|
|
|
bazelisk build //example:hello_world_gl --config=linux_rbe --remote_download_minimal
|
|
|
|
|
bazelisk build //example:hello_world_vulkan --config=linux_rbe --remote_download_minimal
|
|
|
|
|
bazelisk build //example:hello_world_dawn --config=linux_rbe --remote_download_minimal
|
|
|
|
|
bazelisk build //example:vulkan_basic --config=linux_rbe --remote_download_minimal
|
2022-05-27 19:03:36 +00:00
|
|
|
bazelisk build //src/sksl/lex:sksllex --config=linux_rbe --remote_download_minimal
|
|
|
|
|
bazelisk build //tools/skdiff --config=linux_rbe --remote_download_minimal
|
|
|
|
|
bazelisk build //tools/skslc --config=linux_rbe --remote_download_minimal
|
2022-05-31 13:32:24 +00:00
|
|
|
## TODO(kjlubick) CanvasKit in release mode (i.e. with Closure) requires
|
|
|
|
|
## https://github.com/emscripten-core/emscripten/pull/16640 to land
|
2022-05-27 19:12:31 +00:00
|
|
|
bazelisk build //modules/canvaskit:canvaskit_wasm --compilation_mode dbg --config=linux_rbe \
|
|
|
|
|
--remote_download_minimal
|
2022-03-25 18:59:33 +00:00
|
|
|
|
2022-06-06 13:50:32 +00:00
|
|
|
iwyu_rbe:
|
|
|
|
|
bazelisk build //:skia_public --config=linux_rbe --config=enforce_iwyu \
|
|
|
|
|
--keep_going --remote_download_minimal
|
|
|
|
|
bazelisk build //example:hello_world_gl --config=linux_rbe --config=enforce_iwyu \
|
|
|
|
|
--keep_going --remote_download_minimal
|
|
|
|
|
bazelisk build //example:hello_world_vulkan --config=linux_rbe --config=enforce_iwyu \
|
|
|
|
|
--keep_going --remote_download_minimal
|
|
|
|
|
bazelisk build //example:hello_world_dawn --config=linux_rbe --config=enforce_iwyu \
|
|
|
|
|
--keep_going --remote_download_minimal
|
|
|
|
|
bazelisk build //example:vulkan_basic --config=linux_rbe --config=enforce_iwyu \
|
|
|
|
|
--keep_going --remote_download_minimal
|
|
|
|
|
|
|
|
|
|
iwyu:
|
|
|
|
|
bazelisk build //:skia_public --config=clang_linux --config=enforce_iwyu \
|
|
|
|
|
--keep_going
|
|
|
|
|
bazelisk build //example:hello_world_gl --config=clang_linux --config=enforce_iwyu \
|
|
|
|
|
--keep_going
|
|
|
|
|
bazelisk build //example:hello_world_vulkan --config=clang_linux --config=enforce_iwyu \
|
|
|
|
|
--keep_going
|
|
|
|
|
bazelisk build //example:hello_world_dawn --config=clang_linux --config=enforce_iwyu \
|
|
|
|
|
--keep_going
|
|
|
|
|
bazelisk build //example:vulkan_basic --config=clang_linux --config=enforce_iwyu \
|
|
|
|
|
--keep_going
|