skia2/resources/sksl/shared/ConstArray.sksl

const half test[4] = half[4](1, 2, 3, 4);

void main() {
    sk_FragColor = half4(test[0], test[1], test[2], test[3]);
}
Enforce (valid) array sizes in many more places Unsized arrays are now allowed in exactly one place: On the declaration of an interface block. This satisfies the one existing use-case, which is the gl_in (sk_in) declaration for geometry shaders. There is no other useful scenario, and most of our backends don't support them anyway. Several spots were using less strict checks when attaching sizes to arrays, allowing for zero or negative-sized arrays, so those are all fixed now. The existing tests that initialize arrays are still a problem, because Metal doesn't support that (neither does GLES2). Also, ArrayConstructors has gone from generating an error in the Vulkan backend, to invalid SPIR-V. Bug: skia:11013 Bug: skia:11127 Change-Id: Ib08dfe9aeec96bf605661665d6f166419d27e8bc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/353817 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com> 2021-01-14 19:18:10 +00:00			`const half test[4] = half[4](1, 2, 3, 4);`
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2020-09-14 21:30:13 +00:00
			`void main() {`
			`sk_FragColor = half4(test[0], test[1], test[2], test[3]);`
			`}`