AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2bfee21d94
skia2/gn/flutter_defines.gni

29 lines
749 B
Plaintext
Raw Normal View History

Add GN arg to allow Flutter-specific API guards Bug: skia: Change-Id: I5a97da664626eebf30bba3f391fff0d8b9e62ea5 Reviewed-on: https://skia-review.googlesource.com/23042 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-07-13 19:50:03 +00:00
# Copyright 2017 Google Inc.
#
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
Preemptively disable upcoming Skia features in Flutter/Fuchsia Change-Id: I8be706846fecde704a29ba1dda0d7329046980b4 Reviewed-on: https://skia-review.googlesource.com/69840 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2017-11-10 13:22:28 +00:00
flutter_defines = [
Reduce opList splitting by default in Skia Local Skia and DDL recording will always attempt to reduce opList splitting. Android, Flutter, Google3 and non-DDL Chrome will not. Note that this is a bit aggressive. Intermediate flushes based on memory usage have not yet been implemented. The plan is to run this locally in Skia until the next Chrome branch and then enable it everywhere else (when intermediate flushes have been implemented). OpList splitting reduction in Chrome is disabled in the following Chrome-side CL: https://chromium-review.googlesource.com/c/chromium/src/+/1588756/ (Disable opList splitting reduction in Skia) It is disabled in Android in: https://googleplex-android-review.git.corp.google.com/c/platform/external/skia/+/7259923 (Update #defines to suppress Ganesh features in SkUserConfigManual.h) It is disabled in Flutter and Google3 w/in this CL. Change-Id: I59ff448d2c42629fab6cffccb2894d030c73431d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211101 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-05-01 14:43:56 +00:00
"SK_DISABLE_REDUCE_OPLIST_SPLITTING",
Reland "disable DAA and AAA in flutter" This is a reland of 14211203162bb2d8f13b6393cd4dba268c5441e6 PS2 rescopes a variable tighter, and reindents to make the #if-#else logic stand out a little more clearly. Original change's description: > disable DAA and AAA in flutter > > If we're looking to cut out unnecessary code in Flutter, > SkScan_AAA always jumps out to me as a bunch of code that > is not logically required for GPU rendering. > > Looking at a treemap[1], SkScan_AAA is the biggest chunk of > code under src/core. I don't see DAA... maybe it's small, > or somehow already trimmed? Anyway, I cut it out too. > > [1] https://storage.googleapis.com/flutter_infra/flutter/c8755d74c17e949ee7c19cd114f084b465dac632/android-arm-release/sizes/index.html > > Change-Id: I4acf4aec365504c90e6b66393fd265a399f0f525 > Reviewed-on: https://skia-review.googlesource.com/c/159760 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> Change-Id: I6770781c26a0a581ed0df33c404386415472bed5 Reviewed-on: https://skia-review.googlesource.com/c/161581 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-04 19:28:07 +00:00
move this define to be with its friends in flutter_defines.gni I'd like to get to the point where the only Flutter-specific configuration is defines, in flutter_defines.gni. Change-Id: Idda141c4dcdb5f18275e29d2ab60bb73bf416d59 Reviewed-on: https://skia-review.googlesource.com/c/169102 Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-11-07 14:38:55 +00:00
# Flutter always wants this https://github.com/flutter/flutter/issues/11402
"SK_ENABLE_DUMP_GPU",
Reland "disable DAA and AAA in flutter" This is a reland of 14211203162bb2d8f13b6393cd4dba268c5441e6 PS2 rescopes a variable tighter, and reindents to make the #if-#else logic stand out a little more clearly. Original change's description: > disable DAA and AAA in flutter > > If we're looking to cut out unnecessary code in Flutter, > SkScan_AAA always jumps out to me as a bunch of code that > is not logically required for GPU rendering. > > Looking at a treemap[1], SkScan_AAA is the biggest chunk of > code under src/core. I don't see DAA... maybe it's small, > or somehow already trimmed? Anyway, I cut it out too. > > [1] https://storage.googleapis.com/flutter_infra/flutter/c8755d74c17e949ee7c19cd114f084b465dac632/android-arm-release/sizes/index.html > > Change-Id: I4acf4aec365504c90e6b66393fd265a399f0f525 > Reviewed-on: https://skia-review.googlesource.com/c/159760 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> Change-Id: I6770781c26a0a581ed0df33c404386415472bed5 Reviewed-on: https://skia-review.googlesource.com/c/161581 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-04 19:28:07 +00:00
# Remove software rasterizers to save some code size.
"SK_DISABLE_AAA",
disable lowp raster pipeline stages in Flutter Flutter barely needs the float stages, and probably doesn't care at all about these. Change-Id: I663e5496f4f9a6c689c1ef0137b2318177fb3760 Reviewed-on: https://skia-review.googlesource.com/c/161582 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-10-12 02:05:14 +00:00
ignore SK_DISABLE_READBUFFER Its effect is small and we want to rely on SkReadBuffer being available. Size changes: - canvaskit uncompressed: 6,864,481 --> 6,864,481 ( no change ) - canvaskit compressed: 2,667,117 --> 2,667,117 ( no change ) - pathkit uncompressed: 329,187 --> 330,679 (+ 1.5K, +0.5%) - pathkit compressed: 134,158 --> 134,672 (+ 0.5K, +0.4%) - flutter : 1,302,108 --> 1,322,568 (+20.0K, +1.6%) The Flutter change is the biggest mystery, as bloaty only pegs SkReadBuffer as 3.9K. The rest must come from other files including SkReadBuffer.h not being able to see and inline away SkReadBuffer routines? Feels like SK_DISABLE_EFFECT_DESERIALIZATION isn't trimming enough? PS 4-6 have an idea to push SK_DISABLE_EFFECT_DESERIALIZATION further. Change-Id: Ifda3ccb82dd0636cfed6bb826fb185a7bca2cbe0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295061 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-06-08 19:10:29 +00:00
# Flutter doesn't deserialize effects.
Reland "simplify disabling effect deserialization" This reverts commit 34d7a163a4a749d6e91cf768d0f1767e8da6ceb2. Reason for revert: ok now? Original change's description: > Revert "simplify disabling effect deserialization" > > This reverts commit 5bbf790b5beeb2ed74f04551502259b54ac5556f. > > Reason for revert: flutter GN needs some love > > Original change's description: > > simplify disabling effect deserialization > > > > Switch to a simple #define instead of conditional build targets. > > > > No one changes skia_enable_effects or skia_enable_effects_imagefilters, > > so we can merge all that together back into :skia. > > > > Change-Id: I2985f95ee89149ddc687dc31f4c6bf35cb3a93c7 > > Reviewed-on: https://skia-review.googlesource.com/c/169220 > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > Commit-Queue: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,kjlubick@google.com > > Change-Id: I3b818418d303dbc6d2a926a19df64a68499f0ec3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/169222 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,kjlubick@google.com Cq-Include-Trybots: skia.primary:Build-Debian9-Clang-arm-Release-Flutter_Android Change-Id: I534346c3ef3561a871f1af6df976bfee0b48014a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/169640 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2018-11-08 12:08:05 +00:00
"SK_DISABLE_EFFECT_DESERIALIZATION",
stub SkReadBuffer when SK_DISABLE_READBUFFER This seems like a way to disable SkReadBuffer that won't require other preprocessor checks in the various effects. Disable SkReadBuffer in Flutter too, for about 20K. Change-Id: I87039b67d90ad372a21940d7e96fc46bf5114bfd Reviewed-on: https://skia-review.googlesource.com/c/165021 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-25 15:35:56 +00:00
stage changing didCocnat44 virtual SK_SUPPORT_LEGACY_DIDCONCAT44 Change-Id: Ie208c245d7121fddc693a7d3c5d6866441c27433 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281864 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-04-07 01:32:43 +00:00
# Staging
Revert "Revert "move onto new factories for SkMatrix"" This reverts commit c80ee456adf664c4a62fa2ccaeaf157c723ed656. fix: update flutter's gn file to add guard Change-Id: Iac5171c8475d9a862d06255dab1c6f38f10de2f2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/291361 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-05-21 16:11:27 +00:00
"SK_SUPPORT_LEGACY_MATRIX_FACTORIES",
stage changing didCocnat44 virtual SK_SUPPORT_LEGACY_DIDCONCAT44 Change-Id: Ie208c245d7121fddc693a7d3c5d6866441c27433 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281864 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-04-07 01:32:43 +00:00
disable lowp raster pipeline stages in Flutter Flutter barely needs the float stages, and probably doesn't care at all about these. Change-Id: I663e5496f4f9a6c689c1ef0137b2318177fb3760 Reviewed-on: https://skia-review.googlesource.com/c/161582 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-10-12 02:05:14 +00:00
# Fast low-precision software rendering isn't a priority for Flutter.
disable legacy shaders in flutter All of Flutter's non-test drawing is done with Ganesh, and the few shaders that are legacy-only are not used by Flutter. This should cut a bunch of essentially-dead code from Flutter, though some of the Flutter test images may change because those test images are software rasterized. Hopefully nothing should look terribly different. Looks like this cuts ~27K from Flutter. Change-Id: I4c8078db17fe9d24b15ed9d8c6adb528a382f02a Reviewed-on: https://skia-review.googlesource.com/c/163165 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-17 17:51:30 +00:00
"SK_DISABLE_LEGACY_SHADERCONTEXT",
disable lowp raster pipeline stages in Flutter Flutter barely needs the float stages, and probably doesn't care at all about these. Change-Id: I663e5496f4f9a6c689c1ef0137b2318177fb3760 Reviewed-on: https://skia-review.googlesource.com/c/161582 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-10-12 02:05:14 +00:00
"SK_DISABLE_LOWP_RASTER_PIPELINE",
cut out the rest of blend modes in flutter SkXfermode_opts.h is moot when SK_FORCE_RASTER_PIPELINE_BLITTER is defined. There are a couple other blitters and routines and things that are also just there for 565/8888 performance, so I think we can just turn on SK_FORCE_RASTER_PIPELINE_BLITTER and start guarding the rest of them similarly. Looks like maybe cuts another 13K? Change-Id: Ib3894b07da649a93e93b6a4cb7686772a57b6def Reviewed-on: https://skia-review.googlesource.com/c/164181 Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2018-10-22 13:48:01 +00:00
"SK_FORCE_RASTER_PIPELINE_BLITTER",
Preemptively disable upcoming Skia features in Flutter/Fuchsia Change-Id: I8be706846fecde704a29ba1dda0d7329046980b4 Reviewed-on: https://skia-review.googlesource.com/69840 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2017-11-10 13:22:28 +00:00
]
Only define SK_GL for Flutter on non-Fuchsia platforms. Change-Id: I71dd3324a6d3b051b164bc066c03cb2971106757 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/254498 Auto-Submit: Jim Graham <jimgraham@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2019-11-13 23:12:07 +00:00
if (!is_fuchsia) {
flutter_defines += [ "SK_GL" ]
}
Reference in New Issue Copy Permalink