AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3c74a5357a
skia2/tests/sksl/inliner/ExponentialGrowthStandaloneSettings.glsl

582 lines
13 KiB
Plaintext
Raw Normal View History

Stop the inliner after it has inlined 2500 statements in a program. This prevents OOMing when given a pathological input, but is large enough that almost all inputs should continue to compile as-is. Change-Id: If5c46711b886ee08495bfd09af537e9dc7ea5649 Bug: skia:10945, oss-fuzz:27442 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334838 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-13 21:13:18 +00:00
out vec4 sk_FragColor;
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fn6_v() {
Revert "Inline functions of the form 'return (expr)' only." This reverts commit 92748af1a5051e9fe329c8200f0fa3b47aadbdd7. Reason for revert: SkSLCommaSideEffects_GPU crashing on Android Original change's description: > Inline functions of the form 'return (expr)' only. > > This drastically reduces the number of functions which we allow to be > inlined. If this change does not hurt our performance, it will allow us > to trivially remove hundreds of LOC. All current data leads us to > believe that it may affect the Mali 400 but is highly unlikely to change > results on any other device in the tree. > > More info: http://go/optimization-in-sksl-inliner > > Change-Id: Ia6b706742ce5407453e0e697b6c1f9201084c0e8 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384858 > Auto-Submit: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I6a670dacaa58fe3386ff50375ac6d1cac4fd7f2c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385161 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-03-15 22:08:38 +00:00
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
false;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
false;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
false;
Remove unnecessary Blocks from the inliner. If we aren't wrapping the inlined function body in a loop, there's no need to add a scopeless Block; we've already got one. This doesn't affect the final output meaningfully--it just suppresses a newline--but it's one fewer IRNode allocation. Change-Id: Ib7b0014e908586d8acfcf6c23520873fad31d0b7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345163 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-17 15:43:58 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fn7_v() {
Revert "Inline functions of the form 'return (expr)' only." This reverts commit 92748af1a5051e9fe329c8200f0fa3b47aadbdd7. Reason for revert: SkSLCommaSideEffects_GPU crashing on Android Original change's description: > Inline functions of the form 'return (expr)' only. > > This drastically reduces the number of functions which we allow to be > inlined. If this change does not hurt our performance, it will allow us > to trivially remove hundreds of LOC. All current data leads us to > believe that it may affect the Mali 400 but is highly unlikely to change > results on any other device in the tree. > > More info: http://go/optimization-in-sksl-inliner > > Change-Id: Ia6b706742ce5407453e0e697b6c1f9201084c0e8 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384858 > Auto-Submit: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I6a670dacaa58fe3386ff50375ac6d1cac4fd7f2c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385161 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-03-15 22:08:38 +00:00
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
sk_FragColor.x = 0.0;
false;
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
fn6_v();
fn6_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fn8_v() {
fn7_v();
fn7_v();
fn7_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fn9_v() {
fn8_v();
fn8_v();
fn8_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnA_v() {
fn9_v();
fn9_v();
fn9_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnB_v() {
fnA_v();
fnA_v();
fnA_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnC_v() {
fnB_v();
fnB_v();
fnB_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnD_v() {
fnC_v();
fnC_v();
fnC_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnE_v() {
fnD_v();
fnD_v();
fnD_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnF_v() {
fnE_v();
fnE_v();
fnE_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnG_v() {
fnF_v();
fnF_v();
fnF_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnH_v() {
fnG_v();
fnG_v();
fnG_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnI_v() {
fnH_v();
fnH_v();
fnH_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnJ_v() {
fnI_v();
fnI_v();
fnI_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnK_v() {
fnJ_v();
fnJ_v();
fnJ_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnL_v() {
fnK_v();
fnK_v();
fnK_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnM_v() {
fnL_v();
fnL_v();
fnL_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
void fnN_v() {
fnM_v();
fnM_v();
fnM_v();
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}
void main() {
Mangle function names in GLSL. This will be implemented in Metal and SPIR-V in followup CLs. Change-Id: I397b4db40b15dd54cf1d8a17f414c3fe184b48d2 Bug: skia:10851 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387638 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-22 15:43:11 +00:00
fnN_v();
Stop the inliner after it has inlined 2500 statements in a program. This prevents OOMing when given a pathological input, but is large enough that almost all inputs should continue to compile as-is. Change-Id: If5c46711b886ee08495bfd09af537e9dc7ea5649 Bug: skia:10945, oss-fuzz:27442 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334838 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-13 21:13:18 +00:00
}
Reference in New Issue Copy Permalink