AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3dad80308d
skia2/tests/sksl/shared/golden/OutParams.glsl

4 lines
26 B
Plaintext
Raw Normal View History

Revert "Support out parameters that use a swizzle." This reverts commit 435b4826388cfb05a42efce0c0daf7b10695ad06. Reason for revert: ASAN/UBSAN unhappy. Original change's description: > Support out parameters that use a swizzle. > > This CL also removes the `VariableExpression` class that was briefly > added in a prior CL. This class was intended to support cloning an > expression while changing the refKind of a VariableReference inside of > the expression, but it added state and complexity. In this CL, rather > than track this via extra state, the inliner just recurses into the > expression as needed to find its VariableReference. Since most relevant > expressions are just a VariableReference anyway, this is inexpensive. > > Change-Id: Id4d926b7d7520b5e6ce455446c05a6d59ef62a84 > Bug: skia:10756 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319917 > Commit-Queue: John Stiles <johnstiles@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: Ibdda47607f9e6e7f3a7459915067cf5e20919993 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:10756 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/320220 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-28 15:36:26 +00:00
### Compilation failed:
Update OutParams unit test to demonstrate SkSL failure. Swizzles in combination with out params are currently broken in SkSL. They are fixed in the followup CL at http://review.skia.org/319917 Change-Id: I22d9436a15631e6ee2acf9fc312a8634cf3b5407 Bug: skia:10756 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319918 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-26 03:51:39 +00:00
Add new unit tests for SkSL. These cover: - Properly configured out-params - Invalid/non-lvalue out-params, which currently cause an SkSL crash - Interactions between the inliner and variable swizzles Change-Id: I4874101236084f273e704d8717149b431d813883 Bug: skia:10753 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-23 19:20:01 +00:00
Reference in New Issue Copy Permalink