AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3f5184cfa6
skia2/include/private/BUILD.bazel

555 lines
12 KiB
Python
Raw Normal View History

[infra] Experiment generating BUILD.bazel files This uses the gazelle extension from https://skia-review.googlesource.com/c/buildbot/+/473357 Review Tips: - Ignore any changes to .h or .cpp files. Those have been pulled out into their own CLs. - Start with bazel/macros.bzl. - Read the CL with the generation code, if you haven't already. - Look at third_party/file_map_for_bazel.json. - See experimental/bazel_test for an idea of how a cc_binary would be made. - Spot check one or two of the BUILD.bazel files. This CL generates the "atomic" rules for src/, include/ and modules/skshaper, as a starting point. `bazel build --config clang //include/...` works `bazel build --config clang //src/...` starts compiling, (which verifies that the BUILD.bazel files are all valid), but runs into errors because not all third_party deps have been resolved, and there are some files missing from the toolchain still (e.g. EGL headers). Change-Id: Ib7e0fb0efdb9f08655f06cbc56e9bb4cf416294b Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474240 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 14:01:28 +00:00
load("//bazel:macros.bzl", "generated_cc_atom")
generated_cc_atom(
name = "GrContext_Base_hdr",
hdrs = ["GrContext_Base.h"],
visibility = ["//:__subpackages__"],
deps = [
"//include/core:SkRefCnt_hdr",
"//include/gpu:GrBackendSurface_hdr",
"//include/gpu:GrContextOptions_hdr",
"//include/gpu:GrTypes_hdr",
],
)
generated_cc_atom(
name = "GrD3DTypesMinimal_hdr",
hdrs = ["GrD3DTypesMinimal.h"],
visibility = ["//:__subpackages__"],
deps = [
"//include/core:SkRefCnt_hdr",
"//include/gpu:GrTypes_hdr",
],
)
generated_cc_atom(
name = "GrDawnTypesPriv_hdr",
hdrs = ["GrDawnTypesPriv.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/gpu/dawn:GrDawnTypes_hdr"],
)
generated_cc_atom(
name = "GrGLTypesPriv_hdr",
hdrs = ["GrGLTypesPriv.h"],
visibility = ["//:__subpackages__"],
deps = [
"//include/core:SkRefCnt_hdr",
"//include/gpu/gl:GrGLTypes_hdr",
],
)
generated_cc_atom(
name = "GrImageContext_hdr",
hdrs = ["GrImageContext.h"],
visibility = ["//:__subpackages__"],
deps = [
":GrContext_Base_hdr",
[bazel] Regenerate files and build with c++17 See toolchain/clang_toolchain_config.bzl for the c++17 switch. Most of the other changes were automatically generated (with the exception of //third_party). Change-Id: I8c0f4b29b5967da3f48b17eb298a7e92156277ac Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502407 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2022-01-31 21:12:44 +00:00
":SingleOwner_hdr",
[infra] Experiment generating BUILD.bazel files This uses the gazelle extension from https://skia-review.googlesource.com/c/buildbot/+/473357 Review Tips: - Ignore any changes to .h or .cpp files. Those have been pulled out into their own CLs. - Start with bazel/macros.bzl. - Read the CL with the generation code, if you haven't already. - Look at third_party/file_map_for_bazel.json. - See experimental/bazel_test for an idea of how a cc_binary would be made. - Spot check one or two of the BUILD.bazel files. This CL generates the "atomic" rules for src/, include/ and modules/skshaper, as a starting point. `bazel build --config clang //include/...` works `bazel build --config clang //src/...` starts compiling, (which verifies that the BUILD.bazel files are all valid), but runs into errors because not all third_party deps have been resolved, and there are some files missing from the toolchain still (e.g. EGL headers). Change-Id: Ib7e0fb0efdb9f08655f06cbc56e9bb4cf416294b Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474240 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 14:01:28 +00:00
],
)
generated_cc_atom(
name = "GrMockTypesPriv_hdr",
hdrs = ["GrMockTypesPriv.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/gpu/mock:GrMockTypes_hdr"],
)
generated_cc_atom(
name = "GrMtlTypesPriv_hdr",
hdrs = ["GrMtlTypesPriv.h"],
visibility = ["//:__subpackages__"],
deps = [
"//include/gpu:GrTypes_hdr",
"//include/gpu/mtl:GrMtlTypes_hdr",
],
)
generated_cc_atom(
name = "GrTypesPriv_hdr",
hdrs = ["GrTypesPriv.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkImageInfoPriv_hdr",
":SkMacros_hdr",
"//include/core:SkImageInfo_hdr",
"//include/core:SkImage_hdr",
"//include/core:SkPath_hdr",
"//include/core:SkRefCnt_hdr",
"//include/gpu:GrTypes_hdr",
],
)
generated_cc_atom(
name = "GrVkTypesPriv_hdr",
hdrs = ["GrVkTypesPriv.h"],
visibility = ["//:__subpackages__"],
deps = [
"//include/core:SkRefCnt_hdr",
"//include/gpu/vk:GrVkTypes_hdr",
],
)
generated_cc_atom(
name = "SkBitmaskEnum_hdr",
hdrs = ["SkBitmaskEnum.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkChecksum_hdr",
hdrs = ["SkChecksum.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkNoncopyable_hdr",
":SkOpts_spi_hdr",
":SkTLogic_hdr",
"//include/core:SkString_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkColorData_hdr",
hdrs = ["SkColorData.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkNx_hdr",
":SkTo_hdr",
"//include/core:SkColorPriv_hdr",
"//include/core:SkColor_hdr",
],
)
generated_cc_atom(
name = "SkDeque_hdr",
hdrs = ["SkDeque.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/core:SkTypes_hdr"],
)
generated_cc_atom(
name = "SkEncodedInfo_hdr",
hdrs = ["SkEncodedInfo.h"],
visibility = ["//:__subpackages__"],
deps = [
"//include/core:SkData_hdr",
"//include/core:SkImageInfo_hdr",
"//include/third_party/skcms:skcms_hdr",
],
)
generated_cc_atom(
name = "SkFixed_hdr",
hdrs = ["SkFixed.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkSafe_math_hdr",
":SkTPin_hdr",
":SkTo_hdr",
"//include/core:SkScalar_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkFloatBits_hdr",
hdrs = ["SkFloatBits.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkSafe_math_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkFloatingPoint_hdr",
hdrs = ["SkFloatingPoint.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkFloatBits_hdr",
":SkSafe_math_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkHalf_hdr",
hdrs = ["SkHalf.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkNx_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkIDChangeListener_hdr",
hdrs = ["SkIDChangeListener.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkMutex_hdr",
":SkTDArray_hdr",
"//include/core:SkRefCnt_hdr",
],
)
generated_cc_atom(
name = "SkImageInfoPriv_hdr",
hdrs = ["SkImageInfoPriv.h"],
visibility = ["//:__subpackages__"],
deps = [
"//include/core:SkColor_hdr",
"//include/core:SkImageInfo_hdr",
],
)
generated_cc_atom(
name = "SkMacros_hdr",
hdrs = ["SkMacros.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkMalloc_hdr",
hdrs = ["SkMalloc.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/core:SkTypes_hdr"],
)
generated_cc_atom(
name = "SkMutex_hdr",
hdrs = ["SkMutex.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkMacros_hdr",
":SkSemaphore_hdr",
":SkThreadAnnotations_hdr",
":SkThreadID_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkNoncopyable_hdr",
hdrs = ["SkNoncopyable.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/core:SkTypes_hdr"],
)
generated_cc_atom(
name = "SkNx_hdr",
hdrs = ["SkNx.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkNx_neon_hdr",
":SkNx_sse_hdr",
":SkSafe_math_hdr",
"//include/core:SkScalar_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkNx_neon_hdr",
hdrs = ["SkNx_neon.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkNx_sse_hdr",
hdrs = ["SkNx_sse.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/core:SkTypes_hdr"],
)
generated_cc_atom(
name = "SkOnce_hdr",
hdrs = ["SkOnce.h"],
visibility = ["//:__subpackages__"],
deps = [":SkThreadAnnotations_hdr"],
)
generated_cc_atom(
name = "SkOpts_spi_hdr",
hdrs = ["SkOpts_spi.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/core:SkTypes_hdr"],
)
generated_cc_atom(
name = "SkPathRef_hdr",
hdrs = ["SkPathRef.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkIDChangeListener_hdr",
":SkMutex_hdr",
":SkTDArray_hdr",
":SkTemplates_hdr",
":SkTo_hdr",
"//include/core:SkMatrix_hdr",
"//include/core:SkPoint_hdr",
"//include/core:SkRect_hdr",
"//include/core:SkRefCnt_hdr",
],
)
generated_cc_atom(
name = "SkSLDefines_hdr",
hdrs = ["SkSLDefines.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkTArray_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkSLIRNode_hdr",
hdrs = ["SkSLIRNode.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkSLString_hdr",
":SkTArray_hdr",
[includes] Enforce IWYU on sksl code PS1 regenerates the Bazel files. Use it as the base change when comparing patchsets. IWYU seems to do a good job of working with MyFile.cpp and MyFile.h, but if there is just a MyHeader.h, it doesn't always seem to throw errors if the includes aren't correct. This was observed with include/sksl/DSL.h This might be due to the fact that headers are not compiled on their own, so they are never sent directly to the IWYU binary. This change sets enforce_iwyu_on_package() on the all sksl packages and then fixes the includes until all those checks are happy. There were a few files that needed fixes outside of the sksl folder. Examples include: - src/gpu/effects/GrConvexPolyEffect.cpp - tests/SkSLDSLTest.cpp To really enforce this, we need to add a CI/CQ job that runs bazel build //example:hello_world_gl --config=clang \ --sandbox_base=/dev/shm --features skia_enforce_iwyu If that failed, a dev could make the changes described in the logs and/or run the command locally to see those prescribed fixes. I had to add several entries to toolchain/IWYU_mapping.imp in order to fix some private includes and other atypical choices. I tried adding a rule there to allow inclusion of SkTypes.h to make sure defines like SK_SUPPORT_GPU, but could not get it to work for all cases, so I deferred to using the IWYU pragma: keep (e.g. SkSLPipelineStageCodeGenerator.h) Change-Id: I4c3e536d8e69ff7ff2d26fe61a525a6c2e80db06 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522256 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-03-18 20:40:58 +00:00
"//include/sksl:SkSLPosition_hdr",
[infra] Experiment generating BUILD.bazel files This uses the gazelle extension from https://skia-review.googlesource.com/c/buildbot/+/473357 Review Tips: - Ignore any changes to .h or .cpp files. Those have been pulled out into their own CLs. - Start with bazel/macros.bzl. - Read the CL with the generation code, if you haven't already. - Look at third_party/file_map_for_bazel.json. - See experimental/bazel_test for an idea of how a cc_binary would be made. - Spot check one or two of the BUILD.bazel files. This CL generates the "atomic" rules for src/, include/ and modules/skshaper, as a starting point. `bazel build --config clang //include/...` works `bazel build --config clang //src/...` starts compiling, (which verifies that the BUILD.bazel files are all valid), but runs into errors because not all third_party deps have been resolved, and there are some files missing from the toolchain still (e.g. EGL headers). Change-Id: Ib7e0fb0efdb9f08655f06cbc56e9bb4cf416294b Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474240 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 14:01:28 +00:00
"//src/sksl:SkSLLexer_hdr",
"//src/sksl:SkSLModifiersPool_hdr",
"//src/sksl:SkSLPool_hdr",
],
)
generated_cc_atom(
name = "SkSLLayout_hdr",
hdrs = ["SkSLLayout.h"],
visibility = ["//:__subpackages__"],
deps = [":SkSLString_hdr"],
)
generated_cc_atom(
name = "SkSLModifiers_hdr",
hdrs = ["SkSLModifiers.h"],
visibility = ["//:__subpackages__"],
[includes] Enforce IWYU on sksl code PS1 regenerates the Bazel files. Use it as the base change when comparing patchsets. IWYU seems to do a good job of working with MyFile.cpp and MyFile.h, but if there is just a MyHeader.h, it doesn't always seem to throw errors if the includes aren't correct. This was observed with include/sksl/DSL.h This might be due to the fact that headers are not compiled on their own, so they are never sent directly to the IWYU binary. This change sets enforce_iwyu_on_package() on the all sksl packages and then fixes the includes until all those checks are happy. There were a few files that needed fixes outside of the sksl folder. Examples include: - src/gpu/effects/GrConvexPolyEffect.cpp - tests/SkSLDSLTest.cpp To really enforce this, we need to add a CI/CQ job that runs bazel build //example:hello_world_gl --config=clang \ --sandbox_base=/dev/shm --features skia_enforce_iwyu If that failed, a dev could make the changes described in the logs and/or run the command locally to see those prescribed fixes. I had to add several entries to toolchain/IWYU_mapping.imp in order to fix some private includes and other atypical choices. I tried adding a rule there to allow inclusion of SkTypes.h to make sure defines like SK_SUPPORT_GPU, but could not get it to work for all cases, so I deferred to using the IWYU pragma: keep (e.g. SkSLPipelineStageCodeGenerator.h) Change-Id: I4c3e536d8e69ff7ff2d26fe61a525a6c2e80db06 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522256 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-03-18 20:40:58 +00:00
deps = [
":SkSLLayout_hdr",
"//include/sksl:SkSLPosition_hdr",
],
[infra] Experiment generating BUILD.bazel files This uses the gazelle extension from https://skia-review.googlesource.com/c/buildbot/+/473357 Review Tips: - Ignore any changes to .h or .cpp files. Those have been pulled out into their own CLs. - Start with bazel/macros.bzl. - Read the CL with the generation code, if you haven't already. - Look at third_party/file_map_for_bazel.json. - See experimental/bazel_test for an idea of how a cc_binary would be made. - Spot check one or two of the BUILD.bazel files. This CL generates the "atomic" rules for src/, include/ and modules/skshaper, as a starting point. `bazel build --config clang //include/...` works `bazel build --config clang //src/...` starts compiling, (which verifies that the BUILD.bazel files are all valid), but runs into errors because not all third_party deps have been resolved, and there are some files missing from the toolchain still (e.g. EGL headers). Change-Id: Ib7e0fb0efdb9f08655f06cbc56e9bb4cf416294b Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474240 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 14:01:28 +00:00
)
generated_cc_atom(
name = "SkSLProgramElement_hdr",
hdrs = ["SkSLProgramElement.h"],
visibility = ["//:__subpackages__"],
deps = [":SkSLIRNode_hdr"],
)
generated_cc_atom(
name = "SkSLProgramKind_hdr",
hdrs = ["SkSLProgramKind.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkSLSampleUsage_hdr",
hdrs = ["SkSLSampleUsage.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/core:SkTypes_hdr"],
)
generated_cc_atom(
name = "SkSLStatement_hdr",
hdrs = ["SkSLStatement.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkSLIRNode_hdr",
":SkSLSymbol_hdr",
],
)
generated_cc_atom(
name = "SkSLString_hdr",
hdrs = ["SkSLString.h"],
visibility = ["//:__subpackages__"],
[includes] Enforce IWYU on sksl code PS1 regenerates the Bazel files. Use it as the base change when comparing patchsets. IWYU seems to do a good job of working with MyFile.cpp and MyFile.h, but if there is just a MyHeader.h, it doesn't always seem to throw errors if the includes aren't correct. This was observed with include/sksl/DSL.h This might be due to the fact that headers are not compiled on their own, so they are never sent directly to the IWYU binary. This change sets enforce_iwyu_on_package() on the all sksl packages and then fixes the includes until all those checks are happy. There were a few files that needed fixes outside of the sksl folder. Examples include: - src/gpu/effects/GrConvexPolyEffect.cpp - tests/SkSLDSLTest.cpp To really enforce this, we need to add a CI/CQ job that runs bazel build //example:hello_world_gl --config=clang \ --sandbox_base=/dev/shm --features skia_enforce_iwyu If that failed, a dev could make the changes described in the logs and/or run the command locally to see those prescribed fixes. I had to add several entries to toolchain/IWYU_mapping.imp in order to fix some private includes and other atypical choices. I tried adding a rule there to allow inclusion of SkTypes.h to make sure defines like SK_SUPPORT_GPU, but could not get it to work for all cases, so I deferred to using the IWYU pragma: keep (e.g. SkSLPipelineStageCodeGenerator.h) Change-Id: I4c3e536d8e69ff7ff2d26fe61a525a6c2e80db06 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522256 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-03-18 20:40:58 +00:00
deps = [
":SkSLDefines_hdr",
"//include/core:SkTypes_hdr",
],
[infra] Experiment generating BUILD.bazel files This uses the gazelle extension from https://skia-review.googlesource.com/c/buildbot/+/473357 Review Tips: - Ignore any changes to .h or .cpp files. Those have been pulled out into their own CLs. - Start with bazel/macros.bzl. - Read the CL with the generation code, if you haven't already. - Look at third_party/file_map_for_bazel.json. - See experimental/bazel_test for an idea of how a cc_binary would be made. - Spot check one or two of the BUILD.bazel files. This CL generates the "atomic" rules for src/, include/ and modules/skshaper, as a starting point. `bazel build --config clang //include/...` works `bazel build --config clang //src/...` starts compiling, (which verifies that the BUILD.bazel files are all valid), but runs into errors because not all third_party deps have been resolved, and there are some files missing from the toolchain still (e.g. EGL headers). Change-Id: Ib7e0fb0efdb9f08655f06cbc56e9bb4cf416294b Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474240 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 14:01:28 +00:00
)
generated_cc_atom(
name = "SkSLSymbol_hdr",
hdrs = ["SkSLSymbol.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkSLIRNode_hdr",
":SkSLProgramElement_hdr",
],
)
generated_cc_atom(
name = "SkSafe32_hdr",
hdrs = ["SkSafe32.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/core:SkTypes_hdr"],
)
generated_cc_atom(
name = "SkSafe_math_hdr",
hdrs = ["SkSafe_math.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkSemaphore_hdr",
hdrs = ["SkSemaphore.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkOnce_hdr",
":SkThreadAnnotations_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkShadowFlags_hdr",
hdrs = ["SkShadowFlags.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkSpinlock_hdr",
hdrs = ["SkSpinlock.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkThreadAnnotations_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkTArray_hdr",
hdrs = ["SkTArray.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkMalloc_hdr",
":SkSafe32_hdr",
":SkTLogic_hdr",
":SkTemplates_hdr",
":SkTo_hdr",
"//include/core:SkMath_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkTDArray_hdr",
hdrs = ["SkTDArray.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkMalloc_hdr",
":SkTo_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkTFitsIn_hdr",
hdrs = ["SkTFitsIn.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkTHash_hdr",
hdrs = ["SkTHash.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkChecksum_hdr",
":SkTemplates_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkTLogic_hdr",
hdrs = ["SkTLogic.h"],
visibility = ["//:__subpackages__"],
deps = [":SkTo_hdr"],
)
generated_cc_atom(
name = "SkTPin_hdr",
hdrs = ["SkTPin.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkTemplates_hdr",
hdrs = ["SkTemplates.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkMalloc_hdr",
":SkTLogic_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkThreadAnnotations_hdr",
hdrs = ["SkThreadAnnotations.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkThreadID_hdr",
hdrs = ["SkThreadID.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/core:SkTypes_hdr"],
)
generated_cc_atom(
name = "SkTo_hdr",
hdrs = ["SkTo.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkTFitsIn_hdr",
"//include/core:SkTypes_hdr",
],
)
generated_cc_atom(
name = "SkVx_hdr",
hdrs = ["SkVx.h"],
visibility = ["//:__subpackages__"],
)
generated_cc_atom(
name = "SkWeakRefCnt_hdr",
hdrs = ["SkWeakRefCnt.h"],
[infra] Add initial Bazel rules and files These rules can be used to build our GMs on WASM+WebGL and libskia.a with just the CPU backend (and most other features turned off). This can be done with the following commands: - bazel build //modules/canvaskit:gm-bindings-wasm --gpu_backend=gl_backend --with_gl_standard=webgl_standard - bazel build :skia-core --config clang This pivots slightly from http://review.skia.org/463517 by using config_settings [1] instead of platforms for the optional features that we control. This pivot was suggested in [2] We have BUILD.bazel files in many of the subdirectories that specify filegroups for the appropriate files. In an effort to make //BUILD.bazel more readable, it is the responsibility of these subfolders to deal with conditionally including certain .h or .cpp files. This is done using select statements and config_settings or platform constraints as necessary. For example, src/gpu/BUILD.bazel will different private filegroups for each of the supported gpu backends [3] and a more-visible filegroup called "srcs" that has the right selection of the private files to be used for compilation. An effort has been made to avoid using glob() in our BUILD.bazel files. These file lists were made by using `ls -1` and some regex to add in quotes. We might want to make a helper script to assist with that, if necessary. To specify which options we have, the settings in //bazel/common_config_settings/BUILD.bazel have been redesigned. They make use of a macro `string_flag_with_values` that removes the boilerplate. Patchset 36 shows what the file looks like w/o the macro. The top level BUILD.bazel file will still need to use some logic to handle defines, because local_defines is a list of strings, not a list of labels [4]. Suggested Review Order: - WORKSPACE.bazel to see the new dependencies on the emsdk toolchain and bazel_skylib - bazel/common_config_settings/* to see the few settings defined (we have more to define, see BUILD.gn and //gn/skia.gni for ideas) - BUILD.bazel to see the "skia-core" cc_library rule. See also "gms" and "tests" - modules/canvaskit/BUILD.bazel to see the use of the emscripten "wasm_cc_binary" rule, which depends on the "skia-core", "gms", and "tests" rule. Note that it only builds some of the gms as a proof of concept. - The other BUILD.bazel files. Some of these are not platform or feature dependent (e.g. pathops). Others are (e.g. gpu). - All other files. [1] https://docs.bazel.build/versions/4.2.1/skylark/config.html#user-defined-build-settings [2] https://github.com/emscripten-core/emsdk/pull/920 [3] In this CL, that's just the webgl one. [4] https://docs.bazel.build/versions/main/be/c-cpp.html#cc_library.local_defines Change-Id: Ieecf9c106d5e3a6ae97d13d66be06b4b3c207089 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458637 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com> Owners-Override: Kevin Lubick <kjlubick@google.com>
2021-11-08 20:26:09 +00:00
visibility = ["//:__subpackages__"],
[infra] Experiment generating BUILD.bazel files This uses the gazelle extension from https://skia-review.googlesource.com/c/buildbot/+/473357 Review Tips: - Ignore any changes to .h or .cpp files. Those have been pulled out into their own CLs. - Start with bazel/macros.bzl. - Read the CL with the generation code, if you haven't already. - Look at third_party/file_map_for_bazel.json. - See experimental/bazel_test for an idea of how a cc_binary would be made. - Spot check one or two of the BUILD.bazel files. This CL generates the "atomic" rules for src/, include/ and modules/skshaper, as a starting point. `bazel build --config clang //include/...` works `bazel build --config clang //src/...` starts compiling, (which verifies that the BUILD.bazel files are all valid), but runs into errors because not all third_party deps have been resolved, and there are some files missing from the toolchain still (e.g. EGL headers). Change-Id: Ib7e0fb0efdb9f08655f06cbc56e9bb4cf416294b Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474240 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2021-11-23 14:01:28 +00:00
deps = ["//include/core:SkRefCnt_hdr"],
[infra] Add initial Bazel rules and files These rules can be used to build our GMs on WASM+WebGL and libskia.a with just the CPU backend (and most other features turned off). This can be done with the following commands: - bazel build //modules/canvaskit:gm-bindings-wasm --gpu_backend=gl_backend --with_gl_standard=webgl_standard - bazel build :skia-core --config clang This pivots slightly from http://review.skia.org/463517 by using config_settings [1] instead of platforms for the optional features that we control. This pivot was suggested in [2] We have BUILD.bazel files in many of the subdirectories that specify filegroups for the appropriate files. In an effort to make //BUILD.bazel more readable, it is the responsibility of these subfolders to deal with conditionally including certain .h or .cpp files. This is done using select statements and config_settings or platform constraints as necessary. For example, src/gpu/BUILD.bazel will different private filegroups for each of the supported gpu backends [3] and a more-visible filegroup called "srcs" that has the right selection of the private files to be used for compilation. An effort has been made to avoid using glob() in our BUILD.bazel files. These file lists were made by using `ls -1` and some regex to add in quotes. We might want to make a helper script to assist with that, if necessary. To specify which options we have, the settings in //bazel/common_config_settings/BUILD.bazel have been redesigned. They make use of a macro `string_flag_with_values` that removes the boilerplate. Patchset 36 shows what the file looks like w/o the macro. The top level BUILD.bazel file will still need to use some logic to handle defines, because local_defines is a list of strings, not a list of labels [4]. Suggested Review Order: - WORKSPACE.bazel to see the new dependencies on the emsdk toolchain and bazel_skylib - bazel/common_config_settings/* to see the few settings defined (we have more to define, see BUILD.gn and //gn/skia.gni for ideas) - BUILD.bazel to see the "skia-core" cc_library rule. See also "gms" and "tests" - modules/canvaskit/BUILD.bazel to see the use of the emscripten "wasm_cc_binary" rule, which depends on the "skia-core", "gms", and "tests" rule. Note that it only builds some of the gms as a proof of concept. - The other BUILD.bazel files. Some of these are not platform or feature dependent (e.g. pathops). Others are (e.g. gpu). - All other files. [1] https://docs.bazel.build/versions/4.2.1/skylark/config.html#user-defined-build-settings [2] https://github.com/emscripten-core/emsdk/pull/920 [3] In this CL, that's just the webgl one. [4] https://docs.bazel.build/versions/main/be/c-cpp.html#cc_library.local_defines Change-Id: Ieecf9c106d5e3a6ae97d13d66be06b4b3c207089 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/458637 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com> Owners-Override: Kevin Lubick <kjlubick@google.com>
2021-11-08 20:26:09 +00:00
)
[bazel] Add mirrors to every external dependency. - We always download from https - All external assets have a primary and a mirror URL. - We prioritize the sources as follows: bazel mirror, github/original source, our mirror - There is a way (see build_toolchain) to test the sources from the mirrors (done before CL submission). This adds a utility to upload files to the mirror in a consistent, scripted way. It includes a way to copy in parts of our bazel files (e.g. debs_to_install from toolchain/build_toolchain.bzl) to update many things at once. Our Bazel mirror (gs://skia-world-readable/bazel) is a Content Addressable Storage system, where the file name is based on the sha256sum of the contents (the same hash that Bazel uses). All files in it should be publicly accessible. Change-Id: Ida8b8e07d27a0a557bc49467ebbc86c806cabbd3 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/494478 Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2022-01-13 15:19:38 +00:00
generated_cc_atom(
name = "SkUniquePaintParamsID_hdr",
hdrs = ["SkUniquePaintParamsID.h"],
visibility = ["//:__subpackages__"],
deps = ["//include/core:SkTypes_hdr"],
)
[bazel] Regenerate files and build with c++17 See toolchain/clang_toolchain_config.bzl for the c++17 switch. Most of the other changes were automatically generated (with the exception of //third_party). Change-Id: I8c0f4b29b5967da3f48b17eb298a7e92156277ac Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/502407 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2022-01-31 21:12:44 +00:00
generated_cc_atom(
name = "SingleOwner_hdr",
hdrs = ["SingleOwner.h"],
visibility = ["//:__subpackages__"],
deps = [
":SkMutex_hdr",
":SkThreadID_hdr",
"//include/core:SkTypes_hdr",
],
)
[canvaskit] Add skottie to Bazel build PS 1 regenerates existing Bazel files PS 2 adds generated Bazel files to skottie and its dependencies, as well as incorporating it into CanvasKit. This changes the version of Bazel we use to 5.0.0 (recently released).We had been using a pre-release of 6.0 because we wanted the new features in one of the 5.0 release candidates, but not the regression that was there (and reverted before the full 5.0 release). I'd like to stick to the latest stable Bazel release where possible. Suggested Review Order: - //modules/skottie/BUILD.bazel (this was hand written to encapsulate the skottie library). The files in the deps are based on skottie.gni. - //modules/skresources/BUILD.bazel and //modules/sksg/BUILD.bazel which expose all sources - //third_party/file_map_for_bazel.json which ignores the ffmpeg libraries (we won't actually build the SkVideoDecoder stuff because HAVE_VIDEO_DECODER is not set). - //modules/canvaskit/BUILD.bazel which makes use of the skottie library and includes the interface skottie.js file. - .bazelversion which changes the Bazel version used (e.g. by Bazelisk). - All other changes should be auto-generated or related to deleted files. Change-Id: Ic26f9a9dea5310f2cbd9cda7d701847924a39a22 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/503828 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Jorge Betancourt <jmbetancourt@google.com>
2022-02-04 15:05:29 +00:00
generated_cc_atom(
name = "SkStringView_hdr",
hdrs = ["SkStringView.h"],
visibility = ["//:__subpackages__"],
)
Reference in New Issue Copy Permalink