AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
42bc49d5d3
skia2/resources/sksl/shared/Overflow.sksl

45 lines
2.3 KiB
Plaintext
Raw Normal View History

Prevent overflow of integral types during constant-folding. Expressions which would overflow/wrap the result type are now left as-is. Change-Id: I6a942f337e6e5761823f5c9dcd214fa58227a626 Bug: skia:10932, skia:12050 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/413138 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-05-27 16:26:37 +00:00
uniform half4 colorGreen;
Add test demonstrating overflow error in SkSL. Change-Id: Ic6a3ce722c607d4d3c47d37e5749a01ae5fb193f Bug: skia:12050 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/412668 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-05-26 20:43:19 +00:00
half4 main(float2 coords) {
Tweak Overflow.sksl to generate the same output on Windows & other OS Change-Id: I26754745aa26313a2f76a86bd41699c7ac5b8a46 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441596 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2021-08-24 15:54:22 +00:00
half huge = 899999999.9 * 999999999.9 * 999999999.9 * 999999999.9 *
Add test demonstrating overflow error in SkSL. Change-Id: Ic6a3ce722c607d4d3c47d37e5749a01ae5fb193f Bug: skia:12050 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/412668 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-05-26 20:43:19 +00:00
999999999.9 * 999999999.9 * 999999999.9 * 999999999.9 *
999999999.9 * 999999999.9 * 999999999.9 * 999999999.9 *
999999999.9 * 999999999.9;
Prevent overflow of integral types during constant-folding. Expressions which would overflow/wrap the result type are now left as-is. Change-Id: I6a942f337e6e5761823f5c9dcd214fa58227a626 Bug: skia:10932, skia:12050 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/413138 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-05-27 16:26:37 +00:00
int hugeI = 16384
* 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2
* 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2;
uint hugeU = uint(16384)
* 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2
* 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2;
short hugeS = short(8192)
* 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2;
ushort hugeUS = ushort(8192)
* 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2;
int hugeNI = -16384
* 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2
* 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2;
short hugeNS = short(-8192)
* 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2 * 2;
Add overflow protection to vector-arithmetic folding. This was causing errors in UBSAN when compiling some of our existing SkSL tests. Change-Id: I66f22607094df77d47ff70948a139c77feae8624 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464118 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-10-27 14:09:05 +00:00
const int4 i4 = int4(2, 2, 2, 2);
int4 hugeIvec = i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 *
i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 *
i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4 * i4;
const uint4 u4 = uint4(2, 2, 2, 2);
uint4 hugeUvec = u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 *
u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 *
u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4 * u4;
Prevent overflow of integral types during constant-folding. Expressions which would overflow/wrap the result type are now left as-is. Change-Id: I6a942f337e6e5761823f5c9dcd214fa58227a626 Bug: skia:10932, skia:12050 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/413138 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-05-27 16:26:37 +00:00
return colorGreen * saturate(huge) * saturate(half(hugeI)) * saturate(half(hugeU)) *
saturate(half(hugeS)) * saturate(half(hugeUS)) *
Add overflow protection to vector-arithmetic folding. This was causing errors in UBSAN when compiling some of our existing SkSL tests. Change-Id: I66f22607094df77d47ff70948a139c77feae8624 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464118 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-10-27 14:09:05 +00:00
saturate(half(hugeNI)) * saturate(half(hugeNS)) *
saturate(half4(hugeIvec)) * saturate(half4(hugeUvec));
Add test demonstrating overflow error in SkSL. Change-Id: Ic6a3ce722c607d4d3c47d37e5749a01ae5fb193f Bug: skia:12050 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/412668 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-05-26 20:43:19 +00:00
}
Reference in New Issue Copy Permalink