AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
44c00ae64a
skia2/tests/sksl/errors/OverflowIntLiteral.glsl

10 lines
395 B
Plaintext
Raw Normal View History

Detect out-of-range integer assignment. Now that we know the minimum and maximum values of a given integer Type, we can check for assigment statements or variable initial-values that exceed those bounds and report it as an error. This check should work on anything that can be optimized or folded down to an IntLiteral, but isn't meant to be 100% exhaustive. Change-Id: I4473b5b003e1b8e3385943ce60e303e95664e8ba Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/413437 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-06-01 15:07:53 +00:00
### Compilation failed:
Add unit tests for overflowing int and uint literal limits. At present, we do not report any error; the values wrap silently. Change-Id: I8c435cfdd81f6c2e5fd87e9c39c708138bf4ec82 Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333676 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-11-10 19:17:42 +00:00
Detect out-of-range integer assignment. Now that we know the minimum and maximum values of a given integer Type, we can check for assigment statements or variable initial-values that exceed those bounds and report it as an error. This check should work on anything that can be optimized or folded down to an IntLiteral, but isn't meant to be 100% exhaustive. Change-Id: I4473b5b003e1b8e3385943ce60e303e95664e8ba Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/413437 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-06-01 15:07:53 +00:00
error: 4: integer is out of range for type 'int': -2147483649
error: 6: integer is out of range for type 'int': 2147483648
Reject scalar casts of literals to types that can't hold them. With this change, we no longer have any SkSL tests which are able to make a Literal integer that overflows its type. Literal::MakeInt now asserts that its value is within bounds. I look forward to the fuzzer's inevitable attempts to trigger these assertions. Change-Id: I7b15e862caaf65984d33f5d72d2c1de816d1d292 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464124 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-10-27 18:14:53 +00:00
error: 8: integer is out of range for type 'short': -32769
error: 9: integer is out of range for type 'short': 32768
Report int-literal overflow via cast-from-float. The fuzzer discovered that SkSL could create an out-of-range int literal by casting from a floating point literal. We were only doing range checks when the starting literal was an integer. Since we now assert when an out-of-range int literal is created (as of http://review.skia.org/464124), the fuzzer can detect this error. Change-Id: Ie66f60ddbe7b4fbe5b648c17292c59a4ba079716 Bug: oss-fuzz:40456 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/465385 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-10-29 14:21:50 +00:00
error: 11: integer is out of range for type 'int': 2147483648
error: 12: integer is out of range for type 'short': 32768
6 errors
Reference in New Issue Copy Permalink