AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
44c00ae64a
skia2/tests/sksl/runtime_errors/LoopStructureErrors.skvm

19 lines
876 B
Plaintext
Raw Normal View History

In runtime effects, verify that loops conform to ES2 rules Bug: skia:11094 Change-Id: I68a08e79d29579901b74daca3c22f5112fbb3c8c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/353356 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2021-01-12 22:15:30 +00:00
### Compilation failed:
Improve unit testing of for-loops. An ES2-compatible for loop supports six separate rel-ops: < <= > >= != == Each rel-op, in addition to its expected usage, is also able to represent a loop which never terminates, as well as a loop which terminates instantly. Since SkVM unrolls these loops, we should make sure we do it properly. We now have unit tests for all of these cases. Change-Id: Icae04d48bc158bf8c0c98db97f76756a1a29110c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445756 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-09-04 18:44:19 +00:00
error: 6: loop must guarantee termination in fewer iterations
error: 7: invalid loop expression
Increase GetLoopUnrollInfo loop-count limit to 100,000. To do this with a clean conscience, I needed to convert the unroll- counting logic from a linear time algorithm to constant-time. Getting all the edge cases correct requires a lot of care, and there are now plenty of unit tests. Change-Id: I620909d069ac425b7310e345bf80ec844fe035f8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445643 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-09-07 15:43:51 +00:00
error: 8: invalid loop expression
error: 9: loop must guarantee termination in fewer iterations
Improve unit testing of for-loops. An ES2-compatible for loop supports six separate rel-ops: < <= > >= != == Each rel-op, in addition to its expected usage, is also able to represent a loop which never terminates, as well as a loop which terminates instantly. Since SkVM unrolls these loops, we should make sure we do it properly. We now have unit tests for all of these cases. Change-Id: Icae04d48bc158bf8c0c98db97f76756a1a29110c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445756 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-09-04 18:44:19 +00:00
error: 14: loop index must not be modified within body of the loop
Increase GetLoopUnrollInfo loop-count limit to 100,000. To do this with a clean conscience, I needed to convert the unroll- counting logic from a linear time algorithm to constant-time. Getting all the edge cases correct requires a lot of care, and there are now plenty of unit tests. Change-Id: I620909d069ac425b7310e345bf80ec844fe035f8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445643 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-09-07 15:43:51 +00:00
error: 15: loop index must not be modified within body of the loop
error: 16: loop index must not be modified within body of the loop
Improve unit testing of for-loops. An ES2-compatible for loop supports six separate rel-ops: < <= > >= != == Each rel-op, in addition to its expected usage, is also able to represent a loop which never terminates, as well as a loop which terminates instantly. Since SkVM unrolls these loops, we should make sure we do it properly. We now have unit tests for all of these cases. Change-Id: Icae04d48bc158bf8c0c98db97f76756a1a29110c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445756 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-09-04 18:44:19 +00:00
error: 18: loop must guarantee termination in fewer iterations
error: 19: loop must guarantee termination in fewer iterations
Increase GetLoopUnrollInfo loop-count limit to 100,000. To do this with a clean conscience, I needed to convert the unroll- counting logic from a linear time algorithm to constant-time. Getting all the edge cases correct requires a lot of care, and there are now plenty of unit tests. Change-Id: I620909d069ac425b7310e345bf80ec844fe035f8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445643 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-09-07 15:43:51 +00:00
error: 20: loop must guarantee termination in fewer iterations
error: 21: loop must guarantee termination in fewer iterations
error: 22: invalid loop expression
error: 23: invalid loop expression
error: 24: loop must guarantee termination in fewer iterations
error: 25: loop must guarantee termination in fewer iterations
Improve unit testing of for-loops. An ES2-compatible for loop supports six separate rel-ops: < <= > >= != == Each rel-op, in addition to its expected usage, is also able to represent a loop which never terminates, as well as a loop which terminates instantly. Since SkVM unrolls these loops, we should make sure we do it properly. We now have unit tests for all of these cases. Change-Id: Icae04d48bc158bf8c0c98db97f76756a1a29110c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445756 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-09-04 18:44:19 +00:00
15 errors
Reference in New Issue Copy Permalink