AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
508eba7578
skia2/tests/sksl/shared/golden/ConstArray.metal

5 lines
94 B
Metal
Raw Normal View History

Fix various codegen issues for Metal array types. This CL fixes cases where array dimensions could be placed on the type instead of the variable (`float[2] x` instead of `float x[2]`). It also reports errors in cases where arrays aren't syntactically valid in Metal, rather than emitting unusable Metal code. (Some of these cases are actually invalid GLSL as well! But those fixes are coming in followup CLs.) Change-Id: I22279127c8a9aa2f22bf5ea3d225e563c2e254f2 Bug: skia:10926, skia:10760, skia:10761 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340137 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-03 04:35:49 +00:00
### Compilation failed:
Fix various SkSL errors that don't report a line number. Change-Id: I1a96060b2e52cddb50948a48520aab30bd097bbd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/343577 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-12-11 22:30:47 +00:00
error: 1: Metal does not support array types in this context
Fix various codegen issues for Metal array types. This CL fixes cases where array dimensions could be placed on the type instead of the variable (`float[2] x` instead of `float x[2]`). It also reports errors in cases where arrays aren't syntactically valid in Metal, rather than emitting unusable Metal code. (Some of these cases are actually invalid GLSL as well! But those fixes are coming in followup CLs.) Change-Id: I22279127c8a9aa2f22bf5ea3d225e563c2e254f2 Bug: skia:10926, skia:10760, skia:10761 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340137 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-03 04:35:49 +00:00
1 error
Reference in New Issue Copy Permalink