This website requires JavaScript.
ReeceSX
Explore
Aurora
Register
Sign In
AuroraMiddleware
/
skia2
Watch
1
Star
0
Fork
0
You've already forked skia2
Code
Issues
Pull Requests
Projects
Releases
Wiki
Activity
5420cbcf65
skia2
/
tests
/
sksl
/
shared
/
Ossfuzz26167.glsl
5 lines
28 B
Plaintext
Raw
Normal View
History
Unescape
Escape
Fix use-after-free discovered by fuzzer. In cases where multiple variables were declared on a single line, it is legal for variable initialization-expressions to reference variables declared earlier in the var-decl statement. It is NOT legal for the inliner to move those references up to the previous statement, where the variable doesn't exist yet. This is mitigated by disabling the IRGenerator inliner for var-decls past the first one in a var-decls statement. (The optimizer will still pass over this code later and is able to inline it correctly, if it is worth doing.) Change-Id: I7a0d45eab20e30ed9f6b2f5c1251b6e0d8eeaea3 Bug: oss-fuzz:26167 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/329357 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-10-23 13:46:11 +00:00
void main() {
Revert "Inline functions of the form 'return (expr)' only." This reverts commit 92748af1a5051e9fe329c8200f0fa3b47aadbdd7. Reason for revert: SkSLCommaSideEffects_GPU crashing on Android Original change's description: > Inline functions of the form 'return (expr)' only. > > This drastically reduces the number of functions which we allow to be > inlined. If this change does not hurt our performance, it will allow us > to trivially remove hundreds of LOC. All current data leads us to > believe that it may affect the Mali 400 but is highly unlikely to change > results on any other device in the tree. > > More info: http://go/optimization-in-sksl-inliner > > Change-Id: Ia6b706742ce5407453e0e697b6c1f9201084c0e8 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384858 > Auto-Submit: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I6a670dacaa58fe3386ff50375ac6d1cac4fd7f2c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385161 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-03-15 22:08:38 +00:00
false;
Fix use-after-free discovered by fuzzer. In cases where multiple variables were declared on a single line, it is legal for variable initialization-expressions to reference variables declared earlier in the var-decl statement. It is NOT legal for the inliner to move those references up to the previous statement, where the variable doesn't exist yet. This is mitigated by disabling the IRGenerator inliner for var-decls past the first one in a var-decls statement. (The optimizer will still pass over this code later and is able to inline it correctly, if it is worth doing.) Change-Id: I7a0d45eab20e30ed9f6b2f5c1251b6e0d8eeaea3 Bug: oss-fuzz:26167 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/329357 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-10-23 13:46:11 +00:00
}
Reference in New Issue
Copy Permalink