AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
573dcb7682
skia2/tests/sksl/errors/golden/ArrayTooManyDimensions.glsl

5 lines
73 B
Plaintext
Raw Normal View History

Limit arrays to a maximum of eight dimensions. This addresses a sanitizer issue discovered in https://oss-fuzz.com/testcase-detail/4908118777266176 (it has not been assigned an oss-fuzz bug number yet; coming soon) We need to set some sort of limit here to avoid stack overflow. Eight array dimensions seems like more than enough for any sort of code that we might realistically need, but the limit is definitely flexible if we wanted to increase it. (The fuzzer needed to generate a several- hundred-dimensional array before encountering a crash.) Change-Id: I3630ab40e47cc58a2280ba200b485e1958371fdc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333160 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-11-10 15:03:50 +00:00
### Compilation failed:
Add unit test for array with many dimensions. This addresses a sanitizer issue discovered in https://oss-fuzz.com/testcase-detail/4908118777266176 (it has not been assigned an oss-fuzz bug number yet; coming soon) A followup CL will limit array dimensionality to 8. This is an arbitrary choice which is hopefully larger than any reasonable program will need. Change-Id: I4cf05f40ec92c1c3444c71c45f759bb30d7da3c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333135 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-10 15:01:39 +00:00
Limit arrays to a maximum of eight dimensions. This addresses a sanitizer issue discovered in https://oss-fuzz.com/testcase-detail/4908118777266176 (it has not been assigned an oss-fuzz bug number yet; coming soon) We need to set some sort of limit here to avoid stack overflow. Eight array dimensions seems like more than enough for any sort of code that we might realistically need, but the limit is definitely flexible if we wanted to increase it. (The fuzzer needed to generate a several- hundred-dimensional array before encountering a crash.) Change-Id: I3630ab40e47cc58a2280ba200b485e1958371fdc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/333160 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-11-10 15:03:50 +00:00
error: 1: array has too many dimensions
1 error
Reference in New Issue Copy Permalink