This website requires JavaScript.
ReeceSX
Explore
Aurora
Register
Sign In
AuroraMiddleware
/
skia2
Watch
1
Star
0
Fork
0
You've already forked skia2
Code
Issues
Pull Requests
Projects
Releases
Wiki
Activity
5b1ae4b285
skia2
/
tests
/
sksl
/
errors
/
OverflowFloatLiteral.glsl
5 lines
87 B
Plaintext
Raw
Normal View
History
Unescape
Escape
Detect and report numeric overflows in the SkSL parser. Previously, some types of overflow were detected, but most would assert or silently generate invalid code. Now, the parser will properly report an error if it encounters any integer that exceeds UINT_MAX or any float that exceeds FLT_MAX. This fixes test OverflowUintLiteral.sksl. Added a test for floats as well, OverflowFloatLiteral.sksl. OverflowIntLiteral.sksl does not fail yet, because its values are larger than INT_MAX, not UINT_MAX. These are legal from the perspective of the parser. This must be caught later at IR generation time. Change-Id: Ia5a904d01427cdc9f2ab5f4174154418737835e6 Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/347176 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-23 23:58:43 +00:00
### Compilation failed:
error: 2: floating-point value is too large: 3.41e+38
SkSL: Turn DSL parser off again Several fuzzer issues, and one Chromium issue that's blocking the roll. Bug: chromium:1246795 Bug: skia:12423 Change-Id: I00370b74569b447e543d9a1f22c588eb493063da Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445960 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Brian Osman <brianosman@google.com>
2021-09-07 13:36:08 +00:00
1 error
Reference in New Issue
Copy Permalink