AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
733fd74c29
skia2/tests/sksl/errors/ArrayOfInvalidSize.glsl

22 lines
705 B
Plaintext
Raw Normal View History

Improve error-checking during array-size conversion. The fuzzer noticed insufficient guards in IndexExpression::Convert when converting an array size from an IntLiteral to a SKSL_INT. We had code in IRGenerator which did this properly, so I moved our array-size conversion logic into SkSLType and had IndexExpression share it. Also, a variety of tests around similar error conditions were added. Change-Id: I51529dea25f9029f81ae236511610069d66be29f Bug: oss-fuzz:37462 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441236 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-08-23 13:24:33 +00:00
### Compilation failed:
error: 1: array size must be positive
error: 2: array size must be positive
error: 3: array size must be positive
error: 4: expected 'int', but found 'float'
error: 5: array size is too large
error: 6: expected 'int', but found 'bool'
error: 7: expected 'int', but found 'bool'
error: 8: expected 'int', but found 'int2'
Flip the switch to activate DSLParser Change-Id: Id894eb70273454716eb33c85dff2056333e90cdd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445281 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-09-03 17:06:31 +00:00
error: 9: missing index in '[]'
Improve error-checking during array-size conversion. The fuzzer noticed insufficient guards in IndexExpression::Convert when converting an array size from an IntLiteral to a SKSL_INT. We had code in IRGenerator which did this properly, so I moved our array-size conversion logic into SkSLType and had IndexExpression share it. Also, a variety of tests around similar error conditions were added. Change-Id: I51529dea25f9029f81ae236511610069d66be29f Bug: oss-fuzz:37462 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441236 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-08-23 13:24:33 +00:00
error: 10: array size must be positive
error: 11: array size must be positive
error: 12: array size must be positive
Flip the switch to activate DSLParser Change-Id: Id894eb70273454716eb33c85dff2056333e90cdd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445281 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-09-03 17:06:31 +00:00
error: 13: expected int literal
error: 14: array size out of bounds
error: 15: expected int literal
error: 16: expected int literal
error: 17: expected int literal
error: 18: expected array dimension
Improve error-checking during array-size conversion. The fuzzer noticed insufficient guards in IndexExpression::Convert when converting an array size from an IntLiteral to a SKSL_INT. We had code in IRGenerator which did this properly, so I moved our array-size conversion logic into SkSLType and had IndexExpression share it. Also, a variety of tests around similar error conditions were added. Change-Id: I51529dea25f9029f81ae236511610069d66be29f Bug: oss-fuzz:37462 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441236 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-08-23 13:24:33 +00:00
18 errors
Reference in New Issue Copy Permalink