skia2/tests/sksl/errors/golden/UndefinedFunction.glsl


int foo(int x);
void main() {
    int x = foo(1);
}
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2020-09-17 22:20:26 +00:00
Improve support for function prototypes in SkSL. Previously, when a prototype was parsed, this added a function declaration to the symbol table, but the prototype itself was not re-emitted during code generation. This meant that the final code might not be valid, since the absence of prototypes meant that the code might attempt to invoke a function before its declaration. Now, prototypes are stored in the ProgramElement list and re-emitted during code generation for GLSL/Metal/CPP. (SPIR-V doesn't name its functions at all.) Change-Id: I76446c796000eb0b56f964d82457122182c28b87 Bug: skia:10872 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331136 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2020-11-03 17:18:22 +00:00			`int foo(int x);`
Add test cases to function-prototype golden outputs. - Prototypes for never-declared functions - Prototype before use - Prototype after use - A variety of inputs and outputs on the prototyped functions. - Calling declared-but-undefined functions Currently, the prototypes are not actually emitted in the generated GLSL or Metal output at all. This CL is demonstrates our baseline before proper prototype support is added. Change-Id: I6112e0a89ab9bbecefccaca9fba985bb8011fff1 Bug: skia:10872 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/331376 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2020-11-02 16:38:19 +00:00			`void main() {`
			`int x = foo(1);`
			`}`