This website requires JavaScript.
ReeceSX
Explore
Aurora
Register
Sign In
AuroraMiddleware
/
skia2
Watch
1
Star
0
Fork
0
You've already forked skia2
Code
Issues
Pull Requests
Projects
Releases
Wiki
Activity
87e472722f
skia2
/
tests
/
sksl
/
errors
/
StructVariableReservedName.glsl
7 lines
92 B
Plaintext
Raw
Normal View
History
Unescape
Escape
Prevent structs/interface-blocks from claiming builtin types. Structs and interface blocks allow a trailing identifier which is added to the symbol table. This identifier is now prohibited from overlapping built-in types. Change-Id: I33b9d6156a27ce017e6744a05979748c04a04767 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489516 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 18:50:14 +00:00
### Compilation failed:
Add test demonstrating struct/interface-block name conflict. Structs and interface blocks allow a trailing identifier which is added to the symbol table. This identifier should be prohibited from overlapping built-in types; at present, this is not checked. Add a test demonstrating the issue. Change-Id: I99aa915c1715c468cc369c97b7f12e031b86ea4a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489496 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-12-28 18:46:27 +00:00
Prevent structs/interface-blocks from claiming builtin types. Structs and interface blocks allow a trailing identifier which is added to the symbol table. This identifier is now prohibited from overlapping built-in types. Change-Id: I33b9d6156a27ce017e6744a05979748c04a04767 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489516 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 18:50:14 +00:00
error: 3: expected ';', but found 'float'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
} float;
^^^^^
Prevent structs/interface-blocks from claiming builtin types. Structs and interface blocks allow a trailing identifier which is added to the symbol table. This identifier is now prohibited from overlapping built-in types. Change-Id: I33b9d6156a27ce017e6744a05979748c04a04767 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/489516 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2021-12-28 18:50:14 +00:00
1 error
Reference in New Issue
Copy Permalink